Skip to contentSkip to conversation

Source code compatibility in Stable series????

DISCUSSION Petr Vandrovec 1 participant 1 message May 11, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · Andi Kleen
Quoted 3 lines · Petr Vandrovec

When I was updating VMware's vmnet, I decided to use

#ifdef skb_shinfo

Yes I forgot that RedHat already shipped it :-(

Not only that RedHat shipped it, but thousands of people used Alan's patches since 25th February. So you cannot check kernel version for >=2.4.4.

Quoted 6 lines
Quoted 4 lines

This gives you maximal backward compatibility, as all public zerocopy patches contain this macro. Only thing is that Dave has to remember that when he turns skb_shinfo into inline function, an identity #define have to be added.

No such guarantee for binary only software ;)

vmnet is GPLed software, if you did not notice ;-) Fortunately change went into Alan tree first, so I noticed long before 2.4.4 came out. Although it took nonzero effort to persuade others that it will go into Linus's 2.4.x even if it breaks API. They did not trust me that source compatibility in stable series is only a wish.
Petr Vandrovec [email protected]