package/postgresql: fix filesystem naming consistency
PATCH 1/1 package/postgresql: fix filesystem naming consistency
Currently the service is called postgresql, but other filesystem references are called pgsql, which is inconsistent and confusing.
Given that at least Debian uses postgresql in the filesystems as well I would suggest moving the filesystem reference to align with the service name as opposed to the other way around.
--- package/postgresql/Config.in | 2 +- package/postgresql/S50postgresql | 8 ++++---- package/postgresql/postgresql.mk | 4 ++-- package/postgresql/postgresql.service | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-)
package/postgresql/Config.in +1 -1
@@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL database system. Enable the readline package to gain readline support in - pgsql (the command line interpreter), which offers + psql (the command line interpreter), which offers command history and edit functions. Enable the zlib package to gain builtin compression for
package/postgresql/S50postgresql +4 -4
@@ -5,20 +5,20 @@ umask 077 -if [ ! -f /var/lib/pgsql/PG_VERSION ]; then +if [ ! -f /var/lib/postgresql/PG_VERSION ]; then echo "Initializing postgresql data base..." - su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql' + su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/postgresql' echo "done" fi start() { printf "Starting postgresql: " - su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/pgsql -l logfile' + su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/postgresql -l logfile' echo "OK" } stop() { printf "Stopping postgresql: " - su - postgres -c '/usr/bin/pg_ctl stop -D /var/lib/pgsql -m fast' + su - postgres -c '/usr/bin/pg_ctl stop -D /var/lib/postgresql -m fast' echo "OK" } restart() {
package/postgresql/postgresql.mk +2 -2
@@ -102,11 +102,11 @@ endif POSTGRESQL_CONF_ENV += CFLAGS="$(POSTGRESQL_CFLAGS)" define POSTGRESQL_USERS - postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server + postgres -1 postgres -1 * /var/lib/postgresql /bin/sh - PostgreSQL Server endef define POSTGRESQL_INSTALL_TARGET_FIXUP - $(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/pgsql + $(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/postgresql $(RM) -rf $(TARGET_DIR)/usr/lib/postgresql/pgxs endef
package/postgresql/postgresql.service +3 -3
@@ -15,10 +15,10 @@ Group=postgres StandardOutput=syslog StandardError=syslog SyslogIdentifier=postgres -PIDFile=/var/lib/pgsql/postmaster.pid +PIDFile=/var/lib/postgresql/postmaster.pid -ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql; fi" -ExecStart=/usr/bin/postgres -D /var/lib/pgsql +ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/postgresql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/postgresql; fi" +ExecStart=/usr/bin/postgres -D /var/lib/postgresql ExecReload=/usr/bin/kill -HUP $MAINPID KillMode=mixed KillSignal=SIGINT
Signature · 1 line
2.7.4
PATCH 1/1 package/postgresql: fix filesystem naming consistency
Quoted 20 lines · On Thu, 28 Nov 2019 12:15:42 +0100 Pascal de Bruijn <[email protected]>…
Currently the service is called postgresql, but other filesystem references are called pgsql, which is inconsistent and confusing.
Given that at least Debian uses postgresql in the filesystems as well I would suggest moving the filesystem reference to align with the service name as opposed to the other way around.
Signed-off-by Pascal de Bruijn <[email protected]>--- package/postgresql/Config.in | 2 +- package/postgresql/S50postgresql | 8 ++++---- package/postgresql/postgresql.mk | 4 ++-- package/postgresql/postgresql.service | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-)package/postgresql/Config.in +0
-0
package/postgresql/Config.in config BR2_PACKAGE_POSTGRESQL · line 14
Quoted 5 lines
package/postgresql/Config.in +1
-1@@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL database system. Enable the readline package to gain readline support in - pgsql (the command line interpreter), which offers + psql (the command line interpreter), which offers
This doesn't seem to be related to the commit. Also, is the command line tool really called psql ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/postgresql: fix filesystem naming consistency
From: Thomas Petazzoni <[email protected]>
To: Pascal de Bruijn <[email protected]>
Cc: <[email protected]>
Sent: 11/28/2019 4:36 PM
Subject: Re: [Buildroot] [PATCH] package/postgresql: fix filesystem naming consistency
Quoted 20 lines · On Thu, 28 Nov 2019 12:15:42 +0100 Pascal de Bruijn <[email protected]>…
Currently the service is called postgresql, but other filesystem references are called pgsql, which is inconsistent and confusing.
Given that at least Debian uses postgresql in the filesystems as well I would suggest moving the filesystem reference to align with the service name as opposed to the other way around.
Signed-off-by Pascal de Bruijn <[email protected]>---
?package/postgresql/Config.in ? ? ? ? ?| 2 +- ?package/postgresql/S50postgresql ? ? ?| 8 ++++---- ?package/postgresql/postgresql.mk ? ? ?| 4 ++-- ?package/postgresql/postgresql.service | 6 +++---?4 files changed, 10 insertions(+), 10 deletions(-)
package/postgresql/Config.in +0
-0@@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL
Quoted 5 lines
? ? ? ? database system.
?
? ? ? ? Enable the readline package to gain readline support in
- ? ? ? pgsql (the command line interpreter), which offers
+ ? ? ? psql (the command line interpreter), which offers
This doesn't seem to be related to the commit. Also, is the command line tool really called psql ?
Yes, it's not directly related, but just a minor typo fix.
The command is indeed called psql.
Regards,
Pascal de Bruijn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191128/ff218cd1/attachment.html>
PATCH 1/1 package/postgresql: fix filesystem naming consistency
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Pascal" == Pascal de Bruijn <[email protected]> writes:
Hi,
Quoted 9 lines
Quoted 2 lines
- ? ? ? pgsql (the command line interpreter), which offers
+ ? ? ? psql (the command line interpreter), which offersThis doesn't seem to be related to the commit. Also, is the command line tool really called psql ?
Yes, it's not directly related, but just a minor typo fix.
The command is indeed called psql.
Ok, could you send a separate patch just for that typo so we can apply it to master? The path change looks like next material to me.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/postgresql: fix filesystem naming consistency
In reply to Pascal de BruijnHello Pascal,
Quoted 20 lines · Pascal de Bruijn
Currently the service is called postgresql, but other filesystem references are called pgsql, which is inconsistent and confusing.
Given that at least Debian uses postgresql in the filesystems as well I would suggest moving the filesystem reference to align with the service name as opposed to the other way around.
Signed-off-by Pascal de Bruijn <[email protected]>--- package/postgresql/Config.in | 2 +- package/postgresql/S50postgresql | 8 ++++---- package/postgresql/postgresql.mk | 4 ++-- package/postgresql/postgresql.service | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-)package/postgresql/Config.in +0
-0
package/postgresql/Config.in config BR2_PACKAGE_POSTGRESQL · line 14
Quoted 5 lines
package/postgresql/Config.in +1
-1@@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL database system. Enable the readline package to gain readline support in - pgsql (the command line interpreter), which offers + psql (the command line interpreter), which offers
+1 for fixing this typo (which dates back to my initial submission from 2014) in a separate patch...
Quoted 8 lines
package/postgresql/Config.in +0
-0command history and edit functions. Enable the zlib package to gain builtin compression forpackage/postgresql/S50postgresql +0
-0
package/postgresql/S50postgresql line 10
Quoted 8 lines
package/postgresql/S50postgresql +2
-2@@ -5,20 +5,20 @@ umask 077 -if [ ! -f /var/lib/pgsql/PG_VERSION ]; then +if [ ! -f /var/lib/postgresql/PG_VERSION ]; then echo "Initializing postgresql data base..." - su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql' + su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/postgresql'
-1 for this change as /var/lib/pgsql is the suggested/common default location, see e.g. [1], and is saving 5 characters at many location from the script ;-)
Regards,
Peter
[1] https://www.postgresql.org/docs/12/storage-file-layout.html
Quoted 52 lines
package/postgresql/S50postgresql +2
-2echo "done" fi start() { printf "Starting postgresql: " - su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/pgsql -l logfile' + su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/postgresql -l logfile' echo "OK" } stop() { printf "Stopping postgresql: " - su - postgres -c '/usr/bin/pg_ctl stop -D /var/lib/pgsql -m fast' + su - postgres -c '/usr/bin/pg_ctl stop -D /var/lib/postgresql -m fast' echo "OK" } restart() {package/postgresql/postgresql.mk +2
-2@@ -102,11 +102,11 @@ endif POSTGRESQL_CONF_ENV += CFLAGS="$(POSTGRESQL_CFLAGS)" define POSTGRESQL_USERS - postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server + postgres -1 postgres -1 * /var/lib/postgresql /bin/sh - PostgreSQL Server endef define POSTGRESQL_INSTALL_TARGET_FIXUP - $(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/pgsql + $(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/postgresql $(RM) -rf $(TARGET_DIR)/usr/lib/postgresql/pgxs endefpackage/postgresql/postgresql.service +3
-3@@ -15,10 +15,10 @@ Group=postgres StandardOutput=syslog StandardError=syslog SyslogIdentifier=postgres -PIDFile=/var/lib/pgsql/postmaster.pid +PIDFile=/var/lib/postgresql/postmaster.pid -ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql; fi" -ExecStart=/usr/bin/postgres -D /var/lib/pgsql +ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/postgresql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/postgresql; fi" +ExecStart=/usr/bin/postgres -D /var/lib/postgresql ExecReload=/usr/bin/kill -HUP $MAINPID KillMode=mixed KillSignal=SIGINT
PATCH 1/1 package/postgresql: fix filesystem naming consistency
From: Peter Seiderer <[email protected]>
To: Pascal de Bruijn <[email protected]>
Cc: <[email protected]>
Sent: 11/28/2019 10:38 PM
Subject: Re: [Buildroot] [PATCH] package/postgresql: fix filesystem naming consistency
Hello Pascal,
Quoted 22 lines · Pascal de Bruijn
Currently the service is called postgresql, but other filesystem references are called pgsql, which is inconsistent and confusing.
Given that at least Debian uses postgresql in the filesystems as well I would suggest moving the filesystem reference to align with the service name as opposed to the other way around.
Signed-off-by Pascal de Bruijn <[email protected]>---
?package/postgresql/Config.in ? ? ? ? ?| 2 +- ?package/postgresql/S50postgresql ? ? ?| 8 ++++---- ?package/postgresql/postgresql.mk ? ? ?| 4 ++-- ?package/postgresql/postgresql.service | 6 +++---?4 files changed, 10 insertions(+), 10 deletions(-)
package/postgresql/Config.in +0
-0@@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL? ? ? ? database system.
Quoted 3 lines
? ? ? ? Enable the readline package to gain readline support in
- ? ? ? pgsql (the command line interpreter), which offers
+ ? ? ? psql (the command line interpreter), which offers
+1 for fixing this typo (which dates back to my initial submission from 2014) in a separate patch...
Quoted 13 lines
? ? ? ? command history and edit functions.
? ? ? ? Enable the zlib package to gain builtin compression for
package/postgresql/S50postgresql +0
-0@@ -5,20 +5,20 @@?umask 077
package/postgresql/S50postgresql +1
-1-if [ ! -f /var/lib/pgsql/PG_VERSION ]; then +if [ ! -f /var/lib/postgresql/PG_VERSION ]; then
Quoted 3 lines
? ? ? echo "Initializing postgresql data base..."
- ? ? su - postgres -c '/usr/bin/pg_ctlinitdb -D/var/lib/pgsql'
+ ? ? su - postgres -c '/usr/bin/pg_ctlinitdb -D/var/lib/postgresql'
-1 for this change as /var/lib/pgsql is the suggested/common default location, see e.g. [1], and is saving 5 characters at many location from the script ;-)
This comes down to:
Do you want to stick with an upstream recommendation even if it's ill considered... Given this is a trivially avoided inconsistency.
The whole point of having consistent naming between service and related directories is that you don't even have to look in the documentation where things are.
On a sidenote, PostgreSQL does look for /etc/postgresql/postgresql.conf regardless and not /etc/pgsql/pgsql.conf, so it's a bit of mess really...
As far as I can tell Debian choose to fix this, and RedHat seems to have stuck with the upstream inconsistency as well.
So ultimately it's a bit of philosophical choice...
Regards,
Pascal de Bruijn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191129/ac3c8cfd/attachment.html>
PATCH 1/1 package/postgresql: fix filesystem naming consistency
Quoted 1 line · Pascal de Bruijn
From: Peter Seiderer <[email protected]>
[snip]
Quoted 8 lines
Quoted 5 lines
package/postgresql/S50postgresql +1
-1-if [ ! -f /var/lib/pgsql/PG_VERSION ]; then +if [ ! -f /var/lib/postgresql/PG_VERSION ]; then? ? ? echo "Initializing postgresql data base..."
- ? ? su - postgres -c '/usr/bin/pg_ctlinitdb -D/var/lib/pgsql'
+ ? ? su - postgres -c '/usr/bin/pg_ctlinitdb -D/var/lib/postgresql'-1 for this change as
/var/lib/pgsqlis the suggested/common default location, see e.g. [1], and is saving 5 characters at many location from the script ;-)
More important than whether it is suggested by upstream, though: changing it
now breaks existing installations. Indeed, anyone who has installed a system with existing current buildroot will have the databases in /var/ib/pgsql. After this change, upgrading the system to newer buildroot will result in the databases no longer being found and instead new databases are created...
So, at least a "legacy" symlink pgsql->postgresql must be created. But even
that is a bit iffy, because it's likely that the databases are not directly in the readonly rootfs, but symlinked to a (writeable) data partition. So the symlink must be created at runtime. But even then, you can't know if the user put the whole of /var/lib on the writeable partition, or just /var/lib/pgsql...
Quoted 3 lines
This comes down to:
Do you want to stick with an upstream recommendation even if it's ill considered... Given this is a trivially avoided inconsistency.
It was trivially avoidable 5 years ago. Now, it is no longer trivial.
Quoted 5 lines
The whole point of having consistent naming between service and related directories is that you don't even have to look in the documentation where things are.
On a sidenote, PostgreSQL does look for
/etc/postgresql/postgresql.confregardless and not/etc/pgsql/pgsql.conf, so it's a bit of mess really...
If these are the only reasons for changing the name, then I don't think it's
worth the bother of breaking existing systems.
Regards,
Arnout
Quoted 19 lines
As far as I can tell Debian choose to fix this, and RedHat seems to have stuck with the upstream inconsistency as well.
So ultimately it's a bit of philosophical choice...
Regards,
Pascal de Bruijn_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/postgresql: fix filesystem naming consistency
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Hello,
Quoted 10 lines
Quoted 7 lines
The whole point of having consistent naming between service and related directories is that you don't even have to look in the documentation where things are.
On a sidenote, PostgreSQL does look for
/etc/postgresql/postgresql.confregardless and not/etc/pgsql/pgsql.conf, so it's a bit of mess really...If these are the only reasons for changing the name, then I don't think it's
worth the bother of breaking existing systems.
Agreed.
Signature · 1 line
Bye, Peter Korsgaard