Skip to contentSkip to conversation

arm: Hook up SYNC_CORE functionality for sys_membarrier()

PATCH New Will Deacon 3 participants 3 messages Jun 26, 2018

Subsystems (2)
Documentation Arm (32-bit)
lore
Share & tools
lore

Will Deacon

author
#0 lore raw

PATCH v2 1/1 arm: Hook up SYNC_CORE functionality for sys_membarrier()

Exception return implies context synchronization, so we can hook up the SYNC_CORE option to sys_membarrier() simply by selecting the Kconfig option, just like we've done for arm64 already.

Cc Mathieu Desnoyers <[email protected]>
Cc Orion Hodson <[email protected]>
Signed-off-by Will Deacon <[email protected]>

---

v1 -> v2: Update arch-support.txt

 .../features/sched/membarrier-sync-core/arch-support.txt          | 8 ++++----
 arch/arm/Kconfig                                                  | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)
Documentation/features/sched/membarrier-sync-core/arch-support.txt +4 -4
index dbdf62907703..c7858dd1ea8f 100644
@@ -5,10 +5,10 @@
 #
 # Architecture requirements
 #
-# * arm64
+# * arm/arm64
 #
-# Rely on eret context synchronization when returning from IPI handler, and
-# when returning to user-space.
+# Rely on implicit context synchronization as a result of exception return
+# when returning from IPI handler, and when returning to user-space.
 #
 # * x86
 #

@@ -31,7 +31,7 @@
     -----------------------
     |       alpha: | TODO |
     |         arc: | TODO |
-    |         arm: | TODO |
+    |         arm: |  ok  |
     |       arm64: |  ok  |
     |         c6x: | TODO |
     |       h8300: | TODO |
arch/arm/Kconfig +1 -0
index 54eeb8d00bc6..b0ac18547370 100644
@@ -9,6 +9,7 @@ config ARM
 	select ARCH_HAS_ELF_RANDOMIZE
 	select ARCH_HAS_FORTIFY_SOURCE
 	select ARCH_HAS_KCOV
+	select ARCH_HAS_MEMBARRIER_SYNC_CORE
 	select ARCH_HAS_PTE_SPECIAL if ARM_LPAE
 	select ARCH_HAS_PHYS_TO_DMA
 	select ARCH_HAS_SET_MEMORY
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/1 arm: Hook up SYNC_CORE functionality for sys_membarrier()

Quoted 7 lines · Will Deacon will.deacon at arm.com

Exception return implies context synchronization, so we can hook up the SYNC_CORE option to sys_membarrier() simply by selecting the Kconfig option, just like we've done for arm64 already.

Cc Mathieu Desnoyers <[email protected]>
Cc Orion Hodson <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Mathieu Desnoyers <[email protected]>

Thanks!

Mathieu

Quoted 50 lines

---

v1 -> v2: Update arch-support.txt

.../features/sched/membarrier-sync-core/arch-support.txt | 8 ++++----
arch/arm/Kconfig | 1 +

2 files changed, 5 insertions(+), 4 deletions(-)
Documentation/features/sched/membarrier-sync-core/arch-support.txt +4 -4
index dbdf62907703..c7858dd1ea8f 100644
@@ -5,10 +5,10 @@
 #
 # Architecture requirements
 #
-# * arm64
+# * arm/arm64
 #
-# Rely on eret context synchronization when returning from IPI handler, and
-# when returning to user-space.
+# Rely on implicit context synchronization as a result of exception return
+# when returning from IPI handler, and when returning to user-space.
 #
 # * x86
 #

@@ -31,7 +31,7 @@
    -----------------------
    |       alpha: | TODO |
    |         arc: | TODO |
-    |         arm: | TODO |
+    |         arm: |  ok  |
    |       arm64: |  ok  |
    |         c6x: | TODO |
    |       h8300: | TODO |
arch/arm/Kconfig +1 -1
index 54eeb8d00bc6..b0ac18547370 100644
@@ -9,6 +9,7 @@ config ARM
 	select ARCH_HAS_ELF_RANDOMIZE
 	select ARCH_HAS_FORTIFY_SOURCE
 	select ARCH_HAS_KCOV
+	select ARCH_HAS_MEMBARRIER_SYNC_CORE
 	select ARCH_HAS_PTE_SPECIAL if ARM_LPAE
 	select ARCH_HAS_PHYS_TO_DMA
 	select ARCH_HAS_SET_MEMORY
--

2.1.4

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
#2 lore raw

PATCH v2 1/1 arm: Hook up SYNC_CORE functionality for sys_membarrier()

Great, thank you!

Quoted 72 lines · Mathieu Desnoyers
Quoted 7 lines · Will Deacon will.deacon at arm.com

Exception return implies context synchronization, so we can hook up the SYNC_CORE option to sys_membarrier() simply by selecting the Kconfig option, just like we've done for arm64 already.

Cc Mathieu Desnoyers <[email protected]>
Cc Orion Hodson <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Mathieu Desnoyers <[email protected]>

Thanks!

Mathieu

Quoted 49 lines

---

v1 -> v2: Update arch-support.txt

.../features/sched/membarrier-sync-core/arch-support.txt | 8 ++++----
arch/arm/Kconfig | 1 +

2 files changed, 5 insertions(+), 4 deletions(-)
Documentation/features/sched/membarrier-sync-core/arch-support.txt +4 -4
index dbdf62907703..c7858dd1ea8f 100644
@@ -5,10 +5,10 @@
 #
 # Architecture requirements
 #
-# * arm64
+# * arm/arm64
 #
-# Rely on eret context synchronization when returning from IPI handler, and
-# when returning to user-space.
+# Rely on implicit context synchronization as a result of exception return
+# when returning from IPI handler, and when returning to user-space.
 #
 # * x86
 #

@@ -31,7 +31,7 @@
    -----------------------
    |       alpha: | TODO |
    |         arc: | TODO |
-    |         arm: | TODO |
+    |         arm: |  ok  |
    |       arm64: |  ok  |
    |         c6x: | TODO |
    |       h8300: | TODO |
arch/arm/Kconfig +1 -1
index 54eeb8d00bc6..b0ac18547370 100644
@@ -9,6 +9,7 @@ config ARM
      select ARCH_HAS_ELF_RANDOMIZE
      select ARCH_HAS_FORTIFY_SOURCE
      select ARCH_HAS_KCOV
+     select ARCH_HAS_MEMBARRIER_SYNC_CORE
      select ARCH_HAS_PTE_SPECIAL if ARM_LPAE
      select ARCH_HAS_PHYS_TO_DMA
      select ARCH_HAS_SET_MEMORY
--
Quoted 1 line

2.1.4

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

Signature · 1 line
Orion Hodson | Software Engineer | oth at google.com | +44 7505 730469