drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
Subsystems (2)
PATCH 1/1 drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +7 -2
@@ -601,6 +601,11 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,*/ wa_add (wal,FF_MODE2 ,FF_MODE2_TDS_TIMER_MASK ,FF_MODE2_TDS_TIMER_128 ,0 ); + +/* WaDisableGPGPUMidThreadPreemption:tgl */ +WA_SET_FIELD_MASKED (GEN8_CS_CHICKEN1 , +GEN9_PREEMPT_GPGPU_LEVEL_MASK , +GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL ); } static void
@@ -1475,8 +1480,8 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) PSDUNIT_CLKGATE_DIS); } -if (IS_GEN_RANGE (i915,9 ,11 )) { -/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl */ +if (IS_GEN_RANGE (i915,9 ,12 )) { +/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl,tgl */ wa_masked_en (wal,GEN7_FF_SLICE_CS_CHICKEN1 ,GEN9_FFSC_PERCTX_PREEMPT_CTRL );
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).
Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>
Thanks for CC'ing me. I also saw a reply from Jason yesterday, but I don't see it in the list now (though my mail client a mess lately).
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the INTERFACE_DESCRIPTOR_DATA, instead of from the kernel side, so we could try to experiment with it in the future.
Also, do you have an idea of how broken it is? Or is it just not tested because no driver is currently implementing it? And do you know if the windows 3D drivers implement it at all? I see code in the driver that seems to me that it's only disabled in certain cases...
To summarize, I think we should either:
1) Disable mid-thread preemption from the kernel and not whitelist the register (just like you do in this patch); or
2) Not do anything at all from the kernel, and let userspace disable it if needed.
I think 2) is better, if it's not an issue to the other userspace drivers (OpenCL and Media).
--
Rafael
Quoted 34 lines
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +7
-2@@ -601,6 +601,11 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,*/ wa_add (wal,FF_MODE2 ,FF_MODE2_TDS_TIMER_MASK ,FF_MODE2_TDS_TIMER_128 ,0 ); + +/* WaDisableGPGPUMidThreadPreemption:tgl */ +WA_SET_FIELD_MASKED (GEN8_CS_CHICKEN1 , +GEN9_PREEMPT_GPGPU_LEVEL_MASK , +GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL ); } static void@@ -1475,8 +1480,8 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) PSDUNIT_CLKGATE_DIS); } -if (IS_GEN_RANGE (i915,9 ,11 )) { -/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl */ +if (IS_GEN_RANGE (i915,9 ,12 )) { +/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl,tgl */ wa_masked_en (wal,GEN7_FF_SLICE_CS_CHICKEN1 ,GEN9_FFSC_PERCTX_PREEMPT_CTRL );Signature · 1 line
2.20.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Rafael Antognolli
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>
Quoted 2 lines
Thanks for CC'ing me. I also saw a reply from Jason yesterday, but I don't see it in the list now (though my mail client a mess lately).
I saw nothing from Jason, but there was an email from you asking about interface descriptors and whitelisting which is why I copied you.
Quoted 10 lines
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the kernel side, so we could try to experiment with it in the future.Also, do you have an idea of how broken it is? Or is it just not tested because no driver is currently implementing it? And do you know if the windows 3D drivers implement it at all? I see code in the driver that seems to me that it's only disabled in certain cases...
Quoted 8 lines
To summarize, I think we should either:
1) Disable mid-thread preemption from the kernel and not whitelist the register (just like you do in this patch); or
2) Not do anything at all from the kernel, and let userspace disable it if needed.I think 2) is better, if it's not an issue to the other userspace drivers (OpenCL and Media).
I know it is somewhat broken like in https://gitlab.freedesktop.org/drm/intel/issues/1293.
And I know OpenCL and Media would prefer i915 to handle it, but that's always the case. :) OpenCL and Media folks are on the thread so can comment if they are okay with handling this themselves.
Indeed a blanket ban in i915 means no one can try it out later without further kernel changes.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rafael Antognolli
Acked-byQuoted 47 lines · Tvrtko Ursulin
Quoted 17 lines · Rafael Antognolli
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>Quoted 2 lines
Thanks for CC'ing me. I also saw a reply from Jason yesterday, but I don't see it in the list now (though my mail client a mess lately).
I saw nothing from Jason, but there was an email from you asking about interface descriptors and whitelisting which is why I copied you.
Quoted 10 lines
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the kernel side, so we could try to experiment with it in the future.Also, do you have an idea of how broken it is? Or is it just not tested because no driver is currently implementing it? And do you know if the windows 3D drivers implement it at all? I see code in the driver that seems to me that it's only disabled in certain cases...
Quoted 8 lines
To summarize, I think we should either:
1) Disable mid-thread preemption from the kernel and not whitelist the register (just like you do in this patch); or
2) Not do anything at all from the kernel, and let userspace disable it if needed.I think 2) is better, if it's not an issue to the other userspace drivers (OpenCL and Media).
I know it is somewhat broken like in
https://gitlab.freedesktop.org/drm/intel/issues/1293.
Quoted 6 lines
And I know OpenCL and Media would prefer i915 to handle it, but that's always the case. :) OpenCL and Media folks are on the thread so can comment if they are okay with handling this themselves.
Indeed a blanket ban in i915 means no one can try it out later without further kernel changes.
Well, based on your comment from the previous patch:
"General thinking is, since MTP is considered not validated / broken / dangerous, i915 should default it off. But yes, whitelisting or not on top is open."
Maybe we should simply ban it and be done. So this patch is:
Quoted 3 lines
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jason Ekstrand
Acked-byQuoted 58 lines · Rafael Antognolli
Quoted 47 lines · Tvrtko Ursulin
Quoted 17 lines · Rafael Antognolli
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>Quoted 2 lines
Thanks for CC'ing me. I also saw a reply from Jason yesterday, but I don't see it in the list now (though my mail client a mess lately).
I saw nothing from Jason, but there was an email from you asking about interface descriptors and whitelisting which is why I copied you.
Quoted 10 lines
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the kernel side, so we could try to experiment with it in the future.Also, do you have an idea of how broken it is? Or is it just not tested because no driver is currently implementing it? And do you know if the windows 3D drivers implement it at all? I see code in the driver that seems to me that it's only disabled in certain cases...
Quoted 8 lines
To summarize, I think we should either:
1) Disable mid-thread preemption from the kernel and not whitelist the register (just like you do in this patch); or
2) Not do anything at all from the kernel, and let userspace disable it if needed.I think 2) is better, if it's not an issue to the other userspace drivers (OpenCL and Media).
I know it is somewhat broken like in
https://gitlab.freedesktop.org/drm/intel/issues/1293.Quoted 6 lines
And I know OpenCL and Media would prefer i915 to handle it, but that's always the case. :) OpenCL and Media folks are on the thread so can comment if they are okay with handling this themselves.
Indeed a blanket ban in i915 means no one can try it out later without further kernel changes.
Well, based on your comment from the previous patch:
Quoted 7 lines
"General thinking is, since MTP is considered not validated / broken / dangerous, i915 should default it off. But yes, whitelisting or not on top is open."
Maybe we should simply ban it and be done. So this patch is:
Agreed. If we think that it's broken or is likely to take additional kernel work to enable it properly, we shouldn't allow userspace to turn it on until we know the kernel is in good shape. Just ban it outright and we can figure out white-listing later if and when we get it properly working.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Ye, Tony
Acked-byQuoted 57 lines · Rafael Antognolli
Quoted 47 lines · Tvrtko Ursulin
Quoted 17 lines · Rafael Antognolli
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>Quoted 2 lines
Thanks for CC'ing me. I also saw a reply from Jason yesterday, but I don't see it in the list now (though my mail client a mess lately).
I saw nothing from Jason, but there was an email from you asking about interface descriptors and whitelisting which is why I copied you.
Quoted 10 lines
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the kernel side, so we could try to experiment with it in the future.Also, do you have an idea of how broken it is? Or is it just not tested because no driver is currently implementing it? And do you know if the windows 3D drivers implement it at all? I see code in the driver that seems to me that it's only disabled in certain cases...
Quoted 8 lines
To summarize, I think we should either:
1) Disable mid-thread preemption from the kernel and not whitelist the register (just like you do in this patch); or
2) Not do anything at all from the kernel, and let userspace disable it if needed.I think 2) is better, if it's not an issue to the other userspace drivers (OpenCL and Media).
I know it is somewhat broken like in
https://gitlab.freedesktop.org/drm/intel/issues/1293.Quoted 6 lines
And I know OpenCL and Media would prefer i915 to handle it, but that's always the case. :) OpenCL and Media folks are on the thread so can comment if they are okay with handling this themselves.
Indeed a blanket ban in i915 means no one can try it out later without further kernel changes.
Well, based on your comment from the previous patch:
Quoted 7 lines
"General thinking is, since MTP is considered not validated / broken / dangerous, i915 should default it off. But yes, whitelisting or not on top is open."
Maybe we should simply ban it and be done. So this patch is:
Quoted 4 lines
Quoted 4 lines
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line
Quoted 1 line
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the >>kernel side, so we could try to experiment with it in the future.
Interface Descriptor setting only switches the preemption from mid thread to thread group. It doesn't allow to disable it completely and there are cases where this is required (i.e. VME). For that we need mmio whitelist.
Michal
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Michal
Quoted 1 line
Quoted 1 line
But he asked whether it's possible for Media and OpenCL drivers to also disable mid-thread preemption through the
INTERFACE_DESCRIPTOR_DATA, instead of from the >>kernel side, so we could try to experiment with it in the future.Interface Descriptor setting only switches the preemption from mid thread to thread group. It doesn't allow to disable it completely and there are cases where this is required (i.e. VME). For that we need mmio whitelist.
With "disable it completely" you mean disable preemption completely - go lower than thread-group in granularity?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line
Quoted 1 line
With "disable it completely" you mean disable preemption completely - go lower than thread-group in granularity?
Yes, disable it completely.
Michal
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
URL : https://patchwork.freedesktop.org/series/74274/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs'
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
URL : https://patchwork.freedesktop.org/series/74274/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8066 -> Patchwork_16821
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/index.html
Known issues
------------
Here are the changes found in Patchwork_16821 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [PASS][1] -> [FAIL][2] ([CI#94])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-cml-s: [PASS][3] -> [DMESG-FAIL][4] ([i915#877])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hugepages:
- fi-tgl-y: [PASS][5] -> [INCOMPLETE][6] ([CI#94]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@i915_selftest@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([CI#94] / [i915#402]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- fi-icl-guc: [DMESG-FAIL][9] ([i915#922]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-icl-guc/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-icl-guc/igt@i915_selftest@[email protected]
* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [DMESG-WARN][11] ([CI#94] / [i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected]
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
[i915#922]: https://gitlab.freedesktop.org/drm/intel/issues/922
Participating hosts (45 -> 42)
------------------------------
Additional (7): fi-kbl-7560u fi-bwr-2160 fi-kbl-7500u fi-cfl-8109u fi-skl-lmem fi-blb-e6850 fi-kbl-r
Missing (10): fi-kbl-soraka fi-icl-1065g7 fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-bdw-samus fi-byt-clapper fi-skl-6600u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8066 -> Patchwork_16821
CI-20190529: 20190529
CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16821: 770b14fbde2879037069c8ea3aa5d48a1d283fd4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
770b14fbde28 drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
Quoted 88 lines · Patchwork
== Series Details ==
Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
URL : https://patchwork.freedesktop.org/series/74274/
State : success== Summary ==
CI Bug Log - changes from
CI_DRM_8066->Patchwork_16821
====================================================Summary
-------**SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/index.htmlKnown issues
------------Here are the changes found in
Patchwork_16821that come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [PASS][1] -> [FAIL][2] ([CI#94]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected]* igt@i915_selftest@live@gem_contexts:
- fi-cml-s: [PASS][3] -> [DMESG-FAIL][4] ([i915#877]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-cml-s/igt@i915_selftest@live@gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-cml-s/igt@i915_selftest@live@gem_contexts.html* igt@i915_selftest@live@hugepages:
- fi-tgl-y: [PASS][5] -> [INCOMPLETE][6] ([CI#94]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@i915_selftest@[email protected] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@i915_selftest@[email protected]* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([CI#94] / [i915#402]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected]#### Possible fixes ####
* igt@i915_selftest@live@workarounds: - fi-icl-guc: [DMESG-FAIL][9] ([i915#922]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-icl-guc/igt@i915_selftest@[email protected] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-icl-guc/igt@i915_selftest@[email protected] * igt@prime_self_import@basic-llseek-bad: - fi-tgl-y: [DMESG-WARN][11] ([CI#94] / [i915#402]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@[email protected] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/fi-tgl-y/igt@[email protected] [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 [i915#922]: https://gitlab.freedesktop.org/drm/intel/issues/922Participating hosts (45 -> 42)
------------------------------Additional (7): fi-kbl-7560u fi-bwr-2160 fi-kbl-7500u fi-cfl-8109u fi-skl-lmem fi-blb-e6850 fi-kbl-r
Missing (10): fi-kbl-soraka fi-icl-1065g7 fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-bdw-samus fi-byt-clapper fi-skl-6600uBuild changes
-------------* CI: CI-20190529 -> None * Linux: CI_DRM_8066 -> Patchwork_16821 CI-20190529: 20190529 CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16821: 770b14fbde2879037069c8ea3aa5d48a1d283fd4 @ git://anongit.freedesktop.org/gfx-ci/linux
Quoted 3 lines
== Linux commits ==
770b14fbde28drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
And pushed, thanks for the reviews!
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2020-03-04 15:31:44)
Quoted 8 lines
From: Tvrtko Ursulin <[email protected]>
Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- group as the default preemption level.
v2:
* Remove register whitelisting (Rafael, Tony).
Quoted 7 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Michał Winiarski <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Tony Ye <[email protected]>Cc Rafael Antognolli <[email protected]>
/me mutters
So do we need to disable force-preemption on rcs if we can't do fine-grained preemption?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption
URL : https://patchwork.freedesktop.org/series/74274/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16821_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16821_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +10 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb5/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox:
- shard-skl: [PASS][3] -> [FAIL][4] ([i915#679])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl7/igt@gem_ctx_persistence@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl1/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@implicit-write-read-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [i915#677]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb5/igt@[email protected]
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([i915#677]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +17 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb3/igt@[email protected]
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb1/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-apl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#54])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl5/igt@[email protected]
* igt@kms_flip@dpms-off-confusion:
- shard-kbl: [PASS][19] -> [INCOMPLETE][20] ([fdo#103665])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-kbl6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#221])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl10/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl10/igt@[email protected]
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#167])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl5/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#69]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl5/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#899])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-glk1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-glk4/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([IGT#6])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl9/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][35] -> [FAIL][36] ([i915#31])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-apl6/igt@[email protected]
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#31])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl9/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-kbl1/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#146] / [i915#69])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl10/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-tglb: [INCOMPLETE][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-tglb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-tglb7/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][45] ([fdo#110841]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb3/igt@[email protected]
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][47] ([fdo#112080]) -> [PASS][48] +19 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb1/igt@[email protected]
* igt@gem_exec_schedule@implicit-write-read-bsd2:
- shard-iclb: [SKIP][49] ([fdo#109276] / [i915#677]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb6/igt@[email protected]
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][53] ([i915#677]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb3/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-apl6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-skl: [FAIL][57] -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl6/igt@[email protected]
* igt@i915_selftest@mock@buddy:
- shard-skl: [INCOMPLETE][59] ([i915#1310] / [i915#1360]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl2/igt@i915_selftest@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl7/igt@i915_selftest@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-kbl1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][63] ([i915#1188]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][65] ([fdo#108145]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-skl9/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [FAIL][67] ([i915#899]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-glk4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-glk2/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][69] ([fdo#109642] / [fdo#111068]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb8/igt@kms_psr2_su@page_flip.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][73] ([fdo#109276]) -> [PASS][74] +22 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [SKIP][75] ([i915#677]) -> [INCOMPLETE][76] ([i915#1381])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb1/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/shard-iclb5/igt@[email protected]
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1310]: https://gitlab.freedesktop.org/drm/intel/issues/1310
[i915#1360]: https://gitlab.freedesktop.org/drm/intel/issues/1360
[i915#1381]: https://gitlab.freedesktop.org/drm/intel/issues/1381
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#167]: https://gitlab.freedesktop.org/drm/intel/issues/167
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8066 -> Patchwork_16821
CI-20190529: 20190529
CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16821: 770b14fbde2879037069c8ea3aa5d48a1d283fd4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16821/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx