Skip to contentSkip to conversation

dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7

PATCH In review Lucas Tanure 3 participants 5 messages Aug 14, 2023 – Aug 26, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v9 1/2 dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7

Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. There is no need for an extra compatible line in the driver, but add T7 compatible line for documentation.

---
Since v8:
- Fix issues with git send-mail command line
Since v7:
- Send to the correct maintainers

 .../devicetree/bindings/serial/amlogic,meson-uart.yaml        | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +4 -0
index f1ae8c4934d9..2e189e548327 100644
@@ -52,6 +52,10 @@ properties:
         items:
           - const: amlogic,meson-g12a-uart
           - const: amlogic,meson-gx-uart
+      - description: UART controller on S4 compatible SoCs
+        items:
+          - const: amlogic,t7-uart
+          - const: amlogic,meson-s4-uart
 
   reg:
     maxItems: 1
Signature · 7 lines
2.41.0


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#1 lore raw

PATCH v9 2/2 tty: serial: meson: Add a earlycon for the T7 SoC

The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
Since v8:
- Fix issues with git send-mail command line
Since v7:
- Send to the correct maintainers

 drivers/tty/serial/meson_uart.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/tty/serial/meson_uart.c +2 -0
index 790d910dafa5..c4f61d82fb72 100644
@@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
 
 OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
 		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
+		    meson_serial_early_console_setup);
 
 #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
 #else
Signature · 7 lines
2.41.0


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#2 lore raw

Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC

Hello Lucas,

Thank you for the patch! Please find my small comment below.

Quoted 19 lines · Lucas Tanure

The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
Since v8:
- Fix issues with git send-mail command line
Since v7:
- Send to the correct maintainers

 drivers/tty/serial/meson_uart.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..c4f61d82fb72 100644

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 655

Quoted 8 lines
drivers/tty/serial/meson_uart.c +2 -0
@@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
 
 OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
 		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
+		    meson_serial_early_console_setup);
 
 #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
 #else

I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2].

Links:

    [1] https://lore.kernel.org/all/[email protected]/
    [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03
Signature · 7 lines
Thank you,
Dmitry

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#3 lore raw

Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC

Quoted 38 lines · Dmitry Rokosov

Hello Lucas,

Thank you for the patch! Please find my small comment below.

Quoted 19 lines · Lucas Tanure

The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
Since v8:
- Fix issues with git send-mail command line
Since v7:
- Send to the correct maintainers

  drivers/tty/serial/meson_uart.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..c4f61d82fb72 100644

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 655

Quoted 8 lines
drivers/tty/serial/meson_uart.c +2 -0
@@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
 
  OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
  		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
+		    meson_serial_early_console_setup);
 
  #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
  #else

I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2].

Quoted 4 lines

Links:

     [1] https://lore.kernel.org/all/[email protected]/
     [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03

I asked Greg to drop this patch as is not need anymore. T7 will use S4 TTY/UART code.

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#4 lore raw

Re: [PATCH v9 2/2] tty: serial: meson: Add a earlycon for the T7 SoC

Quoted 37 lines · Lucas Tanure
Quoted 36 lines · Dmitry Rokosov

Hello Lucas,

Thank you for the patch! Please find my small comment below.

Quoted 19 lines · Lucas Tanure

The new Amlogic T7 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
Since v8:
- Fix issues with git send-mail command line
Since v7:
- Send to the correct maintainers

  drivers/tty/serial/meson_uart.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..c4f61d82fb72 100644

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 653

Quoted 6 lines
drivers/tty/serial/meson_uart.c +2 -0
@@ -648,6 +648,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
  OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
  		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
+		    meson_serial_early_console_setup);
  #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
  #else

I suppose you need to add a separate meson_t7_uart_data to switch the T7 UART to a regular TTY devname 'ttyS'. For the new Amlogic SoCs, we have agreed to use 'ttyS' instead of 'ttyAML'. Please refer to the already applied patch series at [1] and the IRC discussion at [2].

Quoted 6 lines
Quoted 4 lines

Links:

     [1] https://lore.kernel.org/all/[email protected]/
     [2] https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03

I asked Greg to drop this patch as is not need anymore. T7 will use S4 TTY/UART code.

I can't drop it, I need a revert :(

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel