Skip to contentSkip to conversation

ASoC: cs35l35: fix typo 'overide' -> 'override'

PATCH In review IRRatium 2 participants 3 messages Apr 21

Subsystems (4)
lore
Share & tools
lore

IRRatium

author
#0 lore raw

PATCH v2 1/2 ASoC: cs35l35: fix typo 'overide' -> 'override'

Fix typo in property name 'cirrus,classh-bst-overide'. Add support for the corrected 'cirrus,classh-bst-override' while keeping backward compatibility with the old name.

---
 sound/soc/codecs/cs35l35.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/codecs/cs35l35.c +0 -0
index 7a01b1d9f..XXXXXXX 100644
@@ -1311,7 +1311,8 @@ static int cs35l35_handle_of_data(struct i2c_client *i2c_client,
 

     if (classh_config->classh_algo_enable) { classh_config->classh_bst_override =
-            of_property_read_bool(np, "cirrus,classh-bst-overide"); +            of_property_read_bool(np, "cirrus,classh-bst-override") || +            of_property_read_bool(np, "cirrus,classh-bst-overide");

         ret = of_property_read_u32(classh,
                 "cirrus,classh-bst-max-limit",

Signature · 1 line
2.53.0
author
#1 lore raw

PATCH v2 2/2 dt-bindings: sound: cs35l35: fix typo 'overide' -> 'override'

Fix typo in property name, should be 'cirrus,classh-bst-override'. The driver now accepts both spellings for backward compatibility.

---
 Documentation/devicetree/bindings/sound/cs35l35.txt | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/cs35l35.txt +0 -0
index e84f30c5c..1d364b3d3 100644
@@ -82,7 +82,7 @@ Optional H/G Algorithm sub-node:

 Optional properties for the "cirrus,classh-internal-algo" Sub-node

   Section 7.29 Class H Control
-  - cirrus,classh-bst-overide : Boolean
+  - cirrus,classh-bst-override : Boolean
   - cirrus,classh-bst-max-limit
   - cirrus,classh-mem-depth

@@ -155,7 +155,7 @@ cs35l35: cs35l35@20 {
     cirrus,shared-boost;

     cirrus,classh-internal-algo {
-        cirrus,classh-bst-overide;
+        cirrus,classh-bst-override;
         cirrus,classh-bst-max-limit = <0x01>;
         cirrus,classh-mem-depth = <0x01>;
         cirrus,classh-release-rate = <0x08>;

Signature · 1 line
2.53.0
#2 lore raw
In reply to IRRatium
Quoted 9 lines · IRRatium

Fix typo in property name 'cirrus,classh-bst-overide'. Add support for the corrected 'cirrus,classh-bst-override' while keeping backward compatibility with the old name.

---
  sound/soc/codecs/cs35l35.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Please provide changelog in the future, describing what changed.

From does not match SoB.

This solves the ABI breakage but I see little value in this change. The typo is part of ABI and it does not really matter if the ABI has such typo or not. Maintaining two ABIs matters more.

Best regards,
Krzysztof