Skip to contentSkip to conversation

usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

PATCH New Neil Armstrong 2 participants 4 messages Sep 9, 2019 – Sep 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

This quirk is necessary for the Amlogic GXL SoCs otherwise the Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:

XHCI timeout on event type 33... cannot recover.

BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!

BUG!

This quirk is also handled in the dwc3 core code, but until the xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here to fix USB support on the Amlogic libretech-cc and libretech-ac board when a device is only plugged in the OTG port.

Cc Yuri Frolov <[email protected]>
Cc Bin Meng <[email protected]>
Fixes dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
---
 drivers/usb/host/xhci-dwc3.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/xhci-dwc3.c +3 -0
index 9e8cae7ae4..55a1b22cf6 100644
@@ -150,6 +150,9 @@ static int xhci_dwc3_probe(struct udevice *dev)
 	if (dev_read_bool(dev, "snps,dis-u2-freeclk-exists-quirk"))
 		reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS;
 
+	if (dev_read_bool(dev, "snps,dis_u2_susphy_quirk"))
+		reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
+
 	writel(reg, &dwc3_reg->g_usb2phycfg[0]);
 
 	dr_mode = usb_get_dr_mode(dev_of_offset(dev));
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

Quoted 13 lines · Neil Armstrong

This quirk is necessary for the Amlogic GXL SoCs otherwise the Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:

XHCI timeout on event type 33... cannot recover.

BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!

BUG!

This quirk is also handled in the dwc3 core code, but until the xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here to fix USB support on the Amlogic libretech-cc and libretech-ac board when a device is only plugged in the OTG port.

Quoted 8 lines
Cc Yuri Frolov <[email protected]>
Cc Bin Meng <[email protected]>
Fixes dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
---
 drivers/usb/host/xhci-dwc3.c | 3 +++
 1 file changed, 3 insertions(+)

Thanks for your efforts tracing this down!

#2 lore raw

PATCH 1/1 usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

Hi Bin, Marek,

Quoted 23 lines · Bin Meng
Quoted 13 lines · Neil Armstrong

This quirk is necessary for the Amlogic GXL SoCs otherwise the Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:

XHCI timeout on event type 33... cannot recover.

BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!

BUG!

This quirk is also handled in the dwc3 core code, but until the xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here to fix USB support on the Amlogic libretech-cc and libretech-ac board when a device is only plugged in the OTG port.

Quoted 8 lines
Cc Yuri Frolov <[email protected]>
Cc Bin Meng <[email protected]>
Fixes dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
---
 drivers/usb/host/xhci-dwc3.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 4 lines

Thanks for your efforts tracing this down!

Should I take it into my amlogic tree or you'll handle it ?

Thanks,
Neil

#3 lore raw

PATCH 1/1 usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

Hi Neil,

Quoted 27 lines · Neil Armstrong

Hi Bin, Marek,

Quoted 23 lines · Bin Meng
Quoted 21 lines · Neil Armstrong

This quirk is necessary for the Amlogic GXL SoCs otherwise the Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:

XHCI timeout on event type 33... cannot recover.

BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!

BUG!

This quirk is also handled in the dwc3 core code, but until the xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here to fix USB support on the Amlogic libretech-cc and libretech-ac board when a device is only plugged in the OTG port.

Cc Yuri Frolov <[email protected]>
Cc Bin Meng <[email protected]>
Fixes dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
---
 drivers/usb/host/xhci-dwc3.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 7 lines
Quoted 4 lines

Thanks for your efforts tracing this down!

Should I take it into my amlogic tree or you'll handle it ?

I think you can take it via your tree. Thanks!

Regards,
Bin