ima: Check for ERR_PTR from dentry_path() in validate_hash_algo()
Subsystems (5)
PATCH 1/1 ima: Check for ERR_PTR from dentry_path() in validate_hash_algo()
dentry_path() returns ERR_PTR(-ENAMETOOLONG) when the path exceeds the buffer. validate_hash_algo() passes the result straight to integrity_audit_msg() without checking. ERR_PTR is not NULL, so integrity_audit_message() sees a valid pointer and calls strlen() on it, which faults:
BUG: unable to handle page fault for address: ffffffffffffffdc
RIP: 0010:strlen+0x30/0xa0
Call Trace:
audit_log_untrustedstring+0x19/0x30
integrity_audit_message+0x366/0x4f0
ima_inode_setxattr+0x512/0x5f0Check for IS_ERR() and use NULL instead, which makes the audit message skip the name= field instead of crashing.
--- security/integrity/ima/ima_appraise.c | 2 ++ 1 file changed, 2 insertions(+)
security/integrity/ima/ima_appraise.c +2 -0
@@ -748,6 +748,8 @@ static int validate_hash_algo(struct dentry *dentry,return -EACCES ; path =dentry_path (dentry, pathbuf,PATH_MAX ); +if (IS_ERR (path)) + path =NULL ;integrity_audit_msg (AUDIT_INTEGRITY_DATA ,d_inode (dentry), path,"set_data" , errmsg, -EACCES ,0 );
Signature · 1 line
2.47.3
Mimi Zohar
maintainerQuoted 13 lines · Bradley Morgan
dentry_path()returnsERR_PTR(-ENAMETOOLONG)when the path exceeds the buffer.validate_hash_algo()passes the result straight tointegrity_audit_msg()without checking.ERR_PTRis not NULL, sointegrity_audit_message()sees a valid pointer and callsstrlen()on it, which faults:BUG: unable to handle page fault for address: ffffffffffffffdc RIP: 0010:strlen+0x30/0xa0 Call Trace: audit_log_untrustedstring+0x19/0x30 integrity_audit_message+0x366/0x4f0 ima_inode_setxattr+0x512/0x5f0
Quoted 8 lines
Check for
IS_ERR()and use NULL instead, which makes the audit message skip the name= field instead of crashing.Fixes 4f2946aa0c45 ("IMA: introduce a new policy option func=SETXATTR_CHECK")Reported-by [email protected]Signed-off-by Bradley Morgan <[email protected]>
Thanks, Bradley. The patch is now queued in next-integrity.
Mimi
Quoted 18 lines · Mimi Zohar
Quoted 13 lines · Bradley Morgan
dentry_path()returnsERR_PTR(-ENAMETOOLONG)when the path exceeds the buffer.validate_hash_algo()passes the result straight tointegrity_audit_msg()without checking.ERR_PTRis not NULL, sointegrity_audit_message()sees a valid pointer and callsstrlen()on it, which faults:BUG: unable to handle page fault for address: ffffffffffffffdc RIP: 0010:strlen+0x30/0xa0 Call Trace: audit_log_untrustedstring+0x19/0x30 integrity_audit_message+0x366/0x4f0 ima_inode_setxattr+0x512/0x5f0Quoted 4 lines
Check for
IS_ERR()and use NULL instead, which makes the audit message skip the name= field instead of crashing.Fixes 4f2946aa0c45 ("IMA: introduce a new policy option
Quoted 8 lines
func=SETXATTR_CHECK")
Quoted 3 lines
Reported-by [email protected]Link:
https://lore.kernel.org/all/[email protected]/
Quoted 1 line
Signed-off-by Bradley Morgan <[email protected]>Thanks, Bradley. The patch is now queued in next-integrity.
Cheers, +CC Paul, the syzbot issue should now be fixed
Quoted 2 lines
Mimi