Skip to contentSkip to conversation

bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()

PATCH In review Youling Tang 2 participants 3 messages Apr 30, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Correct the FS_IOC_GETFLAGS to FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()

From: Youling Tang <[email protected]>

It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in compat ioctl.

---
 fs/bcachefs/fs-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fs-ioctl.c +1 -1
index 3dc8630ff9fe..205a323ffc6d 100644
@@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
 {
 	/* These are just misnamed, they actually get/put from/to user an int */
 	switch (cmd) {
-	case FS_IOC_GETFLAGS:
+	case FS_IOC32_GETFLAGS:
 		cmd = FS_IOC_GETFLAGS;
 		break;
 	case FS_IOC32_SETFLAGS:
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Youling Tang

From: Youling Tang <[email protected]>

It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in compat ioctl.

Do we by chance have a test for this?

Quoted 22 lines
---
 fs/bcachefs/fs-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fs-ioctl.c +1 -1
index 3dc8630ff9fe..205a323ffc6d 100644
@@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
 {
 	/* These are just misnamed, they actually get/put from/to user an int */
 	switch (cmd) {
-	case FS_IOC_GETFLAGS:
+	case FS_IOC32_GETFLAGS:
 		cmd = FS_IOC_GETFLAGS;
 		break;
 	case FS_IOC32_SETFLAGS:
Signature · 1 line
2.34.1
#2 lore raw
Quoted 6 lines · Kent Overstreet
Quoted 4 lines · Youling Tang

From: Youling Tang <[email protected]>

It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in compat ioctl.

Do we by chance have a test for this?

Just reading the code found this out.

Quoted 22 lines
Quoted 22 lines
---
  fs/bcachefs/fs-ioctl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/bcachefs/fs-ioctl.c +1 -1
index 3dc8630ff9fe..205a323ffc6d 100644
@@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
  {
  	/* These are just misnamed, they actually get/put from/to user an int */
  	switch (cmd) {
-	case FS_IOC_GETFLAGS:
+	case FS_IOC32_GETFLAGS:
  		cmd = FS_IOC_GETFLAGS;
  		break;
  	case FS_IOC32_SETFLAGS:
Signature · 1 line
2.34.1