drm/meson: add size and alignment requirements for dumb buffers
PATCH 1/1 drm/meson: add size and alignment requirements for dumb buffers
The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes and overall size should be aligned on PAGE width.
Adds a custom dumb_create op to adds these requirements.
--- drivers/gpu/drm/meson/meson_drv.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/gpu/drm/meson/meson_drv.c +13 -1
@@ -90,6 +90,18 @@ static irqreturn_t meson_irq(int irq, void *arg)return IRQ_HANDLED ; } +static int meson_dumb_create (struct drm_file *file,struct drm_device *dev, +struct drm_mode_create_dumb *args) +{ +/* +* We need 64bytes aligned stride, and PAGE aligned size +*/ + args->pitch =ALIGN (DIV_ROUND_UP (args->width * args->bpp,8 ),SZ_64 ); + args->size =PAGE_ALIGN (args->pitch * args->height); + +return drm_gem_cma_dumb_create_internal (file, dev, args); +} +DEFINE_DRM_GEM_CMA_FOPS (fops);static struct drm_driver meson_driver = {
@@ -112,7 +124,7 @@ static struct drm_driver meson_driver = { .gem_prime_mmap = drm_gem_cma_prime_mmap,/* GEM Ops */ - .dumb_create = drm_gem_cma_dumb_create, + .dumb_create = meson_dumb_create, .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops,
Signature · 1 line
2.21.0
Quoted 37 lines · Neil Armstrong
The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes and overall size should be aligned on PAGE width.
Adds a custom
dumb_createop to adds these requirements.Fixes bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")Suggested-by Sky Zhou <[email protected]>Signed-off-by Neil Armstrong <[email protected]>--- drivers/gpu/drm/meson/meson_drv.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)drivers/gpu/drm/meson/meson_drv.c +12
-0@@ -90,6 +90,18 @@ static irqreturn_t meson_irq(int irq, void *arg)return IRQ_HANDLED ; } +static int meson_dumb_create (struct drm_file *file,struct drm_device *dev, +struct drm_mode_create_dumb *args) +{ +/* +* We need 64bytes aligned stride, and PAGE aligned size +*/ + args->pitch =ALIGN (DIV_ROUND_UP (args->width * args->bpp,8 ),SZ_64 ); + args->size =PAGE_ALIGN (args->pitch * args->height); + +return drm_gem_cma_dumb_create_internal (file, dev, args); +} +DEFINE_DRM_GEM_CMA_FOPS (fops);static struct drm_driver meson_driver = {
drivers/gpu/drm/meson/meson_drv.c static struct drm_driver meson_driver = { · line 130
Quoted 8 lines
drivers/gpu/drm/meson/meson_drv.c +1
-1@@ -112,7 +124,7 @@ static struct drm_driver meson_driver = { .gem_prime_mmap = drm_gem_cma_prime_mmap,/* GEM Ops */ - .dumb_create = drm_gem_cma_dumb_create, + .dumb_create = meson_dumb_create, .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops,
Neil Armstrong
AppliedQuoted 40 lines · Sky Zhou
Quoted 38 lines · Neil Armstrong
The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes and overall size should be aligned on PAGE width.
Adds a custom
dumb_createop to adds these requirements.Fixes bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")Suggested-by Sky Zhou <[email protected]>Signed-off-by Neil Armstrong <[email protected]>--- drivers/gpu/drm/meson/meson_drv.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)drivers/gpu/drm/meson/meson_drv.c +12
-0@@ -90,6 +90,18 @@ static irqreturn_t meson_irq(int irq, void *arg)return IRQ_HANDLED ; } +static int meson_dumb_create (struct drm_file *file,struct drm_device *dev, +struct drm_mode_create_dumb *args) +{ +/* +* We need 64bytes aligned stride, and PAGE aligned size +*/ + args->pitch =ALIGN (DIV_ROUND_UP (args->width * args->bpp,8 ),SZ_64 ); + args->size =PAGE_ALIGN (args->pitch * args->height); + +return drm_gem_cma_dumb_create_internal (file, dev, args); +} +DEFINE_DRM_GEM_CMA_FOPS (fops);static struct drm_driver meson_driver = {@@ -112,7 +124,7 @@ static struct drm_driver meson_driver = { .gem_prime_mmap = drm_gem_cma_prime_mmap,
Quoted 10 lines
drivers/gpu/drm/meson/meson_drv.c static struct drm_driver meson_driver = { · line 130
Quoted 7 lines
drivers/gpu/drm/meson/meson_drv.c +1
-1/* GEM Ops */ - .dumb_create = drm_gem_cma_dumb_create, + .dumb_create = meson_dumb_create, .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops,Reviewed-by Sky Zhou <[email protected]>
Applied to drm-misc-next, thanks !