Skip to contentSkip to conversation

pwc: add support for webcam snapshot button

PATCH In review Nam Phạm Thành 2 participants 2 messages Jan 8, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwc: add support for webcam snapshot button

Hi all,
I read somewhere that official support for pwc driver has been stopped :( This patch adds support for Philips webcam snapshot button as an event input device, for consistency with other webcam drivers (uvc, quickcam messenger, konicawc...)
Tested with input-utils (http://dl.bytesex.org/cvs-snapshots/) for Logitech QuickCam Notebook Pro (046d:08b1) et Logitech QuickCam Pro 4000 (046d:08b2). This patch doesn't touch other features, so it is very likely that it won't break anything.
Return to my previous question "How to use webcam snapshot button?". Noone answered. I think that support for it has already existed in driver, but at the present, there isn't any application which exploited this feature yet.

Signature · 1 line
Phạm Thành Nam

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#1 lore raw

Hi Nam,

Quoted 4 lines · On Thu, 8 Jan 2009 11:07:20 +0700 "Nam Phạm Thành"…

Hi all,
I read somewhere that official support for pwc driver has been stopped :( This patch adds support for Philips webcam snapshot button as an event input device, for consistency with other webcam drivers (uvc, quickcam messenger,

Quoted 8 lines

konicawc...)
Tested with input-utils (http://dl.bytesex.org/cvs-snapshots/) for Logitech QuickCam Notebook Pro (046d:08b1) et Logitech QuickCam Pro 4000 (046d:08b2). This patch doesn't touch other features, so it is very likely that it won't break anything.
Return to my previous question "How to use webcam snapshot button?". Noone answered. I think that support for it has already existed in driver, but at the present, there isn't any application which exploited this feature yet.

Please, take a look at http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches
before submitting a patch.

Basically, you should never submit a patch on zip format, since scripts don't work. Also, always c/c linux-media ML for development issues and patches.

The format of the email also need to follow the stated rules on README.patches, to be properly handled by patchwork.kernel.org (the tool we use to get the patches and apply).

Also, please review the format of the patch before submitting (with make checkpatch), to be sure that it is following the Coding Style used on Linux.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list