Skip to contentSkip to conversation

multipath.conf(5): remove deprecated note for san_path_err algorithm

PATCH In review [email protected] 4 participants 15 messages Dec 1, 2022 – Dec 5, 2022 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 multipath.conf(5): remove deprecated note for san_path_err algorithm

From: Martin Wilck <[email protected]>

The paragraph stating that the san_path_err algorithm is deprecated has been moved into the FPIN section by mistake.

Move it upward, and use a weaker wording. While the san_path_err algorithm is technical inferior to the marginal_path approach, it is also easier to understand and set up. Furthermore, we documented that it's the replacement for the delay_check algorithm. Therefore the strong "deprecated" wording is exaggerated.

Fixes cfff03e ("multipathd: handle fpin events")
Cc Xose Vazquez Perez <[email protected]>
Cc Muneendra Kumar <[email protected]>
---
 multipath/multipath.conf.5 | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
multipath/multipath.conf.5 +7 -6
index bd7d778..41a0112 100644
@@ -1877,18 +1877,19 @@ increase and the threshold is never reached. Ticks are the time between
 path checks by multipathd, which is variable and controlled by the
 \fIpolling_interval\fR and \fImax_polling_interval\fR parameters.
 .
+.RS 8
+.LP
+This algorithm is superseded by the \(dqmarginal_path\(dq failure tracking,
+but remains supported for backward compatibility.
+.
+.RE
 .TP
-.B \(dqFPIN \(dq failure tracking
+.B \(dqFPIN\(dq failure tracking
 Fibre channel fabrics can notify hosts about fabric-level issues such
 as integrity failures or congestion with so-called Fabric Performance
 Impact Notifications (FPINs).On receiving the fpin notifications through ELS
 multipathd will move the affected path and port states to marginal.
 .
-.RS 8
-.LP
-This method is \fBdeprecated\fR in favor of the \(dqmarginal_path\(dq failure
-tracking method, and only offered for backward compatibility.
-.
 .RE
 .LP
 See the documentation
Signature · 6 lines
2.38.1

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
#1 lore raw

PATCH 2/2 multipath.conf(5): improve documentation of dev_loss_tmo

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this parameter on other parameters.

Cc Xose Vazquez Perez <[email protected]>
---
 multipath/multipath.conf.5 | 37 +++++++++++++++++++++++++------------
 1 file changed, 25 insertions(+), 12 deletions(-)
multipath/multipath.conf.5 +25 -12
index 41a0112..fc7434c 100644
@@ -707,21 +707,34 @@ The default is: \fB5\fR
 .
 .TP
 .B dev_loss_tmo
-Specify the number of seconds the SCSI layer will wait after a problem has
-been detected on a FC remote port before removing it from the system. This
-can be set to "infinity" which sets it to the max value of 2147483647
-seconds, or 68 years. It will be automatically adjusted to the overall
-retry interval \fIno_path_retry\fR * \fIpolling_interval\fR
-if a number of retries is given with \fIno_path_retry\fR and the
-overall retry interval is longer than the specified \fIdev_loss_tmo\fR value.
-The Linux kernel will cap this value to \fI600\fR if \fIfast_io_fail_tmo\fR
-is not set. See KNOWN ISSUES.
+Specify the number of seconds the SCSI layer will wait after a connection loss has
+been detected on a remote port before removing it from the system. This
+can be set to "infinity", which effectively means 136 years (2^32-1 seconds).
+This parameter is only applied to Fibre Channel and SAS devices.
 .RS
-.TP
-The default is: \fB600\fR
+.LP
+The value of \fIdev_loss_tmo\fR is restricted by other settings.
+If \fIfast_io_fail_tmo\fR is set to a positive value,
+.B multipathd
+will make sure that the value of \fIdev_loss_tmo\fR is larger than
+\fIno_path_retry\fR * \fIpolling_interval\fR.
+If \fIfast_io_fail_tmo\fR is not set, the kernel limits the \fIdev_loss_tmo\fR
+value to 600 seconds.
+In this case, the user has to make sure that \fIno_path_retry\fR is smaller
+than \fIdev_loss_tmo / polling_interval\fR. In particular,
+\fIno_path_retry\fR must not be set to \(dq\fIqueue\fR\(dq. See KNOWN ISSUES.
+.LP
+When path devices reappear after a connection loss, it is much easier for
+the kernel to simply reactivate an inactive device than to re-add
+a previously deleted one. It is therefore recommended to set
+\fIdev_loss_tmo\fR to a large value within the restrictions mentioned above.
+.LP
+The default is: \fBhardware dependent\fR. Fibre Channel and SAS devices have
+hardware-dependent defaults, which are left unchanged if \fIdev_loss_tmo\fR is
+not specified. For a few storage arrays, the multipath-tools built-in settings
+override the default. Run \fImultipath -T\fR to see the settings for your device.
 .RE
 .
-.
 .TP
 .B eh_deadline
 Specify the maximum number of seconds the SCSI layer will spend doing error
Signature · 6 lines
2.38.1

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
#2 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 5 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this parameter on other parameters.

I did change this patch to move "default value" to bottom.

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#3 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 9 lines · Xose Vazquez Perez
Quoted 5 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this parameter on other parameters.

I did change this patch to move "default value" to bottom.

The problem is that there is no easily explained default value for this parameter. Nice as the common "default value" format is, it doesn't apply here.

If you have a suggestion for improving the formatting or wording, please speak up.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#4 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 11 lines · Martin Wilck
Quoted 9 lines · Xose Vazquez Perez
Quoted 5 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this parameter on other parameters.

I did change this patch to move "default value" to bottom.

Quoted 7 lines

The problem is that there is no easily explained default value for this
parameter. Nice as the common "default value" format is, it doesn't apply here.

If you have a suggestion for improving the formatting or wording, please speak up.

Sorry, I missed your other email because it had been sorted into a different folder.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#5 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Reading through it, on the line below, shouldn't it be -t (not -T)?

Line:
+the multipath-tools built-in settings override the default. Run \fImultipath -T\fR

Quoted 23 lines · Martin Wilck
Quoted 11 lines · Martin Wilck
Quoted 9 lines · Xose Vazquez Perez
Quoted 5 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this parameter on other parameters.

I did change this patch to move "default value" to bottom.

Quoted 7 lines

The problem is that there is no easily explained default value for this
parameter. Nice as the common "default value" format is, it doesn't apply here.

If you have a suggestion for improving the formatting or wording, please speak up.

Sorry, I missed your other email because it had been sorted into a different folder.

Quoted 8 lines

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#6 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 2 lines · Roger Heflin

Reading through it, on the line below, shouldn't it be -t (not -T)?

No, -T is correct. -t prints the entire internal table, most of which doesn't apply on any given system. -T prints only the settings for hardware that's present in the given system, which is what most users will prefer (I assume).

But thanks for reading carefully. Appreciated!

Martin

Quoted 4 lines

Line:
+the multipath-tools built-in settings override the default. Run \fImultipath -T\fR

Quoted 34 lines
Quoted 33 lines · Martin Wilck
Quoted 19 lines · Martin Wilck
Quoted 10 lines · Xose Vazquez Perez
Quoted 6 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this
parameter on other parameters.

I did change this patch to move "default value" to bottom.

The problem is that there is no easily explained default value for
this
parameter. Nice as the common "default value" format is, it doesn't
apply here.

Quoted 2 lines

If you have a suggestion for improving the formatting or wording, please speak up.

Sorry, I missed your other email because it had been sorted into a different folder.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#7 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Thanks.

The older distribution I checked has this for -T
-T tm:valid
check if tm matches the multipathd configuration timestamp
value from /run/multipathd/timestamp If so, return success if valid is 1. Otherwise, return failure. If the timestamp doesn't match continue with multipath execution. This option is designed to be used with -c by the udev rules.

So really weird option.

Quoted 4 lines · Martin Wilck
Quoted 2 lines · Roger Heflin

Reading through it, on the line below, shouldn't it be -t (not -T)?

Quoted 51 lines

No, -T is correct. -t prints the entire internal table, most of which doesn't apply on any given system. -T prints only the settings for hardware that's present in the given system, which is what most users will prefer (I assume).

But thanks for reading carefully. Appreciated!

Martin

Quoted 38 lines

Line:
+the multipath-tools built-in settings override the default. Run \fImultipath -T\fR

Quoted 33 lines · Martin Wilck
Quoted 19 lines · Martin Wilck
Quoted 10 lines · Xose Vazquez Perez
Quoted 6 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this
parameter on other parameters.

I did change this patch to move "default value" to bottom.

The problem is that there is no easily explained default value for
this
parameter. Nice as the common "default value" format is, it doesn't
apply here.

Quoted 2 lines

If you have a suggestion for improving the formatting or wording, please speak up.

Sorry, I missed your other email because it had been sorted into a different folder.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#8 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 9 lines · Roger Heflin

Thanks.

The older distribution I checked has this for -T
     -T tm:valid
              check if tm matches the multipathd configuration timestamp value from /run/multipathd/timestamp If so, return success if valid is 1. Otherwise, return failure. If the timestamp doesn't match continue with multipath execution.  This option is designed to be used with -c by the udev rules.

Strange, I can't find this anywhere in the sources I know. What distro is this? "multipath -T" in the sense I described has existed since 0.7.7, so for more than 4 years.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#9 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 11 lines · Martin Wilck
Quoted 9 lines · Roger Heflin

Thanks.

The older distribution I checked has this for -T
     -T tm:valid
              check if tm matches the multipathd configuration
timestamp value from /run/multipathd/timestamp If so, return success if valid is 1. Otherwise, return failure. If the timestamp doesn't match continue with multipath execution.  This option is designed to be used with -c by the udev rules.

Quoted 3 lines

Strange, I can't find this anywhere in the sources I know. What distro is this? "multipath -T" in the sense I described has existed since 0.7.7, so for more than 4 years.

RH: https://src.fedoraproject.org/rpms/device-mapper-multipath/blob/6738b34a0b0aabf1bc8c15d540bafa29ca99c58f/f/0158-RHBZ-1318581-timestamp-doc-fix.patch

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#10 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

In reply to Martin Wilck

One of the Enterprise 7 variants, Claims "0.4.9" multipath but appears to have a number of recent features backported, so some frankensteined version.

Quoted 11 lines · Martin Wilck
Quoted 9 lines · Roger Heflin

Thanks.

The older distribution I checked has this for -T
-T tm:valid
check if tm matches the multipathd configuration
timestamp value from /run/multipathd/timestamp If so, return success if valid is 1. Otherwise, return failure. If the timestamp doesn't match continue with multipath execution. This option is designed to be used with -c by the udev rules.

Quoted 7 lines

Strange, I can't find this anywhere in the sources I know. What distro is this? "multipath -T" in the sense I described has existed since 0.7.7, so for more than 4 years.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#11 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 4 lines · Roger Heflin

One of the Enterprise 7 variants, Claims "0.4.9" multipath but appears to have a number of recent features backported, so some frankensteined version.

Quoted 21 lines
Quoted 20 lines · Martin Wilck
Quoted 12 lines · Roger Heflin

Thanks.

The older distribution I checked has this for -T
     -T tm:valid
              check if tm matches the multipathd configuration timestamp value from /run/multipathd/timestamp If so, return success
if valid is 1. Otherwise, return failure. If the timestamp doesn't
match continue with multipath execution.  This option is designed to
be used with -c by the udev rules.

Strange, I can't find this anywhere in the sources I know. What distro is this? "multipath -T" in the sense I described has existed since 0.7.7, so for more than 4 years.

Martin

Funny, Ben never told me there was a conflicting option name in RHEL. I guess it's too late now, as I said, the upstream option has existed for 4 years.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#12 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

Quoted 3 lines · Martin Wilck

Funny, Ben never told me there was a conflicting option name in RHEL. I guess it's too late now, as I said, the upstream option has existed for 4 years.

Because it was remove in RHEL-8, since multipath-tools were updated to 0.8.4 RHEL-7 uses a very old code base(0.4.9) with a lot of patches(273)

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#13 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

In reply to Martin Wilck
Quoted 24 lines · Martin Wilck
Quoted 23 lines · Roger Heflin

One of the Enterprise 7 variants, Claims "0.4.9" multipath but appears to have a number of recent features backported, so some frankensteined version.

Quoted 18 lines · Martin Wilck
Quoted 12 lines · Roger Heflin

Thanks.

The older distribution I checked has this for -T
     -T tm:valid
              check if tm matches the multipathd configuration timestamp value from /run/multipathd/timestamp If so, return success
if valid is 1. Otherwise, return failure. If the timestamp doesn't
match continue with multipath execution.  This option is designed to
be used with -c by the udev rules.

Strange, I can't find this anywhere in the sources I know. What distro is this? "multipath -T" in the sense I described has existed since 0.7.7, so for more than 4 years.

Quoted 6 lines
Quoted 2 lines
Quoted 2 lines

Martin

Funny, Ben never told me there was a conflicting option name in RHEL. I guess it's too late now, as I said, the upstream option has existed for 4 years.

This was a fix for a RHEL specific systemd issue, that's long since been resolved in more up to date versions of RHEL. RHEL-8 and RHEL-9 have the same code as upstream for the -T option.

-Ben

Quoted 2 lines

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

#14 lore raw

Re: [dm-devel] [PATCH 2/2] multipath.conf(5): improve documentation of dev_loss_tmo

In reply to Martin Wilck

Enterprise 8 seems to have the new -T option, so clearly the old option had limited use, and went away.

I had to read the updates to make sure I was not missing anything in my
understanding of that timeout. We override the vendors setting on a
number of arrays (we use 87400 seconds, long enough that the paths stay around for normal array work-fw updates and reboot but short enough the
paths go away if really gone). We have a very large footprint of arrays
and hosts so have a lot of operational experience debugging issues caused by poor defaults interacting ( multipath, scsi, cluster, and applications timeouts).

Quoted 4 lines · Martin Wilck
Quoted 2 lines · Roger Heflin

Reading through it, on the line below, shouldn't it be -t (not -T)?

Quoted 51 lines

No, -T is correct. -t prints the entire internal table, most of which doesn't apply on any given system. -T prints only the settings for hardware that's present in the given system, which is what most users will prefer (I assume).

But thanks for reading carefully. Appreciated!

Martin

Quoted 38 lines

Line:
+the multipath-tools built-in settings override the default. Run \fImultipath -T\fR

Quoted 33 lines · Martin Wilck
Quoted 19 lines · Martin Wilck
Quoted 10 lines · Xose Vazquez Perez
Quoted 6 lines · On 12/1/22 11:32, [email protected] wrote:

From: Martin Wilck <[email protected]>

The statement that the default is 600 is wrong in most cases. Improve the description of the default and the dependency of this
parameter on other parameters.

I did change this patch to move "default value" to bottom.

The problem is that there is no easily explained default value for
this
parameter. Nice as the common "default value" format is, it doesn't
apply here.

Quoted 2 lines

If you have a suggestion for improving the formatting or wording, please speak up.

Sorry, I missed your other email because it had been sorted into a different folder.

Martin

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel