Skip to contentSkip to conversation

Add new recipe for squashfs-tools-ng

PATCH Superseded Luca Bocassi 6 participants 21 messages Oct 21, 2020 – Oct 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add new recipe for squashfs-tools-ng

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
 .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +37 -0
new file mode 100644
index 0000000000..bbc5f86ae9
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
Signature · 1 line
2.20.1
#1 lore raw
Quoted 6 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 7 lines
---
 .../squashfs-tools-ng_git.bb                  | 37
+++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-

tools-ng_git.bb

Should we be switching over to squashfs-tools-ng and removing squashfs- tools? I'm not sure we want to support both versions?

Cheers,

Richard

#2 lore raw
Quoted 16 lines · Richard Purdie
Quoted 6 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 7 lines
---
 .../squashfs-tools-ng_git.bb                  | 37
+++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-

tools-ng_git.bb

Quoted 2 lines

Should we be switching over to squashfs-tools-ng and removing squashfs- tools? I'm not sure we want to support both versions?

I am not sure if we want to switch to ng yet as on option its good to have. Perhaps in meta-oe or some other place.

Quoted 8 lines

Cheers,

Richard

#3 lore raw
Quoted 17 lines · Khem Raj
Quoted 15 lines · Richard Purdie
Quoted 13 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
 .../squashfs-tools-ng_git.bb                  | 37
+++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-

tools-ng_git.bb

Quoted 5 lines
Quoted 2 lines

Should we be switching over to squashfs-tools-ng and removing squashfs- tools? I'm not sure we want to support both versions?

I am not sure if we want to switch to ng yet as on option its good to have. Perhaps in meta-oe or some other place.

Yeah the command line interface is not a one-to-one mapping, so probably best to keep both around.

Signature · 2 lines
Kind regards,
Luca Boccassi
#4 lore raw
In reply to Luca Bocassi
Quoted 18 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
  .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
  1 file changed, 37 insertions(+)

create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +0 -0
new file mode 100644
index 0000000000..bbc5f86ae9

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 3

Quoted 3 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+"

A bit of nitpick, but with all the license files mentioned below the LICENSE setting looks wrong to me. I would at least expect some BSD and zLib SPDX identifiers here.

To be super exact one would have to take the PACKAGECONFIG into account to get the correct value

Quoted 39 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +34 -0
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
#5 lore raw
Quoted 13 lines · Konrad Weihmann
Quoted 12 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
  .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
  1 file changed, 37 insertions(+)

create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb

Quoted 13 lines

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 3

Quoted 9 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
new file mode 100644
index 0000000000..bbc5f86ae9
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+"

A bit of nitpick, but with all the license files mentioned below the LICENSE setting looks wrong to me.
I would at least expect some BSD and zLib SPDX identifiers here.

Added MIT, Zlib and BSD-2-Clause in v2.

Quoted 2 lines

To be super exact one would have to take the PACKAGECONFIG into account to get the correct value

The binary is distributed under the terms of GPL3 regardless, so not sure it's worth the complications? Is it required/commonly done in other recipes?

Signature · 2 lines
Kind regards,
Luca Boccassi
#6 lore raw

PATCH v2 1/1 Add new recipe for squashfs-tools-ng

In reply to Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE

 .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +37 -0
new file mode 100644
index 0000000000..6479017ddb
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
Signature · 1 line
2.20.1
#7 lore raw
Quoted 29 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Luca Bocassi
Sent: den 22 oktober 2020 11:20
To: [email protected]
Cc: [email protected]
Subject: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE

 .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-

tools-ng_git.bb

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +0 -0
new file mode 100644
index 0000000000..6479017ddb

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 3

Quoted 3 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"

Change "GPLv3+" to "GPL-3.0+" for consistency.

You have GPL-2.0 listed below too so it should probably be added above as well.

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 15

Quoted 12 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +12 -0
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"

Move the version to the file name.

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 18

Quoted 3 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"

I'd remove that backslash and keep it as one line.

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 24

Quoted 6 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +6 -0
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"

Change to:

PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"

Quoted 14 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +13 -1
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
--
Quoted 1 line

2.20.1

//Peter

#8 lore raw
Quoted 23 lines · Peter Kjellerstedt
Quoted 23 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Luca Bocassi
Sent: den 22 oktober 2020 11:20
To: [email protected]
Cc: [email protected]
Subject: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE

 .../squashfs-tools-ng_git.bb                  | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-

tools-ng_git.bb

Quoted 11 lines

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 3

Quoted 9 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
new file mode 100644
index 0000000000..6479017ddb
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"

Change "GPLv3+" to "GPL-3.0+" for consistency.

Done.

Quoted 2 lines

You have GPL-2.0 listed below too so it should probably be added above as well.

The COPYING.md file specifies that it is mentioned only because some of the dependencies use it and can be linked against. As far as I can see no code included in this repository uses that license. So I've removed it from the checksum list.

Quoted 6 lines
Quoted 6 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +6 -0
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
Quoted 8 lines

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 15

Quoted 6 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +6 -0
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"

Move the version to the file name.

Done.

Quoted 5 lines

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 18

Quoted 3 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +3 -0
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"

I'd remove that backslash and keep it as one line.

Done.

Quoted 10 lines

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb line 24

Quoted 6 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb new file +6 -0
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"

Change to:

PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"

Done.

Signature · 2 lines
Kind regards,
Luca Boccassi
#9 lore raw

PATCH v3 1/1 Add new recipe for squashfs-tools-ng

In reply to Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG

 .../squashfs-tools-ng_1.0.2.bb                | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +34 -0
new file mode 100644
index 0000000000..293b31cd92
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
Signature · 1 line
2.20.1
#10 lore raw
Quoted 5 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Can you clarify which parts are under GPL-3.0+ & LGPL-3.0+ licenses.
is it possible to ship traditional functionality from squashfs-tools without using code under these licenses.

Quoted 56 lines

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG

  .../squashfs-tools-ng_1.0.2.bb                | 34 +++++++++++++++++++
  1 file changed, 34 insertions(+)

create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +34 -0
new file mode 100644
index 0000000000..293b31cd92
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
#11 lore raw
Quoted 11 lines · Khem Raj
Quoted 5 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Can you clarify which parts are under GPL-3.0+ & LGPL-3.0+ licenses. is it possible to ship traditional functionality from squashfs-tools without using code under these licenses.

It's all defined in COPYING.md - the library is under LGPL3+, the rest of the code (command-line tools) under GPL3+.

# License of squashfs-tools-ng

The libsquashfs library is released under the terms and conditions of the **GNU Lesser General Public License version 3 or later**. This applies to all source code in the directories lib/sqfs, lib/util and include/sqfs with the following exceptions:

- lib/util/xxhash.c contains a modified implementation of the xxhash32 algorithm. See licenses/xxhash.txt for copyright and licensing information (2 clause BSD license).
- lib/lz4 contains files extracted from the LZ4 compression library. See lib/lz4/README for details and licenses/LZ4.txt for copyright and licensing information (2 clause BSD license).
- lib/zlib contains files that have been extracted from the the zlib compression library and modified. See lib/zlib/README for details and licenses/zlib.txt for details.
- lib/util/hash_table.c, include/hash_table.h and lib/util/fast_urem_by_const.h contain a hash table implementation (MIT license). See licenses/hash_table.txt for details.

The rest of squashfs-tools-ng is released under the terms and conditions of the **GNU General Public License version 3 or later**.

Signature · 2 lines
Kind regards,
Luca Boccassi
#12 lore raw
In reply to Luca Bocassi
Quoted 38 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG

 .../squashfs-tools-ng_1.0.2.bb                | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +16 -0
new file mode 100644
index 0000000000..293b31cd92
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb line 26

Quoted 10 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +10 -0
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"

Testing on the autobuilder showed up:

ERROR: Nothing PROVIDES 'zstd' (but /home/pokybuild/yocto-worker/check-layer/build/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb DEPENDS on or otherwise requires it)

(zstd isn't in OE-Core)

Cheers,

Richard

#13 lore raw
Quoted 52 lines · Richard Purdie
Quoted 38 lines · Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG

 .../squashfs-tools-ng_1.0.2.bb                | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +16 -0
new file mode 100644
index 0000000000..293b31cd92
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+

meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb line 26

Quoted 10 lines
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +10 -0
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"

Testing on the autobuilder showed up:

Quoted 7 lines

ERROR: Nothing PROVIDES 'zstd' (but /home/pokybuild/yocto-worker/check-layer/build/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb DEPENDS on or otherwise requires it)

(zstd isn't in OE-Core)

Cheers,

Richard

Removed zstd from default config in v4.

Signature · 2 lines
Kind regards,
Luca Boccassi
#14 lore raw

PATCH v4 1/1 Add new recipe for squashfs-tools-ng

In reply to Luca Bocassi

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe-core

 .../squashfs-tools-ng_1.0.2.bb                | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb new file +34 -0
new file mode 100644
index 0000000000..948a030810
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+                    file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+                    file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+                    file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+                    file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+                    file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+                    file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+                    file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+                    file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
Signature · 1 line
2.20.1
#15 lore raw
Quoted 6 lines · On Mon, 2020-10-26 at 10:05 +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 8 lines

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe- core

Sorry, there is one other issue. There is no maintainers entry for this recipe (see meta/conf/distro/include/maintainers.inc) which would cause oe-selftest to fail. Can you add an maintainers entry please?

Thanks,
Richard

#16 lore raw
Quoted 16 lines · Richard Purdie
Quoted 6 lines · On Mon, 2020-10-26 at 10:05 +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 8 lines

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe- core

Quoted 6 lines

Sorry, there is one other issue. There is no maintainers entry for this recipe (see meta/conf/distro/include/maintainers.inc) which would cause oe-selftest to fail. Can you add an maintainers entry please?

Thanks,
Richard

Ok - who should be listed as maintainer?

Signature · 2 lines
Kind regards,
Luca Boccassi
#17 lore raw
Quoted 17 lines · Luca Boccassi
Quoted 16 lines · Richard Purdie
Quoted 14 lines · On Mon, 2020-10-26 at 10:05 +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe- core

Quoted 8 lines
Quoted 6 lines

Sorry, there is one other issue. There is no maintainers entry for this recipe (see meta/conf/distro/include/maintainers.inc) which would cause oe-selftest to fail. Can you add an maintainers entry please?

Thanks,
Richard

Ok - who should be listed as maintainer?

Ping - please let me know and I'll send a v5. Thanks.

Signature · 2 lines
Kind regards,
Luca Boccassi
#18 lore raw
In reply to Luca Bocassi
Quoted 24 lines · Luca Boccassi
Quoted 23 lines · Richard Purdie
Quoted 7 lines · On Mon, 2020-10-26 at 10:05 +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 8 lines

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe-
core

Sorry, there is one other issue. There is no maintainers entry for this
recipe (see meta/conf/distro/include/maintainers.inc) which would cause
oe-selftest to fail. Can you add an maintainers entry please?

Quoted 4 lines
Quoted 2 lines

Thanks,
Richard

Ok - who should be listed as maintainer?

The person who is going to look after this recipe in OE-Core. Each recipe needs to have a maintainer listed, someone who is prepared to get the upgrade helper emails, handle upgrades, help with security issues, bugs related to the recipe and so on.

If we don't have anyone willing to maintain it, I'd argue its not important enough to have in OE-Core...

Cheers,

Richard

#19 lore raw
Quoted 35 lines · Richard Purdie
Quoted 24 lines · Luca Boccassi
Quoted 23 lines · Richard Purdie
Quoted 7 lines · On Mon, 2020-10-26 at 10:05 +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

The main difference with squashfs-tools is the availability of a shared library and a programmatic interface, rather than just command-line tools.

Quoted 8 lines

---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe-
core

Sorry, there is one other issue. There is no maintainers entry for this
recipe (see meta/conf/distro/include/maintainers.inc) which would cause
oe-selftest to fail. Can you add an maintainers entry please?

Quoted 4 lines
Quoted 2 lines

Thanks,
Richard

Ok - who should be listed as maintainer?

The person who is going to look after this recipe in OE-Core. Each recipe needs to have a maintainer listed, someone who is prepared to get the upgrade helper emails, handle upgrades, help with security issues, bugs related to the recipe and so on.

Quoted 6 lines

If we don't have anyone willing to maintain it, I'd argue its not important enough to have in OE-Core...

Cheers,

Richard

Ok, I'll move to meta-openembedded then.

Signature · 2 lines
Kind regards,
Luca Boccassi
#20 lore raw
Quoted 11 lines · Luca Bocassi
Quoted 9 lines
Quoted 1 line

Ok - who should be listed as maintainer?

The person who is going to look after this recipe in OE-Core. Each recipe needs to have a maintainer listed, someone who is prepared to get the upgrade helper emails, handle upgrades, help with security issues, bugs related to the recipe and so on.

If we don't have anyone willing to maintain it, I'd argue its not important enough to have in OE-Core...

Ok, I'll move to meta-openembedded then.

If you care enough to write and submit a recipe, don't you care enough to maintain it in the future?

Ross