Skip to contentSkip to conversation

KVM: X86: Add 'else' to unify fastop and execute call path

PATCH linmiaohe 1 participant 1 message Jan 22, 2020 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw

Hi:

Quoted 6 lines · Sean Christopherson
Quoted 3 lines · linmiaohe

From: Miaohe Lin <[email protected]>

It also helps eliminate some duplicated code.

Thanks for your review.

Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +0 -0
 		if (ctxt->d & Fastop) {
 			void (*fop)(struct fastop *) = (void *)ctxt->execute;

The brackets can also be removed with a bit more cleanup, e.g. using a typedef to handling casting ctxt->execute. I'll send a patch that can be applied on top and/or squashed with this one.

Thanks for doing this. :)

Quoted 2 lines
Quoted 2 lines

rc = fastop(ctxt, fop);