Fix ICE reg size on Kodiak and SM8450 dts
cover Fix ICE reg size on Kodiak and SM8450 dts
Update ICE reg size for kodiak and sm8450.
Ice reg size for kodiak/sm8450 is currently written incorrectly and doesn't match hardware specification. This series attempt to fix it.
Note: I attempted to send patch series to myself but some mishap happened but patch isn't sent to ML. Sending it again properly. Sorry for inconvenience.
---
Kuldeep Singh (2):
arm64: dts: qcom: kodiak: Fix ICE reg size
arm64: dts: qcom: sm8450: Fix ICE reg size
arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: d0c3bcd5b8976159d835a897254048e078f447e6
change-id: 20260331-ice_dt_reg_fix-eda625cda3e2
Best regards,
Signature · 1 line
Kuldeep Singh <[email protected]>
PATCH 1/2 arm64: dts: qcom: kodiak: Fix ICE reg size
The ICE register region on Kodiak is currently defined as 0x8000 bytes. According to the hardware specification, the correct register size is 0x18000.
Update the ICE node reg property to match the hardware.
--- arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/kodiak.dtsi +1 -1
@@ -2578,7 +2578,7 @@ ufs_mem_phy: phy@1d87000 { ice: crypto@1d88000 { compatible = "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; - reg = <0 0x01d88000 0 0x8000>; + reg = <0 0x01d88000 0 0x18000>; clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; };
Signature · 1 line
2.34.1
Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Fix ICE reg size
Quoted 9 lines · Kuldeep Singh
The ICE register region on Kodiak is currently defined as
0x8000bytes. According to the hardware specification, the correct register size is0x18000.Update the ICE node reg property to match the hardware.
Fixes dfd5ee7b34bb ("arm64: dts: qcom: sc7280: Add inline crypto engine")Signed-off-by Kuldeep Singh <[email protected]>---
Konrad
Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Fix ICE reg size
In reply to Kuldeep SinghQuoted 18 lines · Kuldeep Singh
The ICE register region on Kodiak is currently defined as
0x8000bytes. According to the hardware specification, the correct register size is0x18000.Update the ICE node reg property to match the hardware.
Fixes dfd5ee7b34bb ("arm64: dts: qcom: sc7280: Add inline crypto engine")Signed-off-by Kuldeep Singh <[email protected]>--- arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/qcom/kodiak.dtsi +0
-0
arch/arm64/boot/dts/qcom/kodiak.dtsi ufs_mem_phy: phy@1d87000 { · line 2584
Quoted 8 lines
arch/arm64/boot/dts/qcom/kodiak.dtsi +1
-1@@ -2578,7 +2578,7 @@ ufs_mem_phy: phy@1d87000 { ice: crypto@1d88000 { compatible = "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; - reg = <0 0x01d88000 0 0x8000>; + reg = <0 0x01d88000 0 0x18000>; clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; };
Good catch, looks good to me.
Regards,
Harshal
PATCH 2/2 arm64: dts: qcom: sm8450: Fix ICE reg size
In reply to Kuldeep SinghThe ICE register region size was originally described incorrectly when the ICE hardware was first introduced. The same value was later carried over unchanged when the ICE node was split out from the UFS node into its own DT entry.
Correct the register size to match the hardware specification.
--- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8450.dtsi +1 -1
@@ -5373,7 +5373,7 @@ ufs_mem_phy: phy@1d87000 { ice: crypto@1d88000 { compatible = "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; - reg = <0 0x01d88000 0 0x8000>; + reg = <0 0x01d88000 0 0x18000>; clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; };
Signature · 1 line
2.34.1
Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Fix ICE reg size
Quoted 10 lines · Kuldeep Singh
The ICE register region size was originally described incorrectly when the ICE hardware was first introduced. The same value was later carried over unchanged when the ICE node was split out from the UFS node into its own DT entry.
Correct the register size to match the hardware specification.
Fixes 276ee34a40c1 ("arm64: dts: qcom: sm8450: add Inline Crypto Engine registers and clock")Signed-off-by Kuldeep Singh <[email protected]>---
Konrad
Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Fix ICE reg size
In reply to Kuldeep SinghQuoted 19 lines · Kuldeep Singh
The ICE register region size was originally described incorrectly when the ICE hardware was first introduced. The same value was later carried over unchanged when the ICE node was split out from the UFS node into its own DT entry.
Correct the register size to match the hardware specification.
Fixes 276ee34a40c1 ("arm64: dts: qcom: sm8450: add Inline Crypto Engine registers and clock")Signed-off-by Kuldeep Singh <[email protected]>--- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/qcom/sm8450.dtsi +0
-0
arch/arm64/boot/dts/qcom/sm8450.dtsi ufs_mem_phy: phy@1d87000 { · line 5379
Quoted 8 lines
arch/arm64/boot/dts/qcom/sm8450.dtsi +1
-1@@ -5373,7 +5373,7 @@ ufs_mem_phy: phy@1d87000 { ice: crypto@1d88000 { compatible = "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; - reg = <0 0x01d88000 0 0x8000>; + reg = <0 0x01d88000 0 0x18000>; clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; };
Regards,
Harshal
Quoted 10 lines · Kuldeep Singh
Update ICE reg size for kodiak and sm8450.
Ice reg size for kodiak/sm8450 is currently written incorrectly and doesn't match hardware specification. This series attempt to fix it.
Note: I attempted to send patch series to myself but some mishap happened but patch isn't sent to ML. Sending it again properly. Sorry for inconvenience.
[...]
Applied, thanks!
[1/2] arm64: dts: qcom: kodiak: Fix ICE reg size
commit: fa9c7403af64d3e56a6c20dedc60e0a55b527509
[2/2] arm64: dts: qcom: sm8450: Fix ICE reg size
commit: 7fb3d0512dacc0d09217eb45057357f00298203dBest regards,
Signature · 1 line
Bjorn Andersson <[email protected]>