drm/vboxvideo/vboxvideo.h: Replace zero-length array with flexible-array member
Subsystems (3)
PATCH 1/1 drm/vboxvideo/vboxvideo.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vboxvideo/vboxvideo.h +1 -1
@@ -138,7 +138,7 @@ struct vbva_buffer {u32 data_len;/* variable size for the rest of the vbva_buffer area in VRAM. */ -u8 data[0 ]; +u8 data[]; } __packed;#define VBVA_MAX_RECORD_SIZE (128 * 1024 * 1024)
Signature · 1 line
2.25.0
Hi,
Quoted 22 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
Quoted 7 lines
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch looks good to me:
Regards,
Hans
Quoted 10 lines
--- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vboxvideo/vboxvideo.h +0
-0
drivers/gpu/drm/vboxvideo/vboxvideo.h struct vbva_buffer { · line 144
Quoted 8 lines
drivers/gpu/drm/vboxvideo/vboxvideo.h +1
-1@@ -138,7 +138,7 @@ struct vbva_buffer {u32 data_len;/* variable size for the rest of the vbva_buffer area in VRAM. */ -u8 data[0 ]; +u8 data[]; } __packed;#define VBVA_MAX_RECORD_SIZE (128 * 1024 * 1024)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 31 lines · Hans de Goede
Hi,
Quoted 28 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")
Quoted 5 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>Patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
You're also going to push this? r-b by maintainers without any hint to what's going to happen is always rather confusing.
-Daniel
Quoted 23 lines
Regards,
Hans
Quoted 16 lines
--- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vboxvideo/vboxvideo.h +1
-1@@ -138,7 +138,7 @@ struct vbva_buffer {u32 data_len;/* variable size for the rest of the vbva_buffer area in VRAM. */ -u8 data[0 ]; +u8 data[]; } __packed;#define VBVA_MAX_RECORD_SIZE (128 * 1024 * 1024)
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 32 lines · Daniel Vetter
Quoted 31 lines · Hans de Goede
Hi,
Quoted 28 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>Patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>You're also going to push this? r-b by maintainers without any hint to what's going to happen is always rather confusing.
Sorry about that, atm I'm on the road which makes pushing things somewhat inconvenient, so if someone else can push this, that would be great.
Regards,
Hans
Quoted 18 lines
Quoted 17 lines
Quoted 16 lines
--- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vboxvideo/vboxvideo.h +1
-1@@ -138,7 +138,7 @@ struct vbva_buffer {u32 data_len;/* variable size for the rest of the vbva_buffer area in VRAM. */ -u8 data[0 ]; +u8 data[]; } __packed;#define VBVA_MAX_RECORD_SIZE (128 * 1024 * 1024)
Hi,
Quoted 32 lines · Daniel Vetter
Quoted 31 lines · Hans de Goede
Hi,
Quoted 28 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>Patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>You're also going to push this? r-b by maintainers without any hint to what's going to happen is always rather confusing.
I've pushed this now, sorry for the confusion I will be more clear about my intentions next time.
Regards,
Hans
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
--- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/vboxvideo/vboxvideo.h +0
-0Quoted 9 lines
drivers/gpu/drm/vboxvideo/vboxvideo.h struct vbva_buffer { · line 143
Quoted 8 lines
drivers/gpu/drm/vboxvideo/vboxvideo.h +1
-1@@ -138,7 +138,7 @@ struct vbva_buffer {u32 data_len;/* variable size for the rest of the vbva_buffer area in VRAM. */ -u8 data[0 ]; +u8 data[]; } __packed;#define VBVA_MAX_RECORD_SIZE (128 * 1024 * 1024)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel