ixgbe: Prevent u8 wrapping of ITR value to something less than 10us
Subsystems (2)
PATCH 1/1 ixgbe: Prevent u8 wrapping of ITR value to something less than 10us
From: Alexander Duyck <[email protected]>
There were a couple cases where the ITR value generated via the adaptive ITR scheme could exceed 126. This resulted in the value becoming either 0 or something less than 10. Switching back and forth between a value less than 10 and a value greater than 10 can cause issues as certain hardware features such as RSC to not function well when the ITR value has dropped that low.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +3 -1
@@ -2621,7 +2621,7 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,/* 16K ints/sec to 9.2K ints/sec */ avg_wire_size *=15 ; avg_wire_size +=11452 ; - }else if (avg_wire_size <=1980 ) { + }else if (avg_wire_size <1968 ) {/* 9.2K ints/sec to 8K ints/sec */ avg_wire_size *=5 ; avg_wire_size +=22420 ;
@@ -2654,6 +2654,8 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,case IXGBE_LINK_SPEED_2_5GB_FULL :case IXGBE_LINK_SPEED_1GB_FULL :case IXGBE_LINK_SPEED_10_FULL : +if (avg_wire_size >8064 ) + avg_wire_size =8064 ; itr +=DIV_ROUND_UP (avg_wire_size,IXGBE_ITR_ADAPTIVE_MIN_INC *64 ) *IXGBE_ITR_ADAPTIVE_MIN_INC ;
Bowers
PATCH 1/1 ixgbe: Prevent u8 wrapping of ITR value to something less than 10us
Quoted 17 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alexander Duyck
Sent: Wednesday, September 4, 2019 8:07 AM
To: intel-wired-lan at lists.osuosl.org
Cc: alexander.h.duyck at linux.intel.com; gleventhal at janestreet.com
Subject: [Intel-wired-lan] [net-queue PATCH] ixgbe: Prevent u8 wrapping of ITR value to something less than 10usFrom: Alexander Duyck <[email protected]>
There were a couple cases where the ITR value generated via the adaptive ITR scheme could exceed 126. This resulted in the value becoming either 0 or something less than 10. Switching back and forth between a value less than 10 and a value greater than 10 can cause issues as certain hardware features such as RSC to not function well when the ITR value has dropped that low.
Quoted 5 lines
Reported-by Gregg Leventhal <[email protected]>Signed-off-by Alexander Duyck <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)