Skip to contentSkip to conversation

maintainers: update for armv8 crypto library

PATCH In review [email protected] 5 participants 11 messages Oct 12, 2019 – Oct 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: update for armv8 crypto library

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned
by Marvell, specifically crafted to the DPDK performance use case. # There is no upstream path to this library and it
will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
doc/guides/cryptodevs/armv8.rst +1 -2
index 1ab40096e..ada2a774d 100644
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
Signature · 1 line
2.23.0
#1 lore raw
Quoted 10 lines · On Sat, Oct 12, 2019 at 1:04 PM <[email protected]> wrote:

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

Ping for merge.

Quoted 69 lines

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned
by Marvell, specifically crafted to the DPDK performance use case. # There is no upstream path to this library and it
will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
doc/guides/cryptodevs/armv8.rst +1 -3
index 1ab40096e..ada2a774d 100644
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#2 lore raw
In reply to [email protected]

<snip>

Quoted 31 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

Quoted 3 lines

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to reflect this option?

Quoted 5 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This might be under use by applications. Removing the PMD will break those applications.

Quoted 37 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#3 lore raw
Quoted 37 lines · Honnappa Nagarahalli,

<snip>

Quoted 6 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the

library

Quoted 1 line

will not be maintained and probably removed soon therefor updating the

PMD

Quoted 5 lines

documentation to reflect the same.

---

Quoted 7 lines

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be

maintained due to

Quoted 7 lines

that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing

the

Quoted 1 line

following options. None of the options are converging as the result I

would like

Quoted 2 lines

to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows

the open

Quoted 9 lines
Quoted 3 lines

source philosophy in the way it is structured out now.

option 1) Move external library(BSD-3 license) to dpdk.org so that

every armv8

Quoted 2 lines

vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to reflect this option?

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid?

Quoted 11 lines
Quoted 3 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each

vendor.

Quoted 1 line

This won't change much in the existing situation as this PMD is not

standalone

Quoted 1 line

and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This might be under use by applications. Removing the PMD will break those applications.

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above.

If no one is ready to host the actual code, how is even possible to have floating PMD which can not even build by community.

I propose to take this to TB to reach to consensus as we are going in circles in mailing list.

Quoted 40 lines
Quoted 2 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if

he/she

Quoted 35 lines

would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#4 lore raw

23/10/2019 04:50, Jerin Jacob:

Quoted 2 lines

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid?

[...]

Quoted 2 lines

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above.

Yes it is questionable to host some asm code which is doing a processing not really specific to DPDK.
Also, my first thought was that this library could be used by other projects. Another concern about integrating this crypto lib in DPDK is to know whether it would have an impact on DPDK packaging and delivering? I don't remember any answer about legal export of this crypto processing.

#5 lore raw
Quoted 10 lines · Thomas Monjalon

23/10/2019 04:50, Jerin Jacob:

Quoted 2 lines

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid?

[...]

Quoted 2 lines

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above.

Yes it is questionable to host some asm code which is doing a processing not really specific to DPDK.

Currently, it is doing the DPDK specific processing like kernel code as asm code.

Quoted 1 line

Also, my first thought was that this library could be used by other projects.

OK.

Quoted 2 lines

Another concern about integrating this crypto lib in DPDK is to know whether it would have an impact on DPDK packaging and delivering?

See below.

Quoted 1 line

I don't remember any answer about legal export of this crypto processing.

I don't think, we ran through the legal check on this. But this can be a genuine issue from the above list. Not sure how Linux kernel handles this case.

Quoted 2 lines
#6 lore raw
In reply to Jerin Jacob

On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, <[email protected]<mailto:[email protected]>> wrote:
<snip>

Quoted 31 lines

From: Jerin Jacob <[email protected]<mailto:[email protected]>>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

Quoted 3 lines

option 1) Move external library(BSD-3 license) to dpdk.org<http://dpdk.org> so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore
better quality.

I do not see any issues with this approach. This patch should be changed to reflect this option?

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org<http://dpdk.org>. Is this concern still valid?

Quoted 5 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org<http://dpdk.org> and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This might be under use by applications. Removing the PMD will break those applications.

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above. [Honnappa] So, what should an application which has its own crypto library do when the PMD is removed?

If no one is ready to host the actual code, how is even possible to have floating PMD which can not even build by community.
[Honnappa] I am trying to understand your comment. Are you saying without the actual crypto library how do we build/test the PMD? Is it ok to introduce a stub library which is used if ‘ARMV8_CRYPTO_LIB_PATH’ is not set. Such stub should not be subjected to export license issues.

I propose to take this to TB to reach to consensus as we are going in circles in mailing list.

Quoted 37 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]<mailto:[email protected]>>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#7 lore raw
Quoted 61 lines · Honnappa Nagarahalli

On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, <[email protected]> wrote:

<snip>

Quoted 31 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

Quoted 3 lines

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to reflect this option?

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid?

Quoted 5 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This might be under use by applications. Removing the PMD will break those applications.

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above.

Quoted 7 lines

[Honnappa] So, what should an application which has its own crypto library do when the PMD is removed?

If no one is ready to host the actual code, how is even possible to have floating PMD which can not even build by community.

[Honnappa] I am trying to understand your comment. Are you saying without the actual crypto library how do we build/test the PMD?

Yes.

Quoted 1 line

Is it ok to introduce a stub library which is used if ‘ARMV8_CRYPTO_LIB_PATH’ is not set. Such stub should not be subjected to export license issues.

It won't be even functional. Right? and we really don't know, do we really have an export license issue or not?

Having said that, I have no issues if we choose to go with stub model provided this document patch is accepted.

Quoted 47 lines

I propose to take this to TB to reach to consensus as we are going in circles in mailing list.

Quoted 37 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS +0 -1
index b02066270..8096d93c4 100644
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#8 lore raw
Quoted 73 lines
Quoted 24 lines
Quoted 24 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

Quoted 5 lines
Quoted 5 lines

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the

way it is structured out now.

Quoted 5 lines
Quoted 4 lines

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to

reflect this option?

Quoted 6 lines

In past, there was a concern with this approach about maintaining the

assembly code in dpdk.org. Is this concern still valid?

Quoted 7 lines
Quoted 7 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each

vendor.

Quoted 3 lines
Quoted 2 lines

This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This

might be under use by applications. Removing the PMD will break those applications.

Quoted 4 lines

DPDK does not define any such interface. It was pushed to external library for

the reason mentioned above.

Quoted 2 lines

[Honnappa] So, what should an application which has its own crypto library

do when the PMD is removed?

Quoted 4 lines

If no one is ready to host the actual code, how is even possible to have

floating PMD which can not even build by community.

Quoted 2 lines

[Honnappa] I am trying to understand your comment. Are you saying without

the actual crypto library how do we build/test the PMD?

Quoted 8 lines

Yes.

Quoted 1 line

Is it ok to introduce a stub library which is used if

‘ARMV8_CRYPTO_LIB_PATH’ is not set. Such stub should not be subjected to export license issues.

It won't be even functional. Right? and we really don't know, do we really have an export license issue or not?

Agree, stub is to just ensure that the PMD to lib interface is functional. The export license issue need to be explored. Does this need to go to LF legal?

Quoted 3 lines

Having said that, I have no issues if we choose to go with stub model provided this document patch is accepted.

Stub should be the last option, only if we run out of other options as it will preserve only the PMD in DPDK. IMO, we still have not reached a conclusion. I think following questions need to be answered:
1) The discussion on whether it should be part of DPDK still not concluded (export license issues should come after this)
2) What are the export licensing issues in the context of DPDK as an open source project?
3) Can it be a 'hosted-project' (similar to pkt-gen etc)?

Quoted 49 lines
Quoted 5 lines

I propose to take this to TB to reach to consensus as we are going in circles in

mailing list.

Quoted 43 lines
Quoted 43 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS index b02066270..8096d93c4 renamed from MAINTAINERS +0 -0

100644

MAINTAINERS +0 -1
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#9 lore raw
Quoted 75 lines · Honnappa Nagarahalli
Quoted 75 lines
Quoted 24 lines
Quoted 24 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

Quoted 5 lines
Quoted 5 lines

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the

way it is structured out now.

Quoted 5 lines
Quoted 4 lines

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to

reflect this option?

Quoted 6 lines

In past, there was a concern with this approach about maintaining the

assembly code in dpdk.org. Is this concern still valid?

Quoted 7 lines
Quoted 7 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each

vendor.

Quoted 3 lines
Quoted 2 lines

This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

IMHO, DPDK defines an interface to integrate an external crypto library. This

might be under use by applications. Removing the PMD will break those applications.

Quoted 4 lines

DPDK does not define any such interface. It was pushed to external library for

the reason mentioned above.

Quoted 2 lines

[Honnappa] So, what should an application which has its own crypto library

do when the PMD is removed?

Quoted 4 lines

If no one is ready to host the actual code, how is even possible to have

floating PMD which can not even build by community.

Quoted 2 lines

[Honnappa] I am trying to understand your comment. Are you saying without

the actual crypto library how do we build/test the PMD?

Yes.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Is it ok to introduce a stub library which is used if

‘ARMV8_CRYPTO_LIB_PATH’ is not set. Such stub should not be subjected to export license issues.

It won't be even functional. Right? and we really don't know, do we really have an export license issue or not?

Agree, stub is to just ensure that the PMD to lib interface is functional. The export license issue need to be explored. Does this need to go to LF legal?

Hi Honnappa, et al,

Intel has a serious concern that including crypto code may cause restrictions on Intel contributions, this is under investigation.

Also another major concern that, this may limit some consumers/users to access to the dpdk and/or use it.

Quoted 59 lines
Quoted 4 lines

Having said that, I have no issues if we choose to go with stub model provided this document patch is accepted.

Stub should be the last option, only if we run out of other options as it will preserve only the PMD in DPDK. IMO, we still have not reached a conclusion. I think following questions need to be answered:
1) The discussion on whether it should be part of DPDK still not concluded (export license issues should come after this)
2) What are the export licensing issues in the context of DPDK as an open source project?
3) Can it be a 'hosted-project' (similar to pkt-gen etc)?

Quoted 49 lines
Quoted 5 lines

I propose to take this to TB to reach to consensus as we are going in circles in

mailing list.

Quoted 43 lines
Quoted 43 lines

I am glad/help to execute option 1 or 2 or help to a new maintainer if he/she would like to step up and take ownership.

---
 MAINTAINERS                     | 1 -
 doc/guides/cryptodevs/armv8.rst | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)
MAINTAINERS index b02066270..8096d93c4 renamed from MAINTAINERS +0 -0

100644

MAINTAINERS +0 -1
@@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst
 F: doc/guides/cryptodevs/features/ccp.ini
 
 ARMv8 Crypto
-M: Jerin Jacob <[email protected]>
 F: drivers/crypto/armv8/
 F: doc/guides/cryptodevs/armv8.rst
 F: doc/guides/cryptodevs/features/armv8.ini
(quoted diff) +0 -0

b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644

doc/guides/cryptodevs/armv8.rst +1 -3
@@ -28,8 +28,7 @@ Installation
 
 In order to enable this virtual crypto PMD, user must:
 
-* Download ARMv8 crypto library source code from
-  `here <https://github.com/caviumnetworks/armv8_crypto>`_
+* Use ARMv8 crypto library source code from vendor SDK
 
 * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with
   the path where the ``armv8_crypto`` library was downloaded
--

2.23.0

#10 lore raw
In reply to Honnappa Nagarahalli
Quoted 55 lines · Honnappa Nagarahalli

On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, <[email protected]> wrote:

<snip>

Quoted 31 lines

From: Jerin Jacob <[email protected]>

Update the armv8 crypto PMD maintainership.

https://github.com/caviumnetworks/armv8_crypto external crypto the library will not be maintained and probably removed soon therefor updating the PMD documentation to reflect the same.

---

This patch is based on the discussion of the following thread
http://mails.dpdk.org/archives/dev/2019-October/146005.html

In summary,
# ARMv8 crypto PMD depends on an external library owned by Marvell, specifically crafted to the DPDK performance use case.
# There is no upstream path to this library and it will not be maintained due to that fact that it
a) Creates fragmentation of the SW
b) Contribution policy concerning external Github Repos
c) None other than Marvell can contribute to this library and this makes difficult for other stakeholder to use it.

# As the maintainer, I would like to make forward progress by providing the following options. None of the options are converging as the result I would like to step down from the maintainership of the incomplete PMD as I don't see any options for collaboration, improvement in the library nor follows the open source philosophy in the way it is structured out now.

Quoted 3 lines

option 1) Move external library(BSD-3 license) to dpdk.org so that every armv8 vendors can contribute, improve and avoid SW fragmentation and therefore better quality.

I do not see any issues with this approach. This patch should be changed to reflect this option?

In past, there was a concern with this approach about maintaining the assembly code in dpdk.org. Is this concern still valid?

Quoted 5 lines

option 2) If option 1 is not possible, remove the incomplete PMD from dpdk.org and maintain the existing PMD as the external one by each vendor. This won't change much in the existing situation as this PMD is not standalone and anyway depended on an external code base.

Quoted 7 lines

IMHO, DPDK defines an interface to integrate an external crypto library. This might be under use by applications. Removing the PMD will break those applications.

DPDK does not define any such interface. It was pushed to external library for the reason mentioned above.

[Honnappa] So, what should an application which has its own crypto library do when the PMD is removed?

Sorry. I missed this question. The reason why it was moved out, is not to have N different crypto library and bind to this, instead of one library where
everyone can contribute it.
and the interface between library and the PMD is not designed to create a framework. It is crafted in the way, the "current" external library needed and not for the generic case.