Skip to contentSkip to conversation

net: phy: realtek: fix using paged operations with RTL8105e / RTL8208

PATCH Applied Heiner Kallweit 2 participants 2 messages Dec 1, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: realtek: fix using paged operations with RTL8105e / RTL8208

It was reported [0] that since the referenced commit a warning is triggered in phylib that complains about paged operations being used with a PHY driver that doesn't support this. The commit isn't wrong, just for one chip version (RTL8105e) no dedicated PHY driver exists yet. So add the missing PHY driver.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=202103

Fixes 3a129e3f9ac4 ("r8169: switch to phylib functions in more places")
---
 drivers/net/phy/realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/net/phy/realtek.c +9 -0
index 677c45985..476db5345 100644
@@ -439,6 +439,15 @@ static struct phy_driver realtek_drvs[] = {
 		.resume		= genphy_resume,
 		.read_page	= rtl821x_read_page,
 		.write_page	= rtl821x_write_page,
+	}, {
+		PHY_ID_MATCH_MODEL(0x001cc880),
+		.name		= "RTL8208 Fast Ethernet",
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
+		.suspend	= genphy_suspend,
+		.resume		= genphy_resume,
+		.read_page	= rtl821x_read_page,
+		.write_page	= rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc910),
 		.name		= "RTL8211 Gigabit Ethernet",
Signature · 1 line
2.24.0
maintainer Applied
#1 lore raw

From: Heiner Kallweit <[email protected]>
Date: Sun, 1 Dec 2019 10:51:47 +0100

Quoted 6 lines

It was reported [0] that since the referenced commit a warning is triggered in phylib that complains about paged operations being used with a PHY driver that doesn't support this. The commit isn't wrong, just for one chip version (RTL8105e) no dedicated PHY driver exists yet. So add the missing PHY driver.

Quoted 6 lines

[0] https://bugzilla.kernel.org/show_bug.cgi?id=202103

Fixes 3a129e3f9ac4 ("r8169: switch to phylib functions in more places")

Applied.