Skip to contentSkip to conversation

scsi_dh_alua: remove check for ASC 24h when ILLEGAL_REQUEST returned on RTPG w/extended header

PATCH Applied Ewan D. Milne 4 participants 6 messages Mar 31, 2021 – Apr 13, 2021 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi_dh_alua: remove check for ASC 24h when ILLEGAL_REQUEST returned on RTPG w/extended header

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the extended header, so remove the check for INVALID FIELD IN CDB.

---
 drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +3 -2
index e42390333c6e..c4c2f23cf79f 100644
@@ -587,10 +587,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
 		 * even though it shouldn't according to T10.
 		 * The retry without rtpg_ext_hdr_req set
 		 * handles this.
+		 * Note:  some arrays return a sense key of ILLEGAL_REQUEST
+		 * with ASC 00h if they don't support the extended header.
 		 */
 		if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
-		    sense_hdr.sense_key == ILLEGAL_REQUEST &&
-		    sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
+		    sense_hdr.sense_key == ILLEGAL_REQUEST) {
 			pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
 			goto retry;
 		}
Signature · 1 line
2.20.1
#1 lore raw
Quoted 2 lines · Ewan D. Milne

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the extended header, so remove the check for INVALID FIELD IN CDB.

Wow. Referring to the 18 byte sense buffer as an extended header sounds like it comes from the transition of SCSI-1 to SCSI-2, about 30 years ago. Those arrays need to be named and shamed.

Doug Gilbert
Hmm, it is April first ...

Quoted 24 lines
---
  drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +3 -2
index e42390333c6e..c4c2f23cf79f 100644
@@ -587,10 +587,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
  		 * even though it shouldn't according to T10.
  		 * The retry without rtpg_ext_hdr_req set
  		 * handles this.
+		 * Note:  some arrays return a sense key of ILLEGAL_REQUEST
+		 * with ASC 00h if they don't support the extended header.
  		 */
  		if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
-		    sense_hdr.sense_key == ILLEGAL_REQUEST &&
-		    sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
+		    sense_hdr.sense_key == ILLEGAL_REQUEST) {
  			pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
  			goto retry;
  		}
#2 lore raw
Quoted 11 lines · Douglas Gilbert
Quoted 2 lines · Ewan D. Milne

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the extended header, so remove the check for INVALID FIELD IN CDB.

Wow. Referring to the 18 byte sense buffer as an extended header sounds like it comes from the transition of SCSI-1 to SCSI-2, about 30 years ago. Those arrays need to be named and shamed.

Doug Gilbert
Hmm, it is April first ...

Hey, it took us some time to even _get_ this header; originally the specification didn't have that, requiring us to second-guess how long the array might take for a transition.

But still, April the first :-)

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		           Kernel Storage Architect
[email protected]			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
#3 lore raw
In reply to Douglas Gilbert
Quoted 10 lines · Douglas Gilbert
Quoted 3 lines · Ewan D. Milne

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the
extended header, so remove the check for INVALID FIELD IN CDB.

Wow. Referring to the 18 byte sense buffer as an extended header sounds
like it comes from the transition of SCSI-1 to SCSI-2, about 30 years ago.
Those arrays need to be named and shamed.

Sorry, I was referring to the RTPG command, not the sense header.

        cdb[0] = MAINTENANCE_IN;
        if (!(flags & ALUA_RTPG_EXT_HDR_UNSUPP))
                cdb[1] = MI_REPORT_TARGET_PGS | MI_EXT_HDR_PARAM_FMT;
        else
                cdb[1] = MI_REPORT_TARGET_PGS;

The array returned an error when the MI_EXT_HDR_PARAM_FMT bit was set but worked fine without it.

It was an older array, it worked with older kernels until we removed the ability to detach the device handler. So RTPG needs to work.

-Ewan

Quoted 34 lines

Doug Gilbert
Hmm, it is April first ...

Quoted 28 lines
---
  drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +1 -0
index e42390333c6e..c4c2f23cf79f 100644
@@ -587,10 +587,11 @@ static int alua_rtpg(struct scsi_device
 *sdev, struct alua_port_group *pg)
  		 * even though it shouldn't according to T10.
  		 * The retry without rtpg_ext_hdr_req set
  		 * handles this.
+		 * Note:  some arrays return a sense key of

ILLEGAL_REQUEST

drivers/scsi/device_handler/scsi_dh_alua.c +1 -0
+		 * with ASC 00h if they don't support the extended

header.
*/
if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&

drivers/scsi/device_handler/scsi_dh_alua.c +1 -2
-		    sense_hdr.sense_key == ILLEGAL_REQUEST &&
-		    sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
+		    sense_hdr.sense_key == ILLEGAL_REQUEST) {
  			pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
  			goto retry;
  		}
Reviewed-by on v1 1/1
#4 lore raw
In reply to Ewan D. Milne
Quoted 17 lines · Ewan D. Milne

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the extended header, so remove the check for INVALID FIELD IN CDB.

---
 drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +0 -0
index e42390333c6e..c4c2f23cf79f 100644
@@ -587,10 +587,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
 		 * even though it shouldn't according to T10.
 		 * The retry without rtpg_ext_hdr_req set
 		 * handles this.

drivers/scsi/device_handler/scsi_dh_alua.c static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) · line 597

Quoted 10 lines
drivers/scsi/device_handler/scsi_dh_alua.c +3 -2
+		 * Note:  some arrays return a sense key of ILLEGAL_REQUEST
+		 * with ASC 00h if they don't support the extended header.
 		 */
 		if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
-		    sense_hdr.sense_key == ILLEGAL_REQUEST &&
-		    sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
+		    sense_hdr.sense_key == ILLEGAL_REQUEST) {
 			pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
 			goto retry;
 		}

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		           Kernel Storage Architect
[email protected]			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
#5 lore raw
In reply to Ewan D. Milne
Quoted 2 lines · Ewan D. Milne

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the extended header, so remove the check for INVALID FIELD IN CDB.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi_dh_alua: remove check for ASC 24h when ILLEGAL_REQUEST returned on RTPG w/extended header

      https://git.kernel.org/mkp/scsi/c/bc3f2b42b70e
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering