Skip to contentSkip to conversation

environment.h: remove unused variables

PATCH In review Arnav Bhate 2 participants 2 messages Apr 5, 2025 – Apr 7, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 environment.h: remove unused variables

packed_git_window_size and packed_git_limit are not used anywhere in the codebase. A search found that all references were removed in d284713bae (config: make packed_git_(limit|window_size) non-global variables, 2024-12-03), except the ones in this file, as they were moved to struct repo_settings.

Remove packed_git_window_size and packed_git_limit from environment.h.

---
 environment.h | 2 --
 1 file changed, 2 deletions(-)
environment.h +0 -2
index 45e690f203..cf6fc04e70 100644
@@ -152,8 +152,6 @@ extern char *apply_default_ignorewhitespace;
 extern char *git_attributes_file;
 extern int zlib_compression_level;
 extern int pack_compression_level;
-extern size_t packed_git_window_size;
-extern size_t packed_git_limit;
 extern unsigned long big_file_threshold;
 extern unsigned long pack_size_limit_cfg;
 extern int max_allowed_tree_depth;
Signature · 1 line
2.49.0
#1 lore raw
Quoted 18 lines · Arnav Bhate

packed_git_window_size and packed_git_limit are not used anywhere in the codebase. A search found that all references were removed in d284713bae (config: make packed_git_(limit|window_size) non-global variables, 2024-12-03), except the ones in this file, as they were moved to struct repo_settings.

Remove packed_git_window_size and packed_git_limit from environment.h.

---
 environment.h | 2 --
 1 file changed, 2 deletions(-)
environment.h +0 -0
index 45e690f203..cf6fc04e70 100644

environment.h extern char *apply_default_ignorewhitespace; · line 157

Quoted 8 lines
environment.h +0 -2
@@ -152,8 +152,6 @@ extern char *apply_default_ignorewhitespace;
 extern char *git_attributes_file;
 extern int zlib_compression_level;
 extern int pack_compression_level;
-extern size_t packed_git_window_size;
-extern size_t packed_git_limit;
 extern unsigned long big_file_threshold;
 extern unsigned long pack_size_limit_cfg;
 extern int max_allowed_tree_depth;

Good catch indeed, the patch looks obviously good to me!

Patrick