mm/mseal: use min/max in mseal_apply
Subsystems (2)
PATCH 1/1 mm/mseal: use min/max in mseal_apply
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
--- mm/mseal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
mm/mseal.c +3 -2
@@ -8,6 +8,7 @@*/ #include <linux/mempolicy.h> +#include <linux/minmax.h> #include <linux/mman.h> #include <linux/mm.h> #include <linux/mm_inline.h>
@@ -65,8 +66,8 @@ static int mseal_apply(struct mm_struct *mm, prev = vma;for_each_vma_range (vmi, vma, end) { -const unsigned long curr_start =MAX (vma->vm_start, start); -const unsigned long curr_end =MIN (vma->vm_end, end); +const unsigned long curr_start =max (vma->vm_start, start); +const unsigned long curr_end =min (vma->vm_end, end);if (!vma_test (vma,VMA_SEALED_BIT )) {vma_flags_t vma_flags = vma->flags;
Quoted 2 lines · Thorsten Blum
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
Gotta love these macros... FYI this isn't the only wrong usage in the kernel.
Quoted 2 lines
Signed-off-by Thorsten Blum <[email protected]>
Signature · 1 line
Pedro
Quoted 5 lines · On Sun, 3 May 2026 21:58:57 +0100 Pedro Falcato <[email protected]> wrote:
Quoted 2 lines · Thorsten Blum
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
Gotta love these macros... FYI this isn't the only wrong usage in the kernel.
I failed to persuade Linus to include a test for __builtin_constant_p((a)|(b)) :-)
-- David
Quoted 6 lines
Quoted 3 lines
Signed-off-by Thorsten Blum <[email protected]>Reviewed-by Pedro Falcato <[email protected]>
Quoted 4 lines · Thorsten Blum
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
Signed-off-by Thorsten Blum <[email protected]>
Oops my bad :)
LGTM, so:
Quoted 27 lines
--- mm/mseal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)mm/mseal.c +3
-2@@ -8,6 +8,7 @@*/ #include <linux/mempolicy.h> +#include <linux/minmax.h> #include <linux/mman.h> #include <linux/mm.h> #include <linux/mm_inline.h> @@ -65,8 +66,8 @@ static int mseal_apply(struct mm_struct *mm, prev = vma;for_each_vma_range (vmi, vma, end) { -const unsigned long curr_start =MAX (vma->vm_start, start); -const unsigned long curr_end =MIN (vma->vm_end, end); +const unsigned long curr_start =max (vma->vm_start, start); +const unsigned long curr_end =min (vma->vm_end, end);if (!vma_test (vma,VMA_SEALED_BIT )) {vma_flags_t vma_flags = vma->flags;
Quoted 5 lines · Thorsten Blum
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
Signed-off-by Thorsten Blum <[email protected]>---
Signature · 3 lines
Cheers, David
Quoted 4 lines · On Sun, 3 May 2026 13:59:16 +0200 Thorsten Blum <[email protected]>…
Use the type-checked min()/max() macros instead of MIN()/MAX(), which are supposed to be used "for obvious constants only".
Signed-off-by Thorsten Blum <[email protected]>
Thanks,
SJ
[...]