Skip to contentSkip to conversation

dt-bindings: hwmon: ti,ina2xx: Add INA700

PATCH In review Guenter Roeck 2 participants 6 messages Sep 1, 2025 – Sep 2, 2025

Subsystems (2)
lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: hwmon: ti,ina2xx: Add INA700

Add a compatible string for INA700. The chip is register compatible with INA780 but implements different ADC ranges and thus needs a separate compatible entry.

---
 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +4 -0
index 8b491be9c49d..d3cde8936686 100644
@@ -32,6 +32,7 @@ properties:
       - ti,ina237
       - ti,ina238
       - ti,ina260
+      - ti,ina700
       - ti,ina780
 
   reg:
@@ -115,6 +116,7 @@ allOf:
               - ti,ina237
               - ti,ina238
               - ti,ina260
+              - ti,ina700
               - ti,ina780
     then:
       properties:
@@ -133,6 +135,7 @@ allOf:
               - ti,ina230
               - ti,ina231
               - ti,ina260
+              - ti,ina700
               - ti,ina780
     then:
       properties:
@@ -143,6 +146,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - ti,ina700
               - ti,ina780
     then:
       properties:
Signature · 1 line
2.45.2
author maintainer
#2 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 6 lines · Guenter Roeck

Add a compatible string for INA700. The chip is register compatible with INA780 but implements different ADC ranges and thus needs a separate compatible entry.

Please mention in commit msg where is any user of that.

You lost me a bit on that one. Christian had submitted a driver, but missed the devicetree documentation. That is what this patch is for. I frankly don't know how to mention a user as requested; I don't easily find an example in other devicetree patches. Typically the commit message is just "add <chip> to <bindings>". Please give me an example of what you are looking for.

Thanks,
Guenter

Quoted 5 lines

Best regards,
Krzysztof

#3 lore raw
Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Guenter Roeck

Add a compatible string for INA700. The chip is register compatible with INA780 but implements different ADC ranges and thus needs a separate compatible entry.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Please mention in commit msg where is any user of that.

You lost me a bit on that one. Christian had submitted a driver, but missed

And how do I know that there was such driver? commit msg should tell that one way or another.

Quoted 4 lines

the devicetree documentation. That is what this patch is for. I frankly don't know how to mention a user as requested; I don't easily find an example in other devicetree patches. Typically the commit message is just "add <chip> to <bindings>". Please give me an example of what you are looking for.

"Document existing compatible string for INA700. ....."

This is an easy way to explain that it already is used.

Best regards,
Krzysztof

author maintainer
#4 lore raw
Quoted 18 lines · Krzysztof Kozlowski
Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Krzysztof Kozlowski
Quoted 4 lines · Guenter Roeck

Add a compatible string for INA700. The chip is register compatible with INA780 but implements different ADC ranges and thus needs a separate compatible entry.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Please mention in commit msg where is any user of that.

You lost me a bit on that one. Christian had submitted a driver, but missed

And how do I know that there was such driver? commit msg should tell that one way or another.

Quoted 9 lines
Quoted 4 lines

the devicetree documentation. That is what this patch is for. I frankly don't know how to mention a user as requested; I don't easily find an example in other devicetree patches. Typically the commit message is just "add <chip> to <bindings>". Please give me an example of what you are looking for.

"Document existing compatible string for INA700. ....."

This is an easy way to explain that it already is used.

Upcoming would be more appropriate. NP, I'll resubmit with the actual driver patch series once it is ready and keep that in mind for the future.

Thanks,
Guenter

#5 lore raw
Quoted 6 lines · Guenter Roeck
Quoted 6 lines
Quoted 5 lines

the devicetree documentation. That is what this patch is for. I frankly don't know how to mention a user as requested; I don't easily find an example in other devicetree patches. Typically the commit message is just "add <chip> to <bindings>". Please give me an example of what you are looking for.

Quoted 6 lines
Quoted 4 lines

"Document existing compatible string for INA700. ....."

This is an easy way to explain that it already is used.

Upcoming would be more appropriate. NP, I'll resubmit with the actual driver patch series once it is ready and keep that in mind for the future.

Ah, sorry, I did not get it, it is a driver on the lists? I thought you are documenting something which you already merged.

Well, then the solution could be lore link in patch changelog. Resending as one patchset is also fine.

Best regards,
Krzysztof