Skip to contentSkip to conversation

CRYPTO: Fix checkpatch errors & warnings in cipher.c

PATCH In review Richard Hartmann 2 participants 7 messages Feb 10, 2010 – Feb 16, 2010 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CRYPTO: Fix checkpatch errors & warnings in cipher.c

---
 crypto/compress.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
crypto/compress.c +2 -2
index 1ee3570..c33f076 100644
@@ -7,7 +7,7 @@
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option) 
+ * Software Foundation; either version 2 of the License, or (at your option)
  * any later version.
  *
  */
@@ -39,7 +39,7 @@ int crypto_init_compress_ops(struct crypto_tfm *tfm)
 
 	ops->cot_compress = crypto_compress;
 	ops->cot_decompress = crypto_decompress;
-	
+
 	return 0;
 }
 
Signature · 1 line
1.6.6.1
#1 lore raw

Obviously, this should have been named

CRYPTO: Fix checkpatch errors & warnings in compress.c

Should I re-send the patch or is it less noise & hassle if I just leave it this way?

Richard

Quoted 29 lines · Richard Hartmann

---
 crypto/compress.c |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)
crypto/compress.c +2 -3
index 1ee3570..c33f076 100644
@@ -7,7 +7,7 @@
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option)
+ * Software Foundation; either version 2 of the License, or (at your option)
  * any later version.
  *
  */
@@ -39,7 +39,7 @@ int crypto_init_compress_ops(struct crypto_tfm *tfm)
 
        ops->cot_compress = crypto_compress;
        ops->cot_decompress = crypto_decompress;
-
+
        return 0;
  }
 
--
Quoted 3 lines

1.6.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
Quoted 6 lines · Richard Hartmann

Obviously, this should have been named

CRYPTO: Fix checkpatch errors & warnings in compress.c

Should I re-send the patch or is it less noise & hassle if I just leave it this way?

You don't have to resend it.

Thanks,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#3 lore raw
Quoted 4 lines · Herbert Xu
Quoted 2 lines

Should I re-send the patch or is it less noise & hassle if I just leave it this way?

You don't have to resend it.

GregKH said that I should just re-send all patches after a week. OTOH, I am not sure if this is not a little bit too agressive.

Thus, I wanted to check if I should wait some more or what the general consensus of action in the crypto subtree is.

And yes, I am aware that janitor work, and thus my patches, is very low priority.

Thanks,
Richard

maintainer
#4 lore raw
Quoted 6 lines · Richard Hartmann

Thus, I wanted to check if I should wait some more or what the general consensus of action in the crypto subtree is.

And yes, I am aware that janitor work, and thus my patches, is very low priority.

For the crypto tree at least I've got all your patches so you don't have to resend.

For other trees please follow whatever their maintainer (or Greg) says.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#5 lore raw
Quoted 2 lines · Herbert Xu

For the crypto tree at least I've got all your patches so you don't have to resend.

OK, thank you very much. Expect more patches, in this case :)

One more question on workflow, though.. I have been checking
http://git.kernel.org/?p=linux/kernel/git/herbert/crypto-2.6.git;a=summary
for updates, but obviously, this was the wrong place.

Where should I look for your commits so I don't have to have you waste your time answering emails?

Thanks,
Richard

maintainer
#6 lore raw
Quoted 4 lines · Richard Hartmann

One more question on workflow, though.. I have been checking
http://git.kernel.org/?p=linux/kernel/git/herbert/crypto-2.6.git;a=summary
for updates, but obviously, this was the wrong place.

You should check the cryptodev-2.6 tree. However, they won't be there yet as I haven't pushed your changes out. Expect them to be there by tomorrow.

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt