Skip to contentSkip to conversation

arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-pinebook-pro

PATCH Applied Peter Robinson 3 participants 3 messages Jul 30, 2025 – Aug 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-pinebook-pro

As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10, he SPI Flash's VCC connector is connected to VCC_3V0 power source.

This fixes the following warning:

spi-nor spi1.0: supply vcc not found, using dummy regulator

Fixes 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
---
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +1 -0
index 05c48cb09df6f..ee0e6c1947acb 100644
@@ -978,6 +978,7 @@ spiflash: flash@0 {
 		reg = <0>;
 		m25p,fast-read;
 		spi-max-frequency = <10000000>;
+		vcc-supply = <&vcc_3v0>;
 	};
 };
 
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw

Hello Peter,

Quoted 20 lines · Peter Robinson

As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10, he SPI Flash's VCC connector is connected to VCC_3V0 power source.

This fixes the following warning:

spi-nor spi1.0: supply vcc not found, using dummy regulator

Fixes 5a65505a69884 ("arm64: dts: rockchip: Add initial support for

Pinebook Pro")

---
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0 -0
index 05c48cb09df6f..ee0e6c1947acb 100644

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts spiflash: flash@0 { · line 983

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +1 -0
@@ -978,6 +978,7 @@ spiflash: flash@0 {
 		reg = <0>;
 		m25p,fast-read;
 		spi-max-frequency = <10000000>;
+		vcc-supply = <&vcc_3v0>;
 	};
 };

Thanks for the patch! This addition to the Pinebook Pro device dts file is looking good to me. I just checked the schematics of both Pinebook Pro production versions, i.e. v2.1 and v2.1a, to verify the addition.

I've got a couple of nitpicks, though. First, using "Pinebook Pro" instead of "rk3399-pinebook-pro" in the patch summary would be a bit more readable. Second, it would be better to mention the existence of the second production version, i.e. v2.1, in the patch description, to clarify that the DT addition applies to both versions, with both schematics mentioned as references. [1][2]

Anyway, please feel free to include:

[1] https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
[2] https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdf

maintainer Applied
#2 lore raw
In reply to Peter Robinson
Quoted 8 lines · Peter Robinson

As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10, he SPI Flash's VCC connector is connected to VCC_3V0 power source.

This fixes the following warning:

spi-nor spi1.0: supply vcc not found, using dummy regulator

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-pinebook-pro

      commit: d1f9c497618dece06a00e0b2995ed6b38fafe6b5

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>