Skip to contentSkip to conversation

PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3

PATCH Superseded Felix Fietkau 2 participants 2 messages May 4, 2022 – May 5, 2022

Subsystems (4)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3

driver_register() will refuse to register another driver with the same name. This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into the kernel.

---
 drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-mediatek-gen3.c +1 -1
index 3e8d70bfabc6..2e665cd7e735 100644
@@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
 	.probe = mtk_pcie_probe,
 	.remove = mtk_pcie_remove,
 	.driver = {
-		.name = "mtk-pcie",
+		.name = "mtk-pcie-gen3",
 		.of_match_table = mtk_pcie_of_match,
 		.pm = &mtk_pcie_pm_ops,
 	},
Signature · 7 lines
2.35.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v3 1/1
#1 lore raw

Il 04/05/22 19:21, Felix Fietkau ha scritto:

Quoted 15 lines

driver_register() will refuse to register another driver with the same name. This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into the kernel.

---
  drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pcie-mediatek-gen3.c +0 -0
index 3e8d70bfabc6..2e665cd7e735 100644

drivers/pci/controller/pcie-mediatek-gen3.c static struct platform_driver mtk_pcie_driver = { · line 1027

Quoted 8 lines
drivers/pci/controller/pcie-mediatek-gen3.c +1 -1
@@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
  	.probe = mtk_pcie_probe,
  	.remove = mtk_pcie_remove,
  	.driver = {
-		.name = "mtk-pcie",
+		.name = "mtk-pcie-gen3",
  		.of_match_table = mtk_pcie_of_match,
  		.pm = &mtk_pcie_pm_ops,
  	},

Hello Felix,

this is a good fix - and being it a fix, this requires a Fixes: tag - which also gets this scheduled for backporting, which is important to solve this issue on all of the affected kernels.

I'll make it easy for you as I've already checked the commit hash:

Fixes d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")

After adding that:

Cheers,
Angelo