Skip to contentSkip to conversation

ARM: dts: stm32: Add missing ETHCK clock to ethernet node

PATCH In review Marek Vasut 3 participants 4 messages Jan 15, 2020 – Jan 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing ETHCK clock to ethernet node

Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate external clock signal for the PHY in case 'st,eth_ref_clk_sel' is specified.

Cc Christophe ROULLIER <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/stm32mp151.dtsi +2 -0
index fb41d0778b00..e0ecc5ee7d83 100644
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi Marek;

Add the Linux Maintainers for STM32M linux patch:

M: Maxime Coquelin <[email protected]>
M: Alexandre Torgue <[email protected]>
L: [email protected] (moderated for non-subscribers)
L: [email protected] (moderated for non-subscribers)

Hi Alexandre,

Can you review this patch.

Regards

Patrick

Quoted 34 lines

From: Marek Vasut <[email protected]>
Sent: mercredi 15 janvier 2020 10:46

Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate external clock signal for the PHY in case 'st,eth_ref_clk_sel'
is specified.

Cc Christophe ROULLIER <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/stm32mp151.dtsi +2 -1
index fb41d0778b00..e0ecc5ee7d83 100644
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;
--
Quoted 1 line

2.24.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 1 line · Patrick DELAUNAY

Hi Marek;

Hi,

Quoted 1 line

Add the Linux Maintainers for STM32M linux patch:

Added, if there is a need for V2.
[...]

Quoted 45 lines

Hi Alexandre,

Can you review this patch.

Regards

Patrick

Quoted 35 lines

From: Marek Vasut <[email protected]>
Sent: mercredi 15 janvier 2020 10:46

Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate external clock signal for the PHY in case 'st,eth_ref_clk_sel'
is specified.

Cc Christophe ROULLIER <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/stm32mp151.dtsi +2 -1
index fb41d0778b00..e0ecc5ee7d83 100644
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;
--

2.24.1

Signature · 7 lines
Best regards,
Marek Vasut

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Hi Marek

Quoted 25 lines · Marek Vasut
Quoted 1 line · Patrick DELAUNAY

Hi Marek;

Hi,

Quoted 1 line

Add the Linux Maintainers for STM32M linux patch:

Added, if there is a need for V2.
[...]

Quoted 16 lines

Hi Alexandre,

Can you review this patch.

Regards

Patrick

Quoted 7 lines

From: Marek Vasut <[email protected]>
Sent: mercredi 15 janvier 2020 10:46

Add missing 'eth-ck' clock to the ethernet node. These clock are used to generate external clock signal for the PHY in case 'st,eth_ref_clk_sel'
is specified.

Just indicate in commit title that this commit is done for stm32mp15 family. Otherwise it looks good.

Thanks
Alex

Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Cc Christophe ROULLIER <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
  arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/boot/dts/stm32mp151.dtsi +1 -0
index fb41d0778b00..e0ecc5ee7d83 100644
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
  			clock-names = "stmmaceth",
  				      "mac-clk-tx",
  				      "mac-clk-rx",
+				      "eth-ck",
  				      "ethstp";
  			clocks = <&rcc ETHMAC>,
  				 <&rcc ETHTX>,
Quoted 10 lines
Quoted 8 lines
Quoted 7 lines
arch/arm/boot/dts/stm32mp151.dtsi +1 -1
  				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
  				 <&rcc ETHSTP>;
  			st,syscon = <&syscfg 0x4>;
  			snps,mixed-burst;
--

2.24.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel