Skip to contentSkip to conversation

drm/amdkfd: Fix kfd_smi_event_process()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 15, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Fix kfd_smi_event_process()

The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL dereference on the next line.

Fixes 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
---
 drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c +1 -1
index 727a4ce29fe6..c27fd7aec1c3 100644
@@ -350,7 +350,7 @@ void kfd_smi_event_process(struct kfd_process_device *pdd, bool start)
 	struct amdgpu_task_info *task_info;
 	struct amdgpu_vm *avm;
 
-	if (pdd->drm_priv)
+	if (!pdd->drm_priv)
 		return;
 
 	avm = drm_priv_to_vm(pdd->drm_priv);
Signature · 1 line
2.47.2
#1 lore raw

Thanks for the fix, I had the same patch submitted yesterday.

Regards,
Eric

Quoted 22 lines · Dan Carpenter

The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL dereference on the next line.

Fixes 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
---
  drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c +1 -1
index 727a4ce29fe6..c27fd7aec1c3 100644
@@ -350,7 +350,7 @@ void kfd_smi_event_process(struct kfd_process_device *pdd, bool start)
  	struct amdgpu_task_info *task_info;
  	struct amdgpu_vm *avm;
 
-	if (pdd->drm_priv)
+	if (!pdd->drm_priv)
  		return;
 
  	avm = drm_priv_to_vm(pdd->drm_priv);