net: xdp: Directly use ida_alloc()/free()
Subsystems (4)
PATCH 1/1 net: xdp: Directly use ida_alloc()/free()
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .
--- net/xdp/xdp_umem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
net/xdp/xdp_umem.c +3 -3
@@ -57,7 +57,7 @@ static int xdp_umem_addr_map(struct xdp_umem *umem, struct page **pages,static void xdp_umem_release (struct xdp_umem *umem) { umem->zc = false; -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);xdp_umem_addr_unmap (umem);xdp_umem_unpin_pages (umem);
@@ -242,7 +242,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr)if (!umem)return ERR_PTR (-ENOMEM ); - err =ida_simple_get (&umem_ida,0 ,0 ,GFP_KERNEL ); + err =ida_alloc (&umem_ida,GFP_KERNEL );if (err <0 ) {kfree (umem);return ERR_PTR (err);
@@ -251,7 +251,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr) err =xdp_umem_reg (umem, mr);if (err) { -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);kfree (umem);return ERR_PTR (err); }
Signature · 1 line
2.25.1
Quoted 4 lines · keliu
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .Signed-off-by keliu <[email protected]>
For future AF_XDP related patches please specify the bpf-next tree in the patch subject (or bpf if it's a fix).
Thanks!
Quoted 38 lines
--- net/xdp/xdp_umem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)net/xdp/xdp_umem.c +3
-3@@ -57,7 +57,7 @@ static int xdp_umem_addr_map(struct xdp_umem *umem, struct page **pages,static void xdp_umem_release (struct xdp_umem *umem) { umem->zc = false; -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);xdp_umem_addr_unmap (umem);xdp_umem_unpin_pages (umem);@@ -242,7 +242,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr)if (!umem)return ERR_PTR (-ENOMEM ); - err =ida_simple_get (&umem_ida,0 ,0 ,GFP_KERNEL ); + err =ida_alloc (&umem_ida,GFP_KERNEL );if (err <0 ) {kfree (umem);return ERR_PTR (err);@@ -251,7 +251,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr) err =xdp_umem_reg (umem, mr);if (err) { -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);kfree (umem);return ERR_PTR (err); }Signature · 1 line
2.25.1
Jesper Dangaard Brouer
Acked-byQuoted 5 lines · Maciej Fijalkowski
Quoted 4 lines · keliu
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .Signed-off-by keliu <[email protected]>
Could you use your full name with capital letters?
Quoted 5 lines
Reviewed-by Maciej Fijalkowski <[email protected]>For future
AF_XDPrelated patches please specify the bpf-next tree in the patch subject (or bpf if it's a fix).
I agree.
Could you also take care of net/core/xdp.c ?
Patch LGTM
Quoted 39 lines
Quoted 38 lines
--- net/xdp/xdp_umem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)net/xdp/xdp_umem.c +3
-3@@ -57,7 +57,7 @@ static int xdp_umem_addr_map(struct xdp_umem *umem, struct page **pages,static void xdp_umem_release (struct xdp_umem *umem) { umem->zc = false; -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);xdp_umem_addr_unmap (umem);xdp_umem_unpin_pages (umem);@@ -242,7 +242,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr)if (!umem)return ERR_PTR (-ENOMEM ); - err =ida_simple_get (&umem_ida,0 ,0 ,GFP_KERNEL ); + err =ida_alloc (&umem_ida,GFP_KERNEL );if (err <0 ) {kfree (umem);return ERR_PTR (err);@@ -251,7 +251,7 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr) err =xdp_umem_reg (umem, mr);if (err) { -ida_simple_remove (&umem_ida, umem->id); +ida_free (&umem_ida, umem->id);kfree (umem);return ERR_PTR (err); }Signature · 1 line
2.25.1
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:
Quoted 7 lines · On Fri, 27 May 2022 06:46:09 +0000 you wrote:
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .Signed-off-by keliu <[email protected]>--- net/xdp/xdp_umem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- net: xdp: Directly use ida_alloc()/free()
https://git.kernel.org/bpf/bpf-next/c/1626f57f061c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html