Skip to contentSkip to conversation

tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume

PATCH In review Hersen Wu 4 participants 5 messages Apr 24, 2023

lore
Share & tools
lore

Hersen Wu

author
#0 lore raw

PATCH 1/1 tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume

at call back of igt_system_suspend_autoresume, linux kernel resume finish and in d0 state. but user mode components may not be fully out of sleep mode. add delay wait for system stable before issuing debugfs_hotplug_trigger.

---
 tests/amdgpu/amd_hotplug.c | 1 +
 1 file changed, 1 insertion(+)
tests/amdgpu/amd_hotplug.c +1 -0
index 736040a2..1c946ff8 100644
@@ -133,6 +133,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
 	if (suspend) {
 		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
 					      SUSPEND_TEST_NONE);
+		sleep(30);
 	}
 
 	/* Trigger hotplug and confirm reference image is the same. */
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume

== Series Details ==

== Series Details ==

Series: tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume
URL : https://patchwork.freedesktop.org/series/116891/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13054 -> IGTPW_8847
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_8847 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_8847, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/index.html

Participating hosts (38 -> 38)
------------------------------

Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8847:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_tlb:
- fi-apl-guc: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/fi-apl-guc/igt@i915_selftest@live@gt_tlb.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/fi-apl-guc/igt@i915_selftest@live@gt_tlb.html

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_module_load@load:
- {bat-mtlp-8}: [ABORT][3] ([i915#8361]) -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-mtlp-8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-mtlp-8/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8847 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][5] ([i915#6687] / [i915#7978])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-rpls-1/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@mman:
- bat-rpls-1: NOTRUN -> [TIMEOUT][9] ([i915#6794])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271]) +16 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/fi-kbl-soraka/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][13] ([i915#3546]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-adlp-9/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@migrate:
- bat-adlp-6: [DMESG-FAIL][14] ([i915#7699]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-adlp-6/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-adlp-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][16] ([i915#4983] / [i915#7911]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13054/bat-rpls-1/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/bat-rpls-1/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8361]: https://gitlab.freedesktop.org/drm/intel/issues/8361

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7266 -> IGTPW_8847

CI-20190529: 20190529
CI_DRM_13054: 8cabe2adb8e028197f9535daffd3d5ff98d51d8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8847: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/index.html
IGT_7266: 94411dd85f9ad6d76fb7b2097197122703a3914c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8847/index.html

#2 lore raw
In reply to Hersen Wu
Quoted 15 lines · Hersen Wu

at call back of igt_system_suspend_autoresume, linux kernel resume finish and in d0 state. but user mode components may not be fully out of sleep mode. add delay wait for system stable before issuing debugfs_hotplug_trigger.

---
  tests/amdgpu/amd_hotplug.c | 1 +
  1 file changed, 1 insertion(+)
tests/amdgpu/amd_hotplug.c +0 -0
index 736040a2..1c946ff8 100644

tests/amdgpu/amd_hotplug.c static void test_hotplug_basic(data_t *data, bool suspend) · line 136

Quoted 4 lines
tests/amdgpu/amd_hotplug.c +1 -0
@@ -133,6 +133,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
  	if (suspend) {
  		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
  					      SUSPEND_TEST_NONE);
+		sleep(30);

Do we need to wait all of this time? If so, why?

Quoted 3 lines
tests/amdgpu/amd_hotplug.c +0 -0
  	}
 
  	/* Trigger hotplug and confirm reference image is the same. */
author
#3 lore raw

[AMD Official Use Only - General]

After igt_system_suspend_autoresume is executed, Linux kernel should be out of sleep mode. By adding read power_state from /sys/class/drm/card0/device# cat power_state. Value is D0. This is already checked by reading amdgpu adev->in_suspend, value is false.

Some other components may not finish process for resume.

When batch run test case below,

igt@amdgpu/amd_hotplug@basic-suspend igt@amdgpu/amd_link_settings@link-training-configs igt@amdgpu/amd_mem_leak@connector-suspend-resume

igt@amdgpu/amd_hotplug@basic-suspend is executed, but the rest two test case are skipped.

I do not find method to check if all SW components are out of resume processing. The delay 30 seconds is safe value based on experiments. AMD IGT test list are executed 15 loops.

With delay 15 seconds, intermittent failure could still be captured.

Thanks!
Hersen

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]>
Sent: Monday, April 24, 2023 12:50 PM
To: Wu, Hersen <[email protected]>; [email protected]; Pillai, Aurabindo <[email protected]>; Hung, Alex <[email protected]>; Mahfooz, Hamza <[email protected]>
Subject: Re: [PATCH] [i-g-t] tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume

Quoted 15 lines · Hersen Wu

at call back of igt_system_suspend_autoresume, linux kernel resume finish and in d0 state. but user mode components may not be fully out of sleep mode. add delay wait for system stable before issuing debugfs_hotplug_trigger.

---
  tests/amdgpu/amd_hotplug.c | 1 +
  1 file changed, 1 insertion(+)
tests/amdgpu/amd_hotplug.c +0 -0
index 736040a2..1c946ff8 100644

tests/amdgpu/amd_hotplug.c static void test_hotplug_basic(data_t *data, bool suspend) · line 136

Quoted 4 lines
tests/amdgpu/amd_hotplug.c +1 -0
@@ -133,6 +133,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
  	if (suspend) {
  		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
  					      SUSPEND_TEST_NONE);
+		sleep(30);

Do we need to wait all of this time? If so, why?

Quoted 3 lines
tests/amdgpu/amd_hotplug.c +0 -0
  	}
 
  	/* Trigger hotplug and confirm reference image is the same. */
#4 lore raw
Quoted 10 lines · Hersen

[AMD Official Use Only - General]

After igt_system_suspend_autoresume is executed, Linux kernel should be out of sleep mode. By adding read power_state from /sys/class/drm/card0/device# cat power_state. Value is D0. This is already checked by reading amdgpu adev->in_suspend, value is false.

Some other components may not finish process for resume.

When batch run test case below,

Quoted 8 lines

igt@amdgpu/amd_hotplug@basic-suspend igt@amdgpu/amd_link_settings@link-training-configs igt@amdgpu/amd_mem_leak@connector-suspend-resume

igt@amdgpu/amd_hotplug@basic-suspend is executed, but the rest two test case are skipped.

I do not find method to check if all SW components are out of resume processing. The delay 30 seconds is safe value based on experiments.

There is no such suspend processing. The kernel just freezed/thaws userspace as a whole. Once the igt is running so is rest of userspace.

Quoted 47 lines

AMD IGT test list are executed 15 loops.

With delay 15 seconds, intermittent failure could still be captured.

Thanks!
Hersen

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]>
Sent: Monday, April 24, 2023 12:50 PM
To: Wu, Hersen <[email protected]>; [email protected]; Pillai, Aurabindo <[email protected]>; Hung, Alex <[email protected]>; Mahfooz, Hamza <[email protected]>
Subject: Re: [PATCH] [i-g-t] tests/amdgpu/amd_hotplug: add delay after igt_system_suspend_autoresume

Quoted 15 lines · Hersen Wu

at call back of igt_system_suspend_autoresume, linux kernel resume finish and in d0 state. but user mode components may not be fully out of sleep mode. add delay wait for system stable before issuing debugfs_hotplug_trigger.

---
  tests/amdgpu/amd_hotplug.c | 1 +
  1 file changed, 1 insertion(+)
tests/amdgpu/amd_hotplug.c +0 -0
index 736040a2..1c946ff8 100644

tests/amdgpu/amd_hotplug.c static void test_hotplug_basic(data_t *data, bool suspend) · line 136

Quoted 4 lines
tests/amdgpu/amd_hotplug.c +1 -0
@@ -133,6 +133,7 @@ static void test_hotplug_basic(data_t *data, bool suspend)
  	if (suspend) {
  		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
  					      SUSPEND_TEST_NONE);
+		sleep(30);

Do we need to wait all of this time? If so, why?

Quoted 3 lines
tests/amdgpu/amd_hotplug.c +0 -0
  	}
 
  	/* Trigger hotplug and confirm reference image is the same. */
Signature · 2 lines
Ville Syrjälä
Intel