afs: xattr: use scnprintf
Subsystems (2)
PATCH 1/1 afs: xattr: use scnprintf
sprintf and snprintf are fragile in future maintenance, switch to using scnprintf to ensure no accidental Use After Free conditions are introduced.
Signed-off-by Mark Salyzyn <[email protected]>
Cc David Howells <[email protected]>
Cc Jan Kara <[email protected]>
--- fs/afs/xattr.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
fs/afs/xattr.c +9 -7
@@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,break ;case 1 : data = buf; - dsize =snprintf (buf,sizeof (buf),"%u" , yacl->inherit_flag); + dsize =scnprintf (buf,sizeof (buf),"%u" , yacl->inherit_flag);break ;case 2 : data = buf; - dsize =snprintf (buf,sizeof (buf),"%u" , yacl->num_cleaned); + dsize =scnprintf (buf,sizeof (buf),"%u" , yacl->num_cleaned);break ;case 3 : data = yacl->vol_acl->data;
@@ -370,13 +370,15 @@ static int afs_xattr_get_fid(const struct xattr_handler *handler,/* The volume ID is 64-bit, the vnode ID is 96-bit and the * uniquifier is 32-bit. */ - len =sprintf (text,"%llx:" , vnode->fid.vid); + len =scnprintf (text,sizeof (text),"%llx:" , vnode->fid.vid);if (vnode->fid.vnode_hi) - len +=sprintf (text + len,"%x%016llx" , - vnode->fid.vnode_hi, vnode->fid.vnode); + len +=scnprintf (text + len,sizeof (text) - len,"%x%016llx" , + vnode->fid.vnode_hi, vnode->fid.vnode);else - len +=sprintf (text + len,"%llx" , vnode->fid.vnode); - len +=sprintf (text + len,":%x" , vnode->fid.unique); + len +=scnprintf (text + len,sizeof (text) - len,"%llx" , + vnode->fid.vnode); + len +=scnprintf (text + len,sizeof (text) - len,":%x" , + vnode->fid.unique);if (size ==0 )return len;
Signature · 1 line
2.24.0.rc1.363.gb1bccd3e3d-goog
Quoted 3 lines · Mark Salyzyn
sprintf and snprintf are fragile in future maintenance, switch to using scnprintf to ensure no accidental Use After Free conditions are introduced.
Urrrk Out of band stack access ...
-- Mark