Skip to contentSkip to conversation

drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

PATCH Applied Yicong Hui 3 participants 4 messages Apr 6 – Jun 2

Subsystems (4)
lore
Share & tools
lore

Yicong Hui

author
#0 lore raw

PATCH 1/1 drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

Fix the following W=1 kerneldoc warnings by adding the missing parameter descriptions for @phase0_identity and @nn_interpolation in dcss_scaler_filter_design() and @phase0_identity in dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

Fixes 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
---
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/imx/dcss/dcss-scaler.c +3 -0
index 32c3f46b21da..5c7f8d952ec1 100644
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
  * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
  * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
  * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output filter coefficients
  */
 static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
  * @src_length: length of input
  * @dst_length: length of output
  * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output coefficients
+ * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter
  */
 static void dcss_scaler_filter_design(int src_length, int dst_length,
 				      bool use_5_taps, bool phase0_identity,
Signature · 1 line
2.53.0
author
#1 lore raw
Quoted 28 lines · Yicong Hui

Fix the following W=1 kerneldoc warnings by adding the missing parameter descriptions for @phase0_identity and @nn_interpolation in dcss_scaler_filter_design() and @phase0_identity in dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

Fixes 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
---
  drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/imx/dcss/dcss-scaler.c +1 -0
index 32c3f46b21da..5c7f8d952ec1 100644
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
   * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
   * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
   * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
   * @coef: output filter coefficients
   */
  static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,

drivers/gpu/drm/imx/dcss/dcss-scaler.c static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps, · line 271

Quoted 9 lines
drivers/gpu/drm/imx/dcss/dcss-scaler.c +2 -0
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
   * @src_length: length of input
   * @dst_length: length of output
   * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
   * @coef: output coefficients
+ * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter
   */
  static void dcss_scaler_filter_design(int src_length, int dst_length,
  				      bool use_5_taps, bool phase0_identity,

Hello!

Is there any further feedback or progress on this patch?

Thank you!
Yicong

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Yicong Hui

Hi Yicong,

Quoted 11 lines · Yicong Hui

Fix the following W=1 kerneldoc warnings by adding the missing parameter descriptions for @phase0_identity and @nn_interpolation in dcss_scaler_filter_design() and @phase0_identity in dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

Fixes 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")

Sorry, I totally missed your patch... :/

Signature · 2 lines
Thanks,
Laurentiu
Applied
#3 lore raw
In reply to Yicong Hui
Quoted 10 lines · Yicong Hui

Fix the following W=1 kerneldoc warnings by adding the missing parameter descriptions for @phase0_identity and @nn_interpolation in dcss_scaler_filter_design() and @phase0_identity in dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

[...]

Applied to misc/kernel.git (drm-misc-fixes), thanks!

[1/1] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

      commit: ae0383e5a9a4b12d68c76c4769857def4665deff
Signature · 2 lines
Regards,
Liu Ying