usb: gadget: udc: clean up comments
Subsystems (5)
PATCH 1/1 usb: gadget: udc: clean up comments
SPDX
*.h use /* */ style comments
For double words, remove
with, also
Spelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamic
--- drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-)
drivers/usb/gadget/udc/amd5536udc.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller *
drivers/usb/gadget/udc/aspeed-vhub/core.c +1 -1
@@ -180,7 +180,7 @@ void ast_vhub_init_hw(struct ast_vhub *vhub)* We do *NOT* set the VHUB_CTRL_CLK_STOP_SUSPEND bit * to stop the logic clock during suspend because * it causes the registers to become inaccessible and -* we haven't yet figured out a good wayt to bring the +* we haven't yet figured out a good way to bring the * controller back into life to issue a wakeup. */
drivers/usb/gadget/udc/aspeed-vhub/ep0.c +1 -1
@@ -366,7 +366,7 @@ static int ast_vhub_ep0_queue(struct usb_ep* u_ep, struct usb_request *u_req,struct device *dev = &vhub->pdev->dev;unsigned long flags; -/* Paranoid cheks */ +/* Paranoid checks */ if (!u_req || (!u_req->complete && !req->internal)) {dev_warn (dev,"Bogus EP0 request ! u_req=%p\n" , u_req);if (u_req) {
drivers/usb/gadget/udc/aspeed-vhub/hub.c +1 -1
@@ -551,7 +551,7 @@ void ast_vhub_device_connect(struct ast_vhub *vhub, 0, true);/* -* If the hub is set to wakup the host on connection events +* If the hub is set to wakeup the host on connection events * then send a wakeup. */ if (vhub->wakeup_en)
drivers/usb/gadget/udc/aspeed-vhub/vhub.h +2 -2
@@ -23,9 +23,9 @@#define AST_VHUB_USBSTS 0x24/* USB Status Register */ #define AST_VHUB_EP_TOGGLE 0x28/* Programmable Endpoint Pool Data Toggle Value Set */ #define AST_VHUB_ISO_FAIL_ACC 0x2C/* Isochronous Transaction Fail Accumulator */ -#define AST_VHUB_EP0_CTRL 0x30/* Endpoint 0 Contrl/Status Register */ +#define AST_VHUB_EP0_CTRL 0x30/* Endpoint 0 Control/Status Register */ #define AST_VHUB_EP0_DATA 0x34/* Base Address of Endpoint 0 In/OUT Data Buffer Register */ -#define AST_VHUB_EP1_CTRL 0x38/* Endpoint 1 Contrl/Status Register */ +#define AST_VHUB_EP1_CTRL 0x38/* Endpoint 1 Control/Status Register */ #define AST_VHUB_EP1_STS_CHG 0x3C/* Endpoint 1 Status Change Bitmap Data */ #define AST_VHUB_SETUP0 0x80/* Root Device Setup Data Buffer0 */ #define AST_VHUB_SETUP1 0x84/* Root Device Setup Data Buffer1 */
drivers/usb/gadget/udc/at91_udc.c +1 -1
@@ -994,7 +994,7 @@ static const struct usb_gadget_ops at91_udc_ops = { .udc_stop = at91_stop,/* -* VBUS-powered devices may also also want to support bigger +* VBUS-powered devices may also want to support bigger * power budgets after an appropriate SET_CONFIGURATION. */ /* .vbus_power = at91_vbus_power, */
drivers/usb/gadget/udc/bdc/bdc_core.c +2 -2
@@ -296,7 +296,7 @@ static void bdc_mem_init(struct bdc *bdc, bool reinit)for (i =1 ; i < bdc->num_eps; ++i) bdc->bdc_ep_array[i]->flags =0 ; }else { -/* One time initiaization only */ +/* One time initialization only */ /* Enable status report function pointers */ bdc->sr_handler[0 ] = bdc_sr_xsf; bdc->sr_handler[1 ] = bdc_sr_uspc;
@@ -361,7 +361,7 @@ int bdc_reinit(struct bdc *bdc)return ret; } -/* Allocate all the dyanmic memory */ +/* Allocate all the dynamic memory */ static int bdc_mem_alloc (struct bdc *bdc) {u32 page_size;
drivers/usb/gadget/udc/core.c +2 -2
@@ -162,7 +162,7 @@ EXPORT_SYMBOL_GPL(usb_ep_disable);/** * usb_ep_alloc_request - allocate a request object to use with this endpoint -* @ep:the endpoint to be used with with the request +* @ep:the endpoint to be used with the request * @gfp_flags:GFP_* flags to use * * Request objects must be allocated with this call, since they normally
@@ -897,7 +897,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_request);/** * usb_gadget_giveback_request - give the request back to the gadget layer -* @ep: the endpoint to be used with with the request +* @ep: the endpoint to be used with the request * @req: the request being given back * * This is called by device controller drivers in order to return the
drivers/usb/gadget/udc/trace.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * udc.c - Core UDC Framework *
Signature · 1 line
2.27.0
Greg KH
maintainerQuoted 15 lines · Tom Rix
SPDX
*.h use /* */ style commentsFor double words, remove
with, alsoSpelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamicSigned-off-by Tom Rix <[email protected]>
Quoted 12 lines
--- drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Quoted 6 lines · Tom Rix
SPDX
*.h use /* */ style commentsFor double words, remove
with, also
Quoted 7 lines
Spelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamic
Something really wrong with indentation above.
...
Quoted 9 lines
drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +-
I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then.
...
drivers/usb/gadget/udc/amd5536udc.h
Quoted 4 lines
drivers/usb/gadget/udc/amd5536udc.h +0
-0* amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller
At the same time you may drop the filename(s) from the file(s) as this very one shows why it's good not to have a filename inside file.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 27 lines · Andy Shevchenko
Quoted 6 lines · Tom Rix
SPDX
*.h use /* */ style commentsFor double words, remove
with, alsoQuoted 7 lines
Spelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamicSomething really wrong with indentation above.
...
Quoted 9 lines
drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +-
Quoted 3 lines
I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then.
Yes, whatever folks want. I can split these.
I have been cleaning up the comments in other areas and am trying to strike a balance between too big of a patch vs peppering with many single changes.
Tom
Quoted 9 lines
...
drivers/usb/gadget/udc/amd5536udc.h line 3
Quoted 3 lines
drivers/usb/gadget/udc/amd5536udc.h +0
-0* amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller At the same time you may drop the filename(s) from the file(s) as this very one shows why it's good not to have a filename inside file.
Greg KH
maintainerQuoted 29 lines · Tom Rix
Quoted 27 lines · Andy Shevchenko
Quoted 6 lines · Tom Rix
SPDX
*.h use /* */ style commentsFor double words, remove
with, alsoQuoted 7 lines
Spelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamicSomething really wrong with indentation above.
...
Quoted 9 lines
drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +-
Quoted 8 lines
Quoted 3 lines
I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then.
Yes, whatever folks want. I can split these.
I have been cleaning up the comments in other areas and am trying to strike a balance between too big of a patch vs peppering with many single changes.
Patch series are much easier to review and is just as simple to apply as a single patch, so that makes it overall better for you to do.
thanks,
greg k-h
Quoted 32 lines · Greg KH
Quoted 31 lines · Tom Rix
Quoted 30 lines · Andy Shevchenko
Quoted 6 lines · Tom Rix
SPDX
*.h use /* */ style commentsFor double words, remove
with, alsoQuoted 7 lines
Spelling replacements
wayt to way
wakup to wakeup
Contrl to Control
cheks to checks
initiaization to initialization
dyanmic to dynamicSomething really wrong with indentation above.
...
Quoted 9 lines
drivers/usb/gadget/udc/amd5536udc.h | 2 +- drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- drivers/usb/gadget/udc/at91_udc.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- drivers/usb/gadget/udc/core.c | 4 ++-- drivers/usb/gadget/udc/trace.h | 2 +-I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then.
Quoted 6 lines
Quoted 4 lines
Yes, whatever folks want. I can split these.
I have been cleaning up the comments in other areas and am trying to strike a balance between too big of a patch vs peppering with many single changes.
Patch series are much easier to review and is just as simple to apply as a single patch, so that makes it overall better for you to do.
ok
Tom
Quoted 5 lines
thanks,
greg k-h