Skip to contentSkip to conversation

drm/gud: Fix missing include

PATCH In review Noralf Trønnes 2 participants 3 messages Dec 7, 2022 – Dec 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/gud: Fix missing include

Add missing vmalloc.h include.

Fixes c17d048609bf ("drm/gud: Use the shadow plane helper")
---
 drivers/gpu/drm/gud/gud_pipe.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/gud/gud_pipe.c +1 -0
index 62c43d3632d4..dc16a92625d4 100644
@@ -5,6 +5,7 @@
 
 #include <linux/lz4.h>
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic.h>

---
base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,

Signature · 1 line
Noralf Trønnes <[email protected]>
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi

Am 07.12.22 um 20:51 schrieb Noralf Trønnes via B4 Submission Endpoint:

Quoted 7 lines

From: Noralf Trønnes <[email protected]>

Add missing vmalloc.h include.

Fixes c17d048609bf ("drm/gud: Use the shadow plane helper")

The missing-vmalloc() error is a real classic. :( Some architectures declare the function and some don't.

Best regards
Thomas

Quoted 22 lines
---
  drivers/gpu/drm/gud/gud_pipe.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/gud/gud_pipe.c +1 -1
index 62c43d3632d4..dc16a92625d4 100644
@@ -5,6 +5,7 @@
 
  #include <linux/lz4.h>
  #include <linux/usb.h>
+#include <linux/vmalloc.h>
  #include <linux/workqueue.h>
 
  #include <drm/drm_atomic.h>
 
---

base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
#2 lore raw

Den 08.12.2022 09.15, skrev Thomas Zimmermann:

Quoted 5 lines

Hi

Am 07.12.22 um 20:51 schrieb Noralf Trønnes via B4 Submission Endpoint:

Quoted 2 lines

From: Noralf Trønnes <[email protected]>

Quoted 8 lines
Quoted 5 lines

Add missing vmalloc.h include.

Fixes c17d048609bf ("drm/gud: Use the shadow plane helper")

Thanks.

Quoted 3 lines

The missing-vmalloc() error is a real classic. :( Some architectures declare the function and some don't.

Yeah, I think I've seen this before. Good we have the bots to cover the corner cases.

Noralf.

Quoted 25 lines

Best regards
Thomas

Quoted 21 lines

---
  drivers/gpu/drm/gud/gud_pipe.c | 1 +

  1 file changed, 1 insertion(+)
drivers/gpu/drm/gud/gud_pipe.c +1 -1
index 62c43d3632d4..dc16a92625d4 100644
@@ -5,6 +5,7 @@
     #include <linux/lz4.h>
   #include <linux/usb.h>
+#include <linux/vmalloc.h>
   #include <linux/workqueue.h>
     #include <drm/drm_atomic.h>
 
---

base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,