Skip to contentSkip to conversation

kho: fix doc for kho_restore_pages()

PATCH Applied Tycho Andersen 3 participants 3 messages Jan 23 – Jan 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kho: fix doc for kho_restore_pages()

From: "Tycho Andersen (AMD)" <[email protected]>

This function returns NULL if kho_restore_page() returns NULL, which happens in a couple of corner cases. It never returns an error code.

---
 kernel/liveupdate/kexec_handover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/liveupdate/kexec_handover.c +1 -1
index d4482b6e3cae..4c38ea7987c8 100644
@@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
  * Restore a contiguous list of order 0 pages that was preserved with
  * kho_preserve_pages().
  *
- * Return: 0 on success, error code on failure
+ * Return: the first page on success, NULL on failure.
  */
 struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
 {

base-commit: c072629f05d7bca1148ab17690d7922a31423984

Signature · 1 line
2.52.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tycho Andersen

From: "Tycho Andersen (AMD)" <[email protected]>

This function returns NULL if kho_restore_page() returns NULL, which happens in a couple of corner cases. It never returns an error code.

Quoted 22 lines
---
 kernel/liveupdate/kexec_handover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/liveupdate/kexec_handover.c +1 -1
index d4482b6e3cae..4c38ea7987c8 100644
@@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
  * Restore a contiguous list of order 0 pages that was preserved with
  * kho_preserve_pages().
  *
- * Return: 0 on success, error code on failure
+ * Return: the first page on success, NULL on failure.
  */
 struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
 {

base-commit: c072629f05d7bca1148ab17690d7922a31423984

Signature · 1 line
2.52.0
Signature · 2 lines
Sincerely yours,
Mike.