Skip to contentSkip to conversation

dt-bindings: display: add devicetree bindings for pxa300-gcu

PATCH In review Daniel Mack 4 participants 7 messages Jul 4, 2018 – Jul 24, 2018

Subsystems (4)
Device tree bindings DRM drivers DRM misc Framebuffer layer
lore
Share & tools
lore

Daniel Mack

author
#0 lore raw

PATCH v2 1/2 dt-bindings: display: add devicetree bindings for pxa300-gcu

This patch adds the binding documentation for the pxa300 gcu.

Signed-off-by Daniel Mack <[email protected]>
---
 .../bindings/display/marvell,pxa300-gcu.txt     | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt
Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt new file +17 -0
new file mode 100644
index 000000000000..9cfae5c4e8ec
@@ -0,0 +1,17 @@
+PXA3xx GCU Controller
+---------------------
+
+Required properties:
+ - compatible : "marvell,pxa300-gcu"
+ - reg : should contain the register range (address and length).
+ - interrupts : Controller interrupt.
+ - clocks: phandle to the PXA specific input clock.
+
+Example for PXA300:
+
+	display-controller@54000000 {
+		compatible = "marvell,pxa300-gcu";
+		reg = <0x54000000 0x1000>;
+		interrupts = <39>;
+		clocks = <&clks CLK_PXA300_GCU>;
+	};
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/2 video: fbdev: pxa3xx_gcu: add devicetree bindings

Add a device tree match table for this hardware graphics acceleration driver so it can be used by pxa3xx boards booted with a devicetree.

Signed-off-by Daniel Mack <[email protected]>
---
 drivers/video/fbdev/pxa3xx-gcu.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/video/fbdev/pxa3xx-gcu.c +10 -0
index 0955622a1227..69cfb337c857 100644
@@ -44,6 +44,7 @@
 #include <linux/clk.h>
 #include <linux/fs.h>
 #include <linux/io.h>
+#include <linux/of.h>
 
 #include "pxa3xx-gcu.h"
 

@@ -703,11 +704,20 @@ static int pxa3xx_gcu_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id pxa3xx_gcu_of_match[] = {
+	{ .compatible = "marvell,pxa300-gcu", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, pxa3xx_gcu_of_match);
+#endif
+
 static struct platform_driver pxa3xx_gcu_driver = {
 	.probe	  = pxa3xx_gcu_probe,
 	.remove	 = pxa3xx_gcu_remove,
 	.driver	 = {
 		.name   = DRV_NAME,
+		.of_match_table = of_match_ptr(pxa3xx_gcu_of_match),
 	},
 };
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH v2 2/2] video: fbdev: pxa3xx_gcu: add devicetree bindings

In reply to Daniel Mack
Quoted 4 lines · Daniel Mack

Add a device tree match table for this hardware graphics acceleration driver so it can be used by pxa3xx boards booted with a devicetree.

Signed-off-by Daniel Mack <[email protected]>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#5 lore raw

Hi Bartlomiej,

Quoted 10 lines · Rob Herring
Quoted 7 lines · Daniel Mack

This patch adds the binding documentation for the pxa300 gcu.

Signed-off-by Daniel Mack <[email protected]>
---
  .../bindings/display/marvell,pxa300-gcu.txt     | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)

create mode 100644 Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt

Reviewed-by Rob Herring <[email protected]>

Can we take this through the pxa tree or do you want to merge it?

Thanks,
Daniel