Skip to contentSkip to conversation

Remove unnecessary __attribute__ ((packed))

PATCH In review Jan Blunck 2 participants 2 messages Jan 3, 2006 Afs filesystem

lore
Share & tools
lore

Jan Blunck

author
#0 lore raw

PATCH 2/3 Remove unnecessary __attribute__ ((packed))

Remove the unnecessary __attribute__ ((packed)) since the enum itself is packed and not the location of it in the structure.

 fs/afs/volume.h |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)
fs/afs/volume.h +1 -3
Index: linux-2.6/fs/afs/volume.h
===================================================================
@@ -18,8 +18,6 @@
 #include "kafsasyncd.h"
 #include "cache.h"
 
-#define __packed __attribute__((packed))
-
 typedef enum {
 	AFS_VLUPD_SLEEP,		/* sleeping waiting for update timer to fire */
 	AFS_VLUPD_PENDING,		/* on pending queue */
@@ -115,7 +113,7 @@ struct afs_volume
 	struct cachefs_cookie	*cache;		/* caching cookie */
 #endif
 	afs_volid_t		vid;		/* volume ID */
-	afs_voltype_t __packed	type;		/* type of volume */
+	afs_voltype_t		type;		/* type of volume */
 	char			type_force;	/* force volume type (suppress R/O -> R/W) */
 	unsigned short		nservers;	/* number of server slots filled */
 	unsigned short		rjservers;	/* number of servers discarded due to -ENOMEDIUM */
maintainer
#1 lore raw
Quoted 2 lines · Jan Blunck

Remove the unnecessary __attribute__ ((packed)) since the enum itself is packed and not the location of it in the structure.

Fair enough.

David