net: dsa: Add missing of_node_put() in dsa_port_parse_of
Subsystems (3)
PATCH 1/1 net: dsa: Add missing of_node_put() in dsa_port_parse_of
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done.
--- net/dsa/dsa2.c | 1 + 1 file changed, 1 insertion(+)
net/dsa/dsa2.c +1 -0
@@ -1436,6 +1436,7 @@ static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)const char *user_protocol; master =of_find_net_device_by_node (ethernet); +of_node_put (ethernet);if (!master)return -EPROBE_DEFER ;
Signature · 1 line
2.17.1
Paolo Abeni
maintainerQuoted 5 lines · Miaoqian Lin
The
device_nodepointer is returned byof_parse_phandle()with refcount incremented. We should useof_node_put()on it when done.Fixes 6d4e5c570c2d ("net: dsa: get port type at parse time")Signed-off-by Miaoqian Lin <[email protected]>
LGTM, thanks!
For the records, it looks like there is a similar issue in net/dsa/port.c: dsa_port_link_register_of().
Thanks!
Paolo
This patch was applied to netdev/net.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Wed, 16 Mar 2022 08:26:02 +0000 you wrote:
The
device_nodepointer is returned byof_parse_phandle()with refcount incremented. We should useof_node_put()on it when done.Fixes 6d4e5c570c2d ("net: dsa: get port type at parse time")Signed-off-by Miaoqian Lin <[email protected]>--- net/dsa/dsa2.c | 1 + 1 file changed, 1 insertion(+)
Here is the summary with links:
- net: dsa: Add missing of_node_put() in dsa_port_parse_of
https://git.kernel.org/netdev/net/c/cb0b430b4e3a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html