blk_t -> blk64_t in read_bitmaps().
PATCH 1/2 blk_t -> blk64_t in read_bitmaps().
e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was detecting a lot of "Block bitmap differences". This change makes them go away (there are are still more problems however: the run finds used blocks in one BLOCK_UNINIT group and a free block mismatch.)
--- lib/ext2fs/rw_bitmaps.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
lib/ext2fs/rw_bitmaps.c +3 -3
@@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)int csum_flag =0 ;int do_image = fs->flags &EXT2_FLAG_IMAGE_FILE ;unsigned int cnt; -blk_t blk; -blk_t blk_itr = fs->super->s_first_data_block; -blk_t blk_cnt; +blk64_t blk; +blk64_t blk_itr = fs->super->s_first_data_block; +blk64_t blk_cnt;ext2_ino_t ino_itr =1 ;ext2_ino_t ino_cnt;
Signature · 1 line
1.6.0.6
Quoted 6 lines · Nick Dokos
e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was detecting a lot of "Block bitmap differences". This change makes them go away (there are are still more problems however: the run finds used blocks in one
BLOCK_UNINITgroup and a free block mismatch.)Signed-off-by Nick Dokos <[email protected]>
Looks right to me as well.
Quoted 21 lines
--- lib/ext2fs/rw_bitmaps.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)lib/ext2fs/rw_bitmaps.c +3
-3@@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)int csum_flag =0 ;int do_image = fs->flags &EXT2_FLAG_IMAGE_FILE ;unsigned int cnt; -blk_t blk; -blk_t blk_itr = fs->super->s_first_data_block; -blk_t blk_cnt; +blk64_t blk; +blk64_t blk_itr = fs->super->s_first_data_block; +blk64_t blk_cnt;ext2_ino_t ino_itr =1 ;ext2_ino_t ino_cnt;
Quoted 6 lines · Nick Dokos
e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was detecting a lot of "Block bitmap differences". This change makes them go away (there are are still more problems however: the run finds used blocks in one
BLOCK_UNINITgroup and a free block mismatch.)Signed-off-by Nick Dokos <[email protected]>
Pulled and pushed.
-VAL
Quoted 24 lines
--- lib/ext2fs/rw_bitmaps.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)lib/ext2fs/rw_bitmaps.c +3
-3@@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)int csum_flag =0 ;int do_image = fs->flags &EXT2_FLAG_IMAGE_FILE ;unsigned int cnt; -blk_t blk; -blk_t blk_itr = fs->super->s_first_data_block; -blk_t blk_cnt; +blk64_t blk; +blk64_t blk_itr = fs->super->s_first_data_block; +blk64_t blk_cnt;ext2_ino_t ino_itr =1 ;ext2_ino_t ino_cnt;Signature · 1 line
1.6.0.6