Skip to contentSkip to conversation

3c59x: Add space around '='

PATCH In review [email protected] 2 participants 2 messages Jul 17, 2023 – Jul 18, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 3c59x: Add space around '='

Fix checkpatch warnings:

./drivers/net/ethernet/3com/3c59x.c:716: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV)

---
 drivers/net/ethernet/3com/3c59x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/3com/3c59x.c +0 -0
index 082388b..9aa3244 100644
@@ -713,8 +713,8 @@ static void window_set(struct vortex_private *vp, int window)
    Note that we deviate from the 3Com order by checking 10base2 before 

AUI.
*/
enum xcvr_types {

-    XCVR_10baseT=0, XCVR_AUI, XCVR_10baseTOnly, XCVR_10base2, XCVR_100baseTx,
-    XCVR_100baseFx, XCVR_MII=6, XCVR_NWAY=8, XCVR_ExtMII=9, XCVR_Default=10,
+    XCVR_10baseT = 0, XCVR_AUI, XCVR_10baseTOnly, XCVR_10base2, XCVR_100baseTx,
+    XCVR_100baseFx, XCVR_MII = 6, XCVR_NWAY = 8, XCVR_ExtMII = 9, XCVR_Default = 10,

};

static const struct media_table {

maintainer
#2 lore raw
Quoted 12 lines · On Mon, 17 Jul 2023 11:27:10 +0800 [email protected] wrote:

Fix checkpatch warnings:

./drivers/net/ethernet/3com/3c59x.c:716: ERROR: spaces required around that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around that '=' (ctx:VxV)

Networking does not accept checkpatch-based coding style fixes as others already pointed out. Plus your patches are broken (white space damaged), and you sent 10 of them before waiting for any feedback, please stop.

Signature · 1 line
pw-bot: reject