drm/radeon: Move assignment outside if condition
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 drm/radeon: Move assignment outside if condition
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by Ran Sun <[email protected]>
--- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_legacy_tv.c +4 -2
@@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder *encoder, }for (i =0 ; i <MAX_H_CODE_TIMING_LEN ; i++) { -if ((tv_dac->tv.h_code_timing[i] = hor_timing[i]) ==0 ) + tv_dac->tv.h_code_timing[i] = hor_timing[i]; +if (tv_dac->tv.h_code_timing[i] ==0 )break ; }for (i =0 ; i <MAX_V_CODE_TIMING_LEN ; i++) { -if ((tv_dac->tv.v_code_timing[i] = vert_timing[i]) ==0 ) + tv_dac->tv.v_code_timing[i] = vert_timing[i]; +if (tv_dac->tv.v_code_timing[i] ==0 )break ; }
Alex Deucher
AppliedApplied. Thanks!
Quoted 32 lines · On Sun, Jul 23, 2023 at 11:45 PM <[email protected]> wrote:
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by Ran Sun <[email protected]>--- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/radeon/radeon_legacy_tv.c +4
-2@@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder *encoder, }for (i =0 ; i <MAX_H_CODE_TIMING_LEN ; i++) { -if ((tv_dac->tv.h_code_timing[i] = hor_timing[i]) ==0 ) + tv_dac->tv.h_code_timing[i] = hor_timing[i]; +if (tv_dac->tv.h_code_timing[i] ==0 )break ; }for (i =0 ; i <MAX_V_CODE_TIMING_LEN ; i++) { -if ((tv_dac->tv.v_code_timing[i] = vert_timing[i]) ==0 ) + tv_dac->tv.v_code_timing[i] = vert_timing[i]; +if (tv_dac->tv.v_code_timing[i] ==0 )break ; }