Skip to contentSkip to conversation

dt-bindings: misc: convert pvpanic-mmio binding to YAML

PATCH In review Rohan Mithari 2 participants 2 messages May 29 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: misc: convert pvpanic-mmio binding to YAML

Convert the legacy pvpanic-mmio txt binding into YAML schema format for device tree validation support.

---
Changes in v2:
- Remove legacy txt binding
- Fix reg example format
- Add trailing newline
- Run checkpatch validation with --no-tree

---
 .../devicetree/bindings/misc/pvpanic-mmio.txt | 29 ----------------
 .../bindings/misc/qemu,pvpanic-mmio.yaml      | 34 +++++++++++++++++++
 2 files changed, 34 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
 create mode 100644 Documentation/devicetree/bindings/misc/qemu,pvpanic-mmio.yaml
Documentation/devicetree/bindings/misc/pvpanic-mmio.txt deleted +0 -29
deleted file mode 100644
index 985e90736780..000000000000
@@ -1,29 +0,0 @@
-* QEMU PVPANIC MMIO Configuration bindings
-
-QEMU's emulation / virtualization targets provide the following PVPANIC
-MMIO Configuration interface on the "virt" machine.
-type:
-
-- a read-write, 16-bit wide data register.
-
-QEMU exposes the data register to guests as memory mapped registers.
-
-Required properties:
-
-- compatible: "qemu,pvpanic-mmio".
-- reg: the MMIO region used by the device.
-  * Bytes 0x0  Write panic event to the reg when guest OS panics.
-  * Bytes 0x1  Reserved.
-
-Example:
-
-/ {
-        #size-cells = <0x2>;
-        #address-cells = <0x2>;
-
-        pvpanic-mmio@9060000 {
-                compatible = "qemu,pvpanic-mmio";
-                reg = <0x0 0x9060000 0x0 0x2>;
-        };
-};
-
Documentation/devicetree/bindings/misc/qemu,pvpanic-mmio.yaml new file +34 -0
new file mode 100644
index 000000000000..fe24bdcacc9c
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/misc/qemu,pvpanic-mmio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: QEMU PVPANIC MMIO device
+
+description:
+  QEMU provides a pvpanic MMIO interface for guest panic notification.
+
+maintainers:
+  - Peng Hao <[email protected]>
+
+properties:
+  compatible:
+    const: qemu,pvpanic-mmio
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pvpanic@9060000 {
+      compatible = "qemu,pvpanic-mmio";
+      reg = <0x9060000 0x2>;
+    };
+
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Rohan Mithari

Convert the legacy pvpanic-mmio txt binding into YAML schema format for device tree validation support.

Missing Sob.

Quoted 7 lines

---
Changes in v2:
- Remove legacy txt binding
- Fix reg example format
- Add trailing newline
- Run checkpatch validation with --no-tree

That's not how you run checkpatch. You generate patch and then run checkpatch on that. You need to read the submitting patches document. This cannot be vibe coded.

Best regards,
Krzysztof