arm64: dts: broadcom: bcm4908: describe internal switch
PATCH 1/1 arm64: dts: broadcom: bcm4908: describe internal switch
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
--- .../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++ .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++- 2 files changed, 135 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts +51 -0
@@ -44,6 +44,57 @@ brightness { }; }; +&ports { + port@0 { + label = "lan2"; + }; + + port@1 { + label = "lan1"; + }; + + port@2 { + label = "lan6"; + }; + + port@3 { + label = "lan5"; + }; + + /* External BCM53134S switch */ + port@7 { + label = "sw"; + reg = <7>; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; +}; + +&mdio { + /* lan8 */ + phy@0 { + reg = <0>; + }; + + /* lan7 */ + phy@1 { + reg = <1>; + }; + + /* lan4 */ + phy@2 { + reg = <2>; + }; + + /* lan3 */ + phy@3 { + reg = <3>; + }; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>;
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +84 -1
97 lines not on this page · raw message
Signature · 1 line
2.26.2
Quoted 92 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
Signed-off-by Rafał Miłecki <[email protected]>--- .../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++ .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++- 2 files changed, 135 insertions(+), 1 deletion(-)arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts +51
-0@@ -44,6 +44,57 @@ brightness { }; }; +&ports { + port@0 { + label = "lan2"; + }; + + port@1 { + label = "lan1"; + }; + + port@2 { + label = "lan6"; + }; + + port@3 { + label = "lan5"; + }; + + /* External BCM53134S switch */ + port@7 { + label = "sw"; + reg = <7>; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; +}; + +&mdio { + /* lan8 */ + phy@0 { + reg = <0>; + }; + + /* lan7 */ + phy@1 { + reg = <1>; + }; + + /* lan4 */ + phy@2 { + reg = <2>; + }; + + /* lan3 */ + phy@3 { + reg = <3>; + }; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>;arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +1
-1@@ -108,7 +108,7 @@ soc { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - ranges = <0x00 0x00 0x80000000 0x10000>; + ranges = <0x00 0x00 0x80000000 0xd0000>; usb@c300 { compatible = "generic-ehci";
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi usb@d000 { · line 135
Quoted 6 lines
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +3
-0@@ -130,6 +130,89 @@ usb@d000 { interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; + + switch@80000 { + compatible = "simple-mfd";
Should not this be simple-bus instead? That is what I used in the 7445 and 7278 Device Trees provided by the bootloader, and also what was in the sf2 example binding.
Quoted 84 lines
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +80
-0+ #size-cells = <1>; + #address-cells = <1>; + ranges = <0 0x80000 0x50000>; + + switch@0 { + compatible = "brcm,bcm4908-switch"; + reg = <0x0 0x40000>, + <0x40000 0x110>, + <0x40340 0x30>, + <0x40380 0x30>, + <0x40600 0x34>, + <0x40800 0x208>; + reg-names = "core", "reg", "intrl2_0", + "intrl2_1", "fcb", "acb"; + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; + brcm,num-gphy = <5>; + brcm,num-rgmii-ports = <2>; + + #address-cells = <1>; + #size-cells = <0>; + + ports: ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + phy-mode = "internal"; + phy-handle = <&phy8>; + }; + + port@1 { + reg = <1>; + phy-mode = "internal"; + phy-handle = <&phy9>; + }; + + port@2 { + reg = <2>; + phy-mode = "internal"; + phy-handle = <&phy10>; + }; + + port@3 { + reg = <3>; + phy-mode = "internal"; + phy-handle = <&phy11>; + }; + }; + }; + + mdio: mdio@405c0 { + compatible = "brcm,unimac-mdio"; + reg = <0x405c0 0x8>; + reg-names = "mdio"; + #size-cells = <1>; + #address-cells = <0>; + + phy8: phy@8 { + reg = <8>; + }; + + phy9: phy@9 { + reg = <9>; + }; + + phy10: phy@a { + reg = <10>; + }; + + phy11: phy@b { + reg = <11>; + }; + + phy12: phy@c { + reg = <12>; + }; + }; + }; }; bus@ff800000 {
Signature · 1 line
Florian
PATCH v2 1/1 arm64: dts: broadcom: bcm4908: describe internal switch
In reply to Rafał MiłeckiFrom: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
---
V2: Use simple-bus
--- .../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++ .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++- 2 files changed, 135 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts +51 -0
@@ -44,6 +44,57 @@ brightness { }; }; +&ports { + port@0 { + label = "lan2"; + }; + + port@1 { + label = "lan1"; + }; + + port@2 { + label = "lan6"; + }; + + port@3 { + label = "lan5"; + }; + + /* External BCM53134S switch */ + port@7 { + label = "sw"; + reg = <7>; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; +}; + +&mdio { + /* lan8 */ + phy@0 { + reg = <0>; + }; + + /* lan7 */ + phy@1 { + reg = <1>; + }; + + /* lan4 */ + phy@2 { + reg = <2>; + }; + + /* lan3 */ + phy@3 { + reg = <3>; + }; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>;
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +84 -1
97 lines not on this page · raw message
Signature · 1 line
2.26.2
PATCH 1/1 arm64: dts: broadcom: bcm4908: describe internal switch
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
---
Resending V2 with Signed-off-by included
V2: Use simple-bus
--- .../bcm4908/bcm4908-asus-gt-ac5300.dts | 51 +++++++++++ .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 85 ++++++++++++++++++- 2 files changed, 135 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts +51 -0
@@ -44,6 +44,57 @@ brightness { }; }; +&ports { + port@0 { + label = "lan2"; + }; + + port@1 { + label = "lan1"; + }; + + port@2 { + label = "lan6"; + }; + + port@3 { + label = "lan5"; + }; + + /* External BCM53134S switch */ + port@7 { + label = "sw"; + reg = <7>; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; +}; + +&mdio { + /* lan8 */ + phy@0 { + reg = <0>; + }; + + /* lan7 */ + phy@1 { + reg = <1>; + }; + + /* lan4 */ + phy@2 { + reg = <2>; + }; + + /* lan3 */ + phy@3 { + reg = <3>; + }; +}; + &nandcs { nand-ecc-strength = <4>; nand-ecc-step-size = <512>;
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +84 -1
97 lines not on this page · raw message
Signature · 1 line
2.26.2
Florian Fainelli
AppliedQuoted 10 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
---
Applied to devicetree-arm64/next, thanks!
--
Florian
Quoted 6 lines · Florian Fainelli
Quoted 5 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Quoted 7 lines
Quoted 5 lines
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
---Applied to devicetree-arm64/next, thanks!
You may need to pick a patch sent as
[PATCH V2x] arm64: dts: broadcom: bcm4908: describe internal switch instead.
V2x contains Signed-off-by which I missed in the V2.
Sorry for the inconvenience!
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 16 lines · Rafał Miłecki
Quoted 7 lines · Florian Fainelli
Quoted 5 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
BCM4908 has internal switch with 5 GPHYs. Ports 0 - 3 are always connected to the internal PHYs. Remaining ports depend on device setup.
Quoted 7 lines
Quoted 5 lines
Asus GT-AC5300 has an extra switch with its PHYs accessible using the internal MDIO.
CPU port and Ethernet interface remain to be documented.
---Applied to devicetree-arm64/next, thanks!
Quoted 7 lines
You may need to pick a patch sent as
[PATCH V2x] arm64: dts: broadcom: bcm4908: describe internal switch instead.V2x contains Signed-off-by which I missed in the V2.
Sorry for the inconvenience!
Yes I realized that but applied V2x and pushed it out thanks!
Signature · 6 lines
Florian _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel