Skip to contentSkip to conversation

docs: networking: phy: add missing space

PATCH Applied Casper Andersson 7 participants 8 messages Oct 4, 2022 – Oct 6, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: networking: phy: add missing space

Missing space between "pins'" and "strength"

---
 Documentation/networking/phy.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/networking/phy.rst +1 -1
index 06f4fcdb58b6..d11329a08984 100644
@@ -120,7 +120,7 @@ required delays, as defined per the RGMII standard, several options may be
 available:
 
 * Some SoCs may offer a pin pad/mux/controller capable of configuring a given
-  set of pins'strength, delays, and voltage; and it may be a suitable
+  set of pins' strength, delays, and voltage; and it may be a suitable
   option to insert the expected 2ns RGMII delay.
 
 * Modifying the PCB design to include a fixed delay (e.g: using a specifically
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 4 lines · Casper Andersson

Missing space between "pins'" and "strength"

---

The merge window has now started (after Linus tagged 6.0) and will last until he tags 6.1-rc1 (two weeks from now). During this time we'll not be taking any patches for net-next so please repost in around 2 weeks.

Thanks,

Paolo

#2 lore raw
Quoted 10 lines · Paolo Abeni
Quoted 4 lines · Casper Andersson

Missing space between "pins'" and "strength"

---

The merge window has now started (after Linus tagged 6.0) and will last until he tags 6.1-rc1 (two weeks from now). During this time we'll not be taking any patches for net-next so please repost in around 2 weeks.

It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?

Signature · 1 line
Florian
#3 lore raw
Quoted 7 lines · Florian Fainelli
Quoted 6 lines · Paolo Abeni
Quoted 4 lines · Casper Andersson

Missing space between "pins'" and "strength"

---

Quoted 6 lines
Quoted 4 lines

The merge window has now started (after Linus tagged 6.0) and will last until he tags 6.1-rc1 (two weeks from now). During this time we'll not be taking any patches for net-next so please repost in around 2 weeks.

It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?

I think jon will pick up this patch, maybe as -rc-worthy fixes.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
maintainer
#4 lore raw
Quoted 8 lines · Bagas Sanjaya
Quoted 7 lines · Florian Fainelli
Quoted 6 lines · Paolo Abeni
Quoted 4 lines · Casper Andersson

Missing space between "pins'" and "strength"

---

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

The merge window has now started (after Linus tagged 6.0) and will last until he tags 6.1-rc1 (two weeks from now). During this time we'll not be taking any patches for net-next so please repost in around 2 weeks.

It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?

I think jon will pick up this patch, maybe as -rc-worthy fixes.

The networking folks prefer to carry their own documentation patches, so I don't normally do that. I'd be happy to this time with a suitable ack.

But honestly, there is nothing urgent about this change, I'd say just wait until net-next is open.

jon

maintainer
#5 lore raw
Quoted 4 lines · On Wed, 05 Oct 2022 08:12:26 -0600 Jonathan Corbet wrote:
Quoted 3 lines · Bagas Sanjaya
Quoted 2 lines

It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?

Quoted 8 lines
Quoted 1 line

I think jon will pick up this patch, maybe as -rc-worthy fixes.

The networking folks prefer to carry their own documentation patches, so I don't normally do that. I'd be happy to this time with a suitable ack.

But honestly, there is nothing urgent about this change, I'd say just wait until net-next is open.

Sorry for the back and forth, the patch is waiting patchwork, we've just been unusually busy the last two days. We'll apply it soon.

Reviewed-by on v1 1/1
#6 lore raw
In reply to Casper Andersson

Documentation/networking/phy.rst required delays, as defined per the RGMII standard, several options may be · line 124

Quoted 6 lines · Casper Andersson

* Some SoCs may offer a pin pad/mux/controller capable of configuring a given

Documentation/networking/phy.rst +1 -1
-  set of pins'strength, delays, and voltage; and it may be a suitable
+  set of pins' strength, delays, and voltage; and it may be a suitable
   option to insert the expected 2ns RGMII delay.

Looks OK.

IMO, I would like to write the phrase as "... configuring a given set of pin parameters (strength, delays, and voltage) ...".

Regardless,

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#7 lore raw
In reply to Casper Andersson
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 6 lines · On Tue, 4 Oct 2022 09:32:42 +0200 you wrote:

Missing space between "pins'" and "strength"

---
 Documentation/networking/phy.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] docs: networking: phy: add missing space

    https://git.kernel.org/netdev/net/c/229a0027591c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html