doc: announce ethdev ABI change for rte_eth_dev_info.
PATCH 1/1 doc: announce ethdev ABI change for rte_eth_dev_info.
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
http://mails.dpdk.org/archives/dev/2018-September/110959.html
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)
doc/guides/rel_notes/deprecation.rst +12 -0
@@ -49,6 +49,18 @@ Deprecation Notices Target release for removal of the legacy API will be defined once most PMDs have switched to rte_flow. +* ethdev: Maximum and minimum MTU values vary between hardware devices. In + hardware agnostic DPDK applications access to such information would allow + a more accurate way of validating and setting supported MTU values on a per + device basis rather than using a defined default for all devices. To + resolve this, the following members will be added to ``rte_eth_dev_info``. + Note: these can be added to fit a hole in the existing structure for amd64 + but not for 32 bit, as such ABI change will occur as size of the structure + will increase. + + - Member ``uint16_t min_mtu`` the minimum MTU allowed. + - Member ``uint16_t max_mtu`` the maximum MTU allowed. + * pdump: As we changed to use generic IPC, some changes in APIs and structure are expected in subsequent release.
Signature · 1 line
2.13.6
Quoted 7 lines · Ian Stokes
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
Quoted 8 lines
http://mails.dpdk.org/archives/dev/2018-September/110959.html
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
Signed-off-by Ian Stokes <[email protected]>
Quoted 28 lines
--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +12
-0@@ -49,6 +49,18 @@ Deprecation Notices Target release for removal of the legacy API will be defined once most PMDs have switched to rte_flow. +* ethdev: Maximum and minimum MTU values vary between hardware devices. In + hardware agnostic DPDK applications access to such information would allow + a more accurate way of validating and setting supported MTU values on a per + device basis rather than using a defined default for all devices. To + resolve this, the following members will be added to ``rte_eth_dev_info``. + Note: these can be added to fit a hole in the existing structure for amd64 + but not for 32 bit, as such ABI change will occur as size of the structure + will increase. + + - Member ``uint16_t min_mtu`` the minimum MTU allowed. + - Member ``uint16_t max_mtu`` the maximum MTU allowed. + * pdump: As we changed to use generic IPC, some changes in APIs and structure are expected in subsequent release.
Thomas Monjalon
Acked-by22/11/2018 13:11, Ferruh Yigit:
Quoted 10 lines · Ian Stokes
Quoted 9 lines
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
http://mails.dpdk.org/archives/dev/2018-September/110959.html
Quoted 8 lines
Quoted 6 lines
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
Signed-off-by Ian Stokes <[email protected]>Acked-by Ferruh Yigit <[email protected]>
[...]
Quoted 12 lines
Quoted 12 lines
doc/guides/rel_notes/deprecation.rst +12
-0+* ethdev: Maximum and minimum MTU values vary between hardware devices. In + hardware agnostic DPDK applications access to such information would allow + a more accurate way of validating and setting supported MTU values on a per + device basis rather than using a defined default for all devices. To + resolve this, the following members will be added to ``rte_eth_dev_info``. + Note: these can be added to fit a hole in the existing structure for amd64 + but not for 32 bit, as such ABI change will occur as size of the structure + will increase. + + - Member ``uint16_t min_mtu`` the minimum MTU allowed. + - Member ``uint16_t max_mtu`` the maximum MTU allowed. +
Thomas Monjalon
Applied22/11/2018 18:15, Thomas Monjalon:
Quoted 16 lines
22/11/2018 13:11, Ferruh Yigit:
Quoted 15 lines · Ian Stokes
Quoted 14 lines
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
http://mails.dpdk.org/archives/dev/2018-September/110959.html
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Ian Stokes <[email protected]>Acked-by Ferruh Yigit <[email protected]>Acked-by Thomas Monjalon <[email protected]>Acked-by Andrew Rybchenko <[email protected]>
Applied
Quoted 33 lines · Ian Stokes
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
http://mails.dpdk.org/archives/dev/2018-September/110959.html
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
Signed-off-by Ian Stokes <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+)doc/guides/rel_notes/deprecation.rst +5
-0@@ -49,6 +49,18 @@ Deprecation Notices Target release for removal of the legacy API will be defined once most PMDs have switched to rte_flow. +* ethdev: Maximum and minimum MTU values vary between hardware devices. In + hardware agnostic DPDK applications access to such information would allow + a more accurate way of validating and setting supported MTU values on a per + device basis rather than using a defined default for all devices. To + resolve this, the following members will be added to ``rte_eth_dev_info``.
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 66
Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +7
-0+ Note: these can be added to fit a hole in the existing structure for amd64 + but not for 32 bit, as such ABI change will occur as size of the structure + will increase. + + - Member ``uint16_t min_mtu`` the minimum MTU allowed. + - Member ``uint16_t max_mtu`` the maximum MTU allowed. + * pdump: As we changed to use generic IPC, some changes in APIs and structure are expected in subsequent release.
cc'ed a few more folks.
Andrew Rybchenko
Acked-byQuoted 8 lines · Ferruh Yigit
Quoted 7 lines · Ian Stokes
Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a per device basis rather than using a defined default for all devices.
The following solution was proposed:
Quoted 8 lines
Quoted 8 lines
http://mails.dpdk.org/archives/dev/2018-September/110959.html
This patch adds a depreciation notice for ``rte_eth_dev_info`` as new members will be added to represent min and max MTU values. These can be added to fit a hole in the existing structure for amd64 but not for 32 bit, as such ABI change will occur as size of the structure will be impacted.
Signed-off-by Ian Stokes <[email protected]>