Skip to contentSkip to conversation

watchdog: Set watchdog_module in default config

PATCH In review Wadim Egorov 2 participants 6 messages Jul 19, 2024 – Aug 2, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: Set watchdog_module in default config

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
 meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/watchdog/watchdog-config/watchdog.default +1 -0
index 647d5abca5bd..cee5fdc2b6f7 100644
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1
 run_watchdog=1
+watchdog_module=none
Signature · 1 line
2.25.1
#1 lore raw

Is this also an issue in master? If so, then this will need to be submitted first for master and then I can backport.

Steve

Quoted 32 lines · Wadim Egorov via lists.openembedded.org

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
 meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/watchdog/watchdog-config/watchdog.default +1 -1
index 647d5abca5bd..cee5fdc2b6f7 100644
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1
 run_watchdog=1
+watchdog_module=none
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202250): https://lists.openembedded.org/g/openembedded-core/message/202250
Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 3 lines · Steve Sakoman

Is this also an issue in master? If so, then this will need to be submitted first for master and then I can backport.

Yes, do you want me to resend without the scarthgap tag? This patch also applies to master.

Quoted 38 lines

Steve

Quoted 28 lines · Wadim Egorov via lists.openembedded.org

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get
rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +

1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default index 647d5abca5bd..cee5fdc2b6f7 100644

meta/recipes-extended/watchdog/watchdog-config/watchdog.default +0 -0
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1

run_watchdog=1
+watchdog_module=none
--
2.25.1

#3 lore raw
Quoted 8 lines · Wadim Egorov via lists.openembedded.org

On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:

Is this also an issue in master? If so, then this will need to be submitted first for master and then I can backport.

Yes, do you want me to resend without the scarthgap tag? This patch also applies to master.

I see you sent it for master, thanks! I'll backport when it hits master.

Steve

Quoted 36 lines

On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via lists.openembedded.org <[email protected]> wrote:

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +

1 file changed, 1 insertion(+)
meta/recipes-extended/watchdog/watchdog-config/watchdog.default +0 -0
index 647d5abca5bd..cee5fdc2b6f7 100644
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1

run_watchdog=1
+watchdog_module=none
--
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw

Am 22.07.24 um 17:25 schrieb Steve Sakoman:

Quoted 6 lines
Quoted 3 lines · Wadim Egorov via lists.openembedded.org

On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:

Quoted 7 lines
Quoted 5 lines

Is this also an issue in master? If so, then this will need to be submitted first for master and then I can backport.

Yes, do you want me to resend without the scarthgap tag? This patch also applies to master.

I see you sent it for master, thanks! I'll backport when it hits master.

FYI: Just made it into master,

7a824eded561 ("watchdog: Set watchdog_module in default config")

Quoted 39 lines

Steve

Quoted 36 lines

On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via lists.openembedded.org <[email protected]> wrote:

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +

1 file changed, 1 insertion(+)
meta/recipes-extended/watchdog/watchdog-config/watchdog.default +0 -0
index 647d5abca5bd..cee5fdc2b6f7 100644
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1

run_watchdog=1
+watchdog_module=none
--
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#5 lore raw
Quoted 13 lines · Wadim Egorov

Am 22.07.24 um 17:25 schrieb Steve Sakoman:

Quoted 9 lines
Quoted 6 lines · Wadim Egorov via lists.openembedded.org

On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:

Is this also an issue in master? If so, then this will need to be submitted first for master and then I can backport.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Yes, do you want me to resend without the scarthgap tag? This patch also applies to master.

I see you sent it for master, thanks! I'll backport when it hits master.

FYI: Just made it into master,

7a824eded561 ("watchdog: Set watchdog_module in default config")

I saw that! I have it in my scarthgap test queue now.

Steve

Quoted 40 lines
Quoted 40 lines

Steve

Quoted 36 lines

On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via lists.openembedded.org <[email protected]> wrote:

systemd started to warn about used but unset environment variables. Let us set watchdog_module=none which is used by the watchdog.service to get rid of the following warning:

watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

---
meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +

1 file changed, 1 insertion(+)
meta/recipes-extended/watchdog/watchdog-config/watchdog.default +0 -0
index 647d5abca5bd..cee5fdc2b6f7 100644
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1

run_watchdog=1
+watchdog_module=none
--
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-