arm64: dts: rockchip: add regulator-enable-ramp-delay to RK860-0/-2/-3 regulators
Subsystems (2)
Heiko Stuebner
maintainerPATCH v2 1/1 arm64: dts: rockchip: add regulator-enable-ramp-delay to RK860-0/-2/-3 regulators
The RK860-0/-1/-2/-3 regulators are used on rk3588 boards in addition to the main pmic, to supply components like the big cpu-clusters and npu.
So far nobody had a use-case for turning these off. The supplies for the big cpu-clusters are on by default and those clusters normally are not completely turned off during runtime.
This changed with the new Rocket driver for the NPU, which does use runtime-pm and thus does turn off and on the NPU's supply regulator as needed. This regulator is also needed to run to actually turn on the power-domain for the NPU.
If the rocket driver now runtime-suspends while running a load and then runtime-resumes again, hangs can be observed with messages like
rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'nputop' on, val=0
A way to "fix" that issue when it happens, is to set the regulator to always-on. This suggests that the power-domain is trying to get power from the regulator before it is ready to deliver power.
And in fact the datasheet for the regulator defines an "Internal soft-start time" characteristic. For a target output voltage of 1.0V the _typical_ time to reach at least 92% of the output, is given as 260uS.
That means the time is dependent on the target voltage (up to 1.5V for the type) and also the rest of the board design.
So add a regulator-enable-ramp-delay to all rk860-2/-3 nodes we have in mainline right now. I've chosen 500uS to be on the safe side, as 260uS is the "typical" value for 1.0V and sadly no max value is given in the datasheet.
This adds the property to all rk8600, rk8602 and rk8603 occurences that are in mainline as of 6.16-rc1. There is currently no rk8601 used in any in-kernel devicetree.
---
changes in v2:
- also adapt rk8600 in rk3566-radxa-zero-3 (Quentin)
- reword commit description to be easier to understand (Quentin)
arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-armsom-lm7.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-common.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-fet3588-c.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-firefly-icore-3588q.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-orangepi-5.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 +++ arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 3 +++ 28 files changed, 74 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi +1 -0
@@ -424,6 +424,7 @@ vdd_cpu: regulator@40 { regulator-name = "vdd_cpu"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1390000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +3 -0
@@ -219,6 +219,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -236,6 +237,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -264,6 +266,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-armsom-lm7.dtsi +2 -0
@@ -86,6 +86,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -103,6 +104,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts +2 -0
@@ -212,6 +212,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -229,6 +230,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi +3 -0
@@ -152,6 +152,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -169,6 +170,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -190,6 +192,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6a-common.dtsi +2 -0
@@ -98,6 +98,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -115,6 +116,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-fet3588-c.dtsi +3 -0
@@ -154,6 +154,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -171,6 +172,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -194,6 +196,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-firefly-core-3588j.dtsi +3 -0
@@ -56,6 +56,7 @@ vdd_cpu_big0_s0: regulator@42 { fcs,suspend-voltage-selector = <1>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-name = "vdd_cpu_big0_s0";
@@ -74,6 +75,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -96,6 +98,7 @@ vdd_npu_s0: vdd_npu_mem_s0: regulator@42 { fcs,suspend-voltage-selector = <1>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-name = "vdd_npu_s0";
arch/arm64/boot/dts/rockchip/rk3588-firefly-icore-3588q.dtsi +3 -0
@@ -56,6 +56,7 @@ vdd_cpu_big0_s0: regulator@42 { fcs,suspend-voltage-selector = <1>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-name = "vdd_cpu_big0_s0";
@@ -73,6 +74,7 @@ vdd_cpu_big1_s0: regulator@43 { fcs,suspend-voltage-selector = <1>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-name = "vdd_cpu_big1_s0";
@@ -96,6 +98,7 @@ vdd_npu_s0: vdd_npu_mem_s0: regulator@42 { fcs,suspend-voltage-selector = <1>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-name = "vdd_npu_s0";
arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588.dtsi +3 -0
@@ -146,6 +146,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -163,6 +164,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -184,6 +186,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dts +2 -0
@@ -241,6 +241,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -258,6 +259,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts +3 -0
@@ -394,6 +394,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
@@ -411,6 +412,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -505,6 +507,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi +3 -0
@@ -411,6 +411,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -428,6 +429,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -449,6 +451,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5.dtsi +2 -0
@@ -230,6 +230,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -247,6 +248,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts +3 -0
@@ -307,6 +307,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -324,6 +325,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -347,6 +349,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi +2 -0
@@ -281,6 +281,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -298,6 +299,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +3 -0
@@ -198,6 +198,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
@@ -270,6 +271,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -287,6 +289,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts +2 -0
@@ -232,6 +232,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -249,6 +250,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi +3 -0
@@ -133,6 +133,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -150,6 +151,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -173,6 +175,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts +3 -0
@@ -251,6 +251,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -268,6 +269,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -289,6 +291,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts +3 -0
@@ -470,6 +470,7 @@ vdd_cpu_big0_s0: regulator@42 { compatible = "rockchip,rk8602"; reg = <0x42>; fcs,suspend-voltage-selector = <1>; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <1050000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_cpu_big0_s0";
@@ -485,6 +486,7 @@ vdd_cpu_big1_s0: regulator@43 { compatible = "rockchip,rk8603", "rockchip,rk8602"; reg = <0x43>; fcs,suspend-voltage-selector = <1>; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <1050000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_cpu_big1_s0";
@@ -504,6 +506,7 @@ vdd_npu_s0: regulator@42 { compatible = "rockchip,rk8602"; reg = <0x42>; fcs,suspend-voltage-selector = <1>; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <950000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_npu_s0";
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +3 -0
@@ -296,6 +296,7 @@ vdd_cpu_big0_s0: regulator@42 { reg = <0x42>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <1050000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_cpu_big0_s0";
@@ -313,6 +314,7 @@ vdd_cpu_big1_s0: regulator@43 { reg = <0x43>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <1050000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_cpu_big1_s0";
@@ -334,6 +336,7 @@ vdd_npu_s0: regulator@42 { reg = <0x42>; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-max-microvolt = <950000>; regulator-min-microvolt = <550000>; regulator-name = "vdd_npu_s0";
arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts +2 -0
@@ -233,6 +233,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -250,6 +251,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6.dtsi +3 -0
@@ -267,6 +267,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -284,6 +285,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -303,6 +305,7 @@ vdd_npu_s0: regulator@42 { reg = <0x42>; fcs,suspend-voltage-selector = <1>; regulator-name = "vdd_npu_s0"; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dts +3 -0
@@ -280,6 +280,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -297,6 +298,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -318,6 +320,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi +3 -0
@@ -217,6 +217,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -234,6 +235,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -255,6 +257,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +3 -0
@@ -195,6 +195,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -212,6 +213,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -233,6 +235,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +3 -0
@@ -294,6 +294,7 @@ vdd_cpu_big0_s0: regulator@42 { regulator-name = "vdd_cpu_big0_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -311,6 +312,7 @@ vdd_cpu_big1_s0: regulator@43 { regulator-name = "vdd_cpu_big1_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <1050000>; regulator-ramp-delay = <2300>;
@@ -339,6 +341,7 @@ vdd_npu_s0: regulator@42 { regulator-name = "vdd_npu_s0"; regulator-always-on; regulator-boot-on; + regulator-enable-ramp-delay = <500>; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; regulator-ramp-delay = <2300>;
Signature · 1 line
2.47.2
Quoted 26 lines · Heiko Stuebner
The RK860-0/-1/-2/-3 regulators are used on rk3588 boards in addition to the main pmic, to supply components like the big cpu-clusters and npu.
So far nobody had a use-case for turning these off. The supplies for the big cpu-clusters are on by default and those clusters normally are not completely turned off during runtime.
This changed with the new Rocket driver for the NPU, which does use runtime-pm and thus does turn off and on the NPU's supply regulator as needed. This regulator is also needed to run to actually turn on the power-domain for the NPU.
If the rocket driver now runtime-suspends while running a load and then runtime-resumes again, hangs can be observed with messages like
rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'nputop' on, val=0
A way to "fix" that issue when it happens, is to set the regulator to always-on. This suggests that the power-domain is trying to get power from the regulator before it is ready to deliver power.
And in fact the datasheet for the regulator defines an "Internal soft-start time" characteristic. For a target output voltage of 1.0V the _typical_ time to reach at least 92% of the output, is given as 260uS.
Quoted 7 lines
That means the time is dependent on the target voltage (up to 1.5V for the type) and also the rest of the board design.
So add a regulator-enable-ramp-delay to all rk860-2/-3 nodes we have in mainline right now. I've chosen 500uS to be on the safe side, as 260uS is the "typical" value for 1.0V and sadly no max value is given in the datasheet.
Since these are characteristics of the PMIC, I wonder if it makes more sense to put them in the driver? At least that's what we've done with a similar fix for the AXP PMICs.
ChenYu
Quoted 4 lines
This adds the property to all rk8600, rk8602 and rk8603 occurences that are in mainline as of 6.16-rc1. There is currently no rk8601 used in any in-kernel devicetree.
Heiko Stübner
maintainerAm Freitag, 6. Juni 2025, 04:17:53 Mitteleuropäische Sommerzeit schrieb Chen-Yu Tsai:
Quoted 30 lines · Heiko Stuebner
Quoted 29 lines
The RK860-0/-1/-2/-3 regulators are used on rk3588 boards in addition to the main pmic, to supply components like the big cpu-clusters and npu.
So far nobody had a use-case for turning these off. The supplies for the big cpu-clusters are on by default and those clusters normally are not completely turned off during runtime.
This changed with the new Rocket driver for the NPU, which does use runtime-pm and thus does turn off and on the NPU's supply regulator as needed. This regulator is also needed to run to actually turn on the power-domain for the NPU.
If the rocket driver now runtime-suspends while running a load and then runtime-resumes again, hangs can be observed with messages like
rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'nputop' on, val=0
A way to "fix" that issue when it happens, is to set the regulator to always-on. This suggests that the power-domain is trying to get power from the regulator before it is ready to deliver power.
And in fact the datasheet for the regulator defines an "Internal soft-start time" characteristic. For a target output voltage of 1.0V the _typical_ time to reach at least 92% of the output, is given as 260uS.
That means the time is dependent on the target voltage (up to 1.5V for the type) and also the rest of the board design.
Quoted 8 lines
Quoted 4 lines
So add a regulator-enable-ramp-delay to all rk860-2/-3 nodes we have in mainline right now. I've chosen 500uS to be on the safe side, as 260uS is the "typical" value for 1.0V and sadly no max value is given in the datasheet.
Since these are characteristics of the PMIC, I wonder if it makes more sense to put them in the driver? At least that's what we've done with a similar fix for the AXP PMICs.
yeah - definitly.
After sending this v2 yesterday, I re-read Quentin's comment on v1 and finally understood the meaning - which was the same, that the driver might be a nicer place for default values.
So yesterday evening I did parse the datasheets of all the regulator variants to get the relevant (and different) startup times.
Hopefully I'll get this done and sent out before lunch today :-) .
Heiko