Skip to contentSkip to conversation

arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay

PATCH Applied Leonidas P. Papadakos 2 participants 4 messages Feb 28, 2019 – Mar 6, 2019 2 messages not in the archive

Subsystems (2)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay

The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

A similar patch was merged for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly.

---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +2 -2
index 33c44e857..0e34354b2 100644
@@ -108,8 +108,8 @@
 	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;
-	tx_delay = <0x25>;
-	rx_delay = <0x11>;
+	tx_delay = <0x24>;
+	rx_delay = <0x18>;
 	status = "okay";
 };
 
Signature · 1 line
2.21.0

A message that is not in the archive (sent off-list or not yet received): 20190228222923.30418-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P. Papadakos:

Quoted 11 lines

The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

A similar patch was merged for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly.

applied as fix for the 5.1-rc cycle starting in about 2 weeks.

Thanks
Heiko

#3 lore raw

Στις Κυρ, 3 Μαρ, 2019 at 4:10 ΜΜ, ο/η Heiko Stuebner <[email protected]> έγραψε:

Quoted 12 lines

Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P. Papadakos:

Quoted 11 lines

The rk3328-roc-cc board exhibits tx stability issues with large
packets,
as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

A similar patch was merged for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly.

Quoted 8 lines
Quoted 1 line

applied as fix for the 5.1-rc cycle starting in about 2 weeks.

Thanks
Heiko

It seems like the delays for the rk3328-roc-cc should be like this:

	tx_delay = <0x28>;
	rx_delay = <0x16>;

What should I do? Make a new patch? If so, what tree do I base it on?

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Hi,

Am Mittwoch, 6. März 2019, 02:36:59 CET schrieb Leonidas P. Papadakos:

Quoted 23 lines

Στις Κυρ, 3 Μαρ, 2019 at 4:10 ΜΜ, ο/η Heiko Stuebner

<[email protected]> έγραψε:

Quoted 20 lines

Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P.

Papadakos:

Quoted 7 lines

The rk3328-roc-cc board exhibits tx stability issues with large

packets,

as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

Quoted 7 lines

A similar patch was merged for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly.

applied as fix for the 5.1-rc cycle starting in about 2 weeks.

Quoted 7 lines
Quoted 2 lines

Thanks
Heiko

It seems like the delays for the rk3328-roc-cc should be like this:

	tx_delay = <0x28>;
	rx_delay = <0x16>;

What should I do? Make a new patch? If so, what tree do I base it on?

yeah just make a new patch, replacing the old one. The original patch is targeted at 5.2, so is sitting in a temporary branch right now - so replacing the whole patch it is possible without hickups right now.

Heiko

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip