ARM: dts: rockchip: Cleanup style around assignment operator
Subsystems (2)
PATCH 1/2 ARM: dts: rockchip: Cleanup style around assignment operator
Use a space before and after assignment operator to have consistent style.
--- arch/arm/boot/dts/rk3036.dtsi | 2 +- arch/arm/boot/dts/rk3288-evb.dtsi | 2 +- arch/arm/boot/dts/rk3288-tinker.dtsi | 12 ++++++------ arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)
arch/arm/boot/dts/rk3036.dtsi +1 -1
@@ -484,7 +484,7 @@ compatible = "rockchip,rockchip-spi"; reg = <0x20074000 0x1000>; interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; - clocks =<&cru PCLK_SPI>, <&cru SCLK_SPI>; + clocks = <&cru PCLK_SPI>, <&cru SCLK_SPI>; clock-names = "apb-pclk","spi_pclk"; dmas = <&pdma 8>, <&pdma 9>; dma-names = "tx", "rx";
arch/arm/boot/dts/rk3288-evb.dtsi +1 -1
@@ -97,7 +97,7 @@ }; panel: panel { - compatible ="lg,lp079qx1-sp0v", "simple-panel"; + compatible = "lg,lp079qx1-sp0v", "simple-panel"; backlight = <&backlight>; enable-gpios = <&gpio7 RK_PA4 GPIO_ACTIVE_HIGH>; pinctrl-0 = <&lcd_cs>;
arch/arm/boot/dts/rk3288-tinker.dtsi +6 -6
@@ -47,13 +47,13 @@ compatible = "gpio-leds"; act-led { - gpios=<&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>; - linux,default-trigger="mmc0"; + gpios = <&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "mmc0"; }; heartbeat-led { - gpios=<&gpio1 RK_PD1 GPIO_ACTIVE_HIGH>; - linux,default-trigger="heartbeat"; + gpios = <&gpio1 RK_PD1 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; }; pwr-led {
@@ -443,7 +443,7 @@ &saradc { vref-supply = <&vcc18_ldo1>; - status ="okay"; + status = "okay"; }; &sdmmc {
@@ -516,7 +516,7 @@ }; &usb_otg { - status= "okay"; + status = "okay"; }; &vopb {
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +1 -1
@@ -86,7 +86,7 @@ }; panel: panel { - compatible ="innolux,n116bge", "simple-panel"; + compatible = "innolux,n116bge", "simple-panel"; status = "okay"; power-supply = <&vcc33_lcd>; backlight = <&backlight>;
Signature · 1 line
2.17.1
PATCH 2/2 ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
Fix DTC warning:
arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/rk3288-veyron.dtsi +1 -1
@@ -18,7 +18,7 @@ * The default coreboot on veyron devices ignores memory@0 nodes * and would instead create another memory node. */ - memory { + memory@0 { device_type = "memory"; reg = <0x0 0x0 0x0 0x80000000>; };
Signature · 1 line
2.17.1
Heiko Stuebner
maintainerRe: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
Hi Krzysztof,
Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
Quoted 4 lines
Fix DTC warning:
arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
please see the comment directly above the memory node on why that needs to stay that way. So no, we'll keep the veyron memory node as is.
Heiko
Quoted 19 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/rk3288-veyron.dtsi +1
-1@@ -18,7 +18,7 @@ * The default coreboot on veyron devices ignores memory@0 nodes * and would instead create another memory node. */ - memory { + memory@0 { device_type = "memory"; reg = <0x0 0x0 0x0 0x80000000>; };
Re: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
Quoted 11 lines · Heiko Stuebner
Hi Krzysztof,
Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
Quoted 4 lines
Fix DTC warning:
arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit nameplease see the comment directly above the memory node on why that needs to stay that way. So no, we'll keep the veyron memory node as is.
Damn it, I missed it.
Best regards,
Krzysztof
Heiko Stuebner
maintainerRe: [PATCH 2/2] ARM: dts: rockchip: Add missing unit address to memory node on rk3288-veyron
Am Sonntag, 28. Juli 2019, 13:38:43 CEST schrieb Krzysztof Kozlowski:
Quoted 7 lines · Heiko Stuebner
Quoted 6 lines
Hi Krzysztof,
Am Samstag, 27. Juli 2019, 16:27:36 CEST schrieb Krzysztof Kozlowski:
Quoted 2 lines
Fix DTC warning:
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
arch/arm/boot/dts/rk3288-veyron.dtsi:21.9-24.4:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit nameplease see the comment directly above the memory node on why that needs to stay that way. So no, we'll keep the veyron memory node as is.
Damn it, I missed it.
no worries :-)
Heiko Stuebner
maintainerAm Samstag, 27. Juli 2019, 16:27:35 CEST schrieb Krzysztof Kozlowski:
Quoted 4 lines
Use a space before and after assignment operator to have consistent style.
Signed-off-by Krzysztof Kozlowski <[email protected]>
I've adapted the patch around recent chromebook display changes (regarding veyron-chromebook.dtsi) and applied the result for 5.4
Thanks
Heiko