5.2.19-stable review
Subsystems (8)
Greg Kroah-Hartman
maintainerPATCH 299/313 xfs: Fix stale data exposure when readahead races with hole punch
In reply to Greg Kroah-HartmanFrom: Jan Kara <[email protected]>
commit 40144e49ff84c3bd6bd091b58115257670be8803 upstream.
Hole puching currently evicts pages from page cache and then goes on to remove blocks from the inode. This happens under both XFS_IOLOCK_EXCL and XFS_MMAPLOCK_EXCL which provides appropriate serialization with racing reads or page faults. However there is currently nothing that prevents readahead triggered by fadvise() or madvise() from racing with the hole punch and instantiating page cache page after hole punching has evicted page cache in xfs_flush_unmap_range() but before it has removed blocks from the inode. This page cache page will be mapping soon to be freed block and that can lead to returning stale data to userspace or even filesystem corruption.
Fix the problem by protecting handling of readahead requests by XFS_IOLOCK_SHARED similarly as we protect reads.
--- fs/xfs/xfs_file.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
fs/xfs/xfs_file.c +26 -0
@@ -33,6 +33,7 @@#include <linux/pagevec.h> #include <linux/backing-dev.h> #include <linux/mman.h> +#include <linux/fadvise.h> static const struct vm_operations_struct xfs_file_vm_ops;
@@ -939,6 +940,30 @@ out_unlock:return error; } +STATIC int +xfs_file_fadvise ( +struct file *file, +loff_t start, +loff_t end, +int advice) +{ +struct xfs_inode *ip =XFS_I (file_inode (file)); +int ret; +int lockflags =0 ; + +/* +* Operations creating pages in page cache need protection from hole +* punching and similar ops +*/ +if (advice ==POSIX_FADV_WILLNEED ) { + lockflags =XFS_IOLOCK_SHARED ; +xfs_ilock (ip, lockflags); + } + ret =generic_fadvise (file, start, end, advice); +if (lockflags) +xfs_iunlock (ip, lockflags); +return ret; +} STATIC loff_t xfs_file_remap_range(
@@ -1235,6 +1260,7 @@ const struct file_operations xfs_file_op .fsync = xfs_file_fsync, .get_unmapped_area = thp_get_unmapped_area, .fallocate = xfs_file_fallocate, + .fadvise = xfs_file_fadvise, .remap_file_range = xfs_file_remap_range, };
Greg Kroah-Hartman
maintainerPATCH 300/313 ipmi: move message error checking to avoid deadlock
In reply to Greg Kroah-HartmanFrom: Tony Camuso <[email protected]>
commit 383035211c79d4d98481a09ad429b31c7dbf22bd upstream.
V1->V2: in handle_one_rcv_msg, if data_size > 2, set requeue to zero and
goto out instead of calling ipmi_free_msg.
Kosuke Tatsukawa <[email protected]>
In the source stack trace below, function set_need_watch tries to take out the same si_lock that was taken earlier by ipmi_thread.
ipmi_thread() [drivers/char/ipmi/ipmi_si_intf.c:995]
smi_event_handler() [drivers/char/ipmi/ipmi_si_intf.c:765]
handle_transaction_done() [drivers/char/ipmi/ipmi_si_intf.c:555]
deliver_recv_msg() [drivers/char/ipmi/ipmi_si_intf.c:283]
ipmi_smi_msg_received() [drivers/char/ipmi/ipmi_msghandler.c:4503]
intf_err_seq() [drivers/char/ipmi/ipmi_msghandler.c:1149]
smi_remove_watch() [drivers/char/ipmi/ipmi_msghandler.c:999]
set_need_watch() [drivers/char/ipmi/ipmi_si_intf.c:1066]Upstream commit e1891cffd4c4896a899337a243273f0e23c028df adds code to ipmi_smi_msg_received() to call smi_remove_watch() via intf_err_seq() and this seems to be causing the deadlock.
commit e1891cffd4c4896a899337a243273f0e23c028df
Author: Corey Minyard <[email protected]> Date: Wed Oct 24 15:17:04 2018 -0500
ipmi: Make the smi watcher be disabled immediately when not needed
The fix is to put all messages in the queue and move the message checking code out of ipmi_smi_msg_received and into handle_one_recv_msg, which processes the message checking after ipmi_thread releases its locks.
Additionally,Kosuke Tatsukawa <[email protected]> reported that handle_new_recv_msgs calls ipmi_free_msg when handle_one_rcv_msg returns zero, so that the call to ipmi_free_msg in handle_one_rcv_msg introduced another panic when "ipmitool sensor list" was run in a loop. He submitted this part of the patch.
+free_msg:
+ requeue = 0;
+ goto out;
Reported by: Osamu Samukawa <[email protected]> Characterized by: Kosuke Tatsukawa <[email protected]>
--- drivers/char/ipmi/ipmi_msghandler.c | 114 ++++++++++++++++++------------------ 1 file changed, 57 insertions(+), 57 deletions(-)
drivers/char/ipmi/ipmi_msghandler.c +57 -57
@@ -4215,7 +4215,53 @@ static int handle_one_recv_msg(struct ipint chan;ipmi_debug_msg ("Recv:" , msg->rsp, msg->rsp_size); -if (msg->rsp_size <2 ) { + +if ((msg->data_size >=2 ) + && (msg->data[0 ] == (IPMI_NETFN_APP_REQUEST <<2 )) + && (msg->data[1 ] ==IPMI_SEND_MSG_CMD ) + && (msg->user_data ==NULL )) { + +if (intf->in_shutdown) + goto free_msg; + +/* +* This is the local response to a command send, start +* the timer for these. The user_data will not be +* NULL if this is a response send, and we will let +* response sends just go through. +*/ + +/* +* Check for errors, if we get certain errors (ones +* that mean basically we can try again later), we +* ignore them and start the timer. Otherwise we +* report the error immediately. +*/ +if ((msg->rsp_size >=3 ) && (msg->rsp[2 ] !=0 ) + && (msg->rsp[2 ] !=IPMI_NODE_BUSY_ERR ) + && (msg->rsp[2 ] !=IPMI_LOST_ARBITRATION_ERR ) + && (msg->rsp[2 ] !=IPMI_BUS_ERR ) + && (msg->rsp[2 ] !=IPMI_NAK_ON_WRITE_ERR )) { +int ch = msg->rsp[3 ] &0xf ; +struct ipmi_channel *chans; + +/* Got an error sending the message, handle it. */ + + chans =READ_ONCE (intf->channel_list)->c; +if ((chans[ch].medium ==IPMI_CHANNEL_MEDIUM_8023LAN ) + || (chans[ch].medium ==IPMI_CHANNEL_MEDIUM_ASYNC )) +ipmi_inc_stat (intf, sent_lan_command_errs); +else +ipmi_inc_stat (intf, sent_ipmb_command_errs); +intf_err_seq (intf, msg->msgid, msg->rsp[2 ]); + }else +/* The message was sent, start the timer. */ +intf_start_seq_timer (intf, msg->msgid); +free_msg: + requeue =0 ; + goto out; + + }else if (msg->rsp_size <2 ) {/* Message is too small to be correct. */ dev_warn(intf->si_dev, "BMC returned too small a message for netfn %x cmd %x, got %d bytes\n",
@@ -4472,62 +4518,16 @@ void ipmi_smi_msg_received(struct ipmi_sunsigned long flags =0 ;/* keep us warning-free. */ int run_to_completion = intf->run_to_completion; -if ((msg->data_size >=2 ) - && (msg->data[0 ] == (IPMI_NETFN_APP_REQUEST <<2 )) - && (msg->data[1 ] ==IPMI_SEND_MSG_CMD ) - && (msg->user_data ==NULL )) { - -if (intf->in_shutdown) - goto free_msg; - -/* -* This is the local response to a command send, start -* the timer for these. The user_data will not be -* NULL if this is a response send, and we will let -* response sends just go through. -*/ - -/* -* Check for errors, if we get certain errors (ones -* that mean basically we can try again later), we -* ignore them and start the timer. Otherwise we -* report the error immediately. -*/ -if ((msg->rsp_size >=3 ) && (msg->rsp[2 ] !=0 ) - && (msg->rsp[2 ] !=IPMI_NODE_BUSY_ERR ) - && (msg->rsp[2 ] !=IPMI_LOST_ARBITRATION_ERR ) - && (msg->rsp[2 ] !=IPMI_BUS_ERR ) - && (msg->rsp[2 ] !=IPMI_NAK_ON_WRITE_ERR )) { -int ch = msg->rsp[3 ] &0xf ; -struct ipmi_channel *chans; - -/* Got an error sending the message, handle it. */ - - chans =READ_ONCE (intf->channel_list)->c; -if ((chans[ch].medium ==IPMI_CHANNEL_MEDIUM_8023LAN ) - || (chans[ch].medium ==IPMI_CHANNEL_MEDIUM_ASYNC )) -ipmi_inc_stat (intf, sent_lan_command_errs); -else -ipmi_inc_stat (intf, sent_ipmb_command_errs); -intf_err_seq (intf, msg->msgid, msg->rsp[2 ]); - }else -/* The message was sent, start the timer. */ -intf_start_seq_timer (intf, msg->msgid); - -free_msg: -ipmi_free_smi_msg (msg); - }else { -/* -* To preserve message order, we keep a queue and deliver from -* a tasklet. -*/ -if (!run_to_completion) -spin_lock_irqsave (&intf->waiting_rcv_msgs_lock, flags); -list_add_tail (&msg->link, &intf->waiting_rcv_msgs); -if (!run_to_completion) -spin_unlock_irqrestore (&intf->waiting_rcv_msgs_lock, - flags); - } +/* +* To preserve message order, we keep a queue and deliver from +* a tasklet. +*/ +if (!run_to_completion) +spin_lock_irqsave (&intf->waiting_rcv_msgs_lock, flags); +list_add_tail (&msg->link, &intf->waiting_rcv_msgs); +if (!run_to_completion) +spin_unlock_irqrestore (&intf->waiting_rcv_msgs_lock, + flags);if (!run_to_completion)spin_lock_irqsave (&intf->xmit_msgs_lock, flags);
Greg Kroah-Hartman
maintainerPATCH 301/313 mtd: rawnand: stm32_fmc2: avoid warnings when building with W=1 option
In reply to Greg Kroah-HartmanFrom: Christophe Kerello <[email protected]>
commit b410f4eb01a1950ed73ae40859d0978b1a924380 upstream.
This patch solves warnings detected by setting W=1 when building.
Warnings type detected:drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function ‘stm32_fmc2_calc_timings’:drivers/mtd/nand/raw/stm32_fmc2_nand.c:1417:23: warning: comparison is always false due to limited range of data type [-Wtype-limits]
else if (tims->twait > FMC2_PMEM_PATT_TIMING_MASK)
--- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 88 ++++++++++----------------------- 1 file changed, 28 insertions(+), 60 deletions(-)
drivers/mtd/nand/raw/stm32_fmc2_nand.c +28 -60
@@ -1424,21 +1424,16 @@ static void stm32_fmc2_calc_timings(strustruct stm32_fmc2_timings *tims = &nand->timings;unsigned long hclk =clk_get_rate (fmc2->clk);unsigned long hclkp =NSEC_PER_SEC / (hclk /1000 ); -int tar, tclr, thiz, twait, tset_mem, tset_att, thold_mem, thold_att; +unsigned long timing, tar, tclr, thiz, twait; +unsigned long tset_mem, tset_att, thold_mem, thold_att; - tar = hclkp; -if (tar < sdrt->tAR_min) - tar = sdrt->tAR_min; - tims->tar =DIV_ROUND_UP (tar, hclkp) -1 ; -if (tims->tar >FMC2_PCR_TIMING_MASK ) - tims->tar =FMC2_PCR_TIMING_MASK ; - - tclr = hclkp; -if (tclr < sdrt->tCLR_min) - tclr = sdrt->tCLR_min; - tims->tclr =DIV_ROUND_UP (tclr, hclkp) -1 ; -if (tims->tclr >FMC2_PCR_TIMING_MASK ) - tims->tclr =FMC2_PCR_TIMING_MASK ; + tar = max_t(unsigned long, hclkp, sdrt->tAR_min); + timing =DIV_ROUND_UP (tar, hclkp) -1 ; + tims->tar = min_t(unsigned long, timing, FMC2_PCR_TIMING_MASK); + + tclr = max_t(unsigned long, hclkp, sdrt->tCLR_min); + timing =DIV_ROUND_UP (tclr, hclkp) -1 ; + tims->tclr = min_t(unsigned long, timing, FMC2_PCR_TIMING_MASK); tims->thiz =FMC2_THIZ ; thiz = (tims->thiz +1 ) * hclkp;
@@ -1448,18 +1443,11 @@ static void stm32_fmc2_calc_timings(stru* tWAIT > tWP * tWAIT > tREA + tIO */ - twait = hclkp; -if (twait < sdrt->tRP_min) - twait = sdrt->tRP_min; -if (twait < sdrt->tWP_min) - twait = sdrt->tWP_min; -if (twait < sdrt->tREA_max +FMC2_TIO ) - twait = sdrt->tREA_max +FMC2_TIO ; - tims->twait =DIV_ROUND_UP (twait, hclkp); -if (tims->twait ==0 ) - tims->twait =1 ; -else if (tims->twait >FMC2_PMEM_PATT_TIMING_MASK ) - tims->twait =FMC2_PMEM_PATT_TIMING_MASK ; + twait = max_t(unsigned long, hclkp, sdrt->tRP_min); + twait = max_t(unsigned long, twait, sdrt->tWP_min); + twait = max_t(unsigned long, twait, sdrt->tREA_max + FMC2_TIO); + timing =DIV_ROUND_UP (twait, hclkp); + tims->twait =clamp_val (timing,1 ,FMC2_PMEM_PATT_TIMING_MASK );/* * tSETUP_MEM > tCS - tWAIT
@@ -1474,20 +1462,15 @@ static void stm32_fmc2_calc_timings(struif (twait > thiz && (sdrt->tDS_min > twait - thiz) && (tset_mem < sdrt->tDS_min - (twait - thiz))) tset_mem = sdrt->tDS_min - (twait - thiz); - tims->tset_mem =DIV_ROUND_UP (tset_mem, hclkp); -if (tims->tset_mem ==0 ) - tims->tset_mem =1 ; -else if (tims->tset_mem >FMC2_PMEM_PATT_TIMING_MASK ) - tims->tset_mem =FMC2_PMEM_PATT_TIMING_MASK ; + timing =DIV_ROUND_UP (tset_mem, hclkp); + tims->tset_mem =clamp_val (timing,1 ,FMC2_PMEM_PATT_TIMING_MASK );/* * tHOLD_MEM > tCH * tHOLD_MEM > tREH - tSETUP_MEM * tHOLD_MEM > max(tRC, tWC) - (tSETUP_MEM + tWAIT) */ - thold_mem = hclkp; -if (thold_mem < sdrt->tCH_min) - thold_mem = sdrt->tCH_min; + thold_mem = max_t(unsigned long, hclkp, sdrt->tCH_min);if (sdrt->tREH_min > tset_mem && (thold_mem < sdrt->tREH_min - tset_mem)) thold_mem = sdrt->tREH_min - tset_mem;
@@ -1497,11 +1480,8 @@ static void stm32_fmc2_calc_timings(struif ((sdrt->tWC_min > tset_mem + twait) && (thold_mem < sdrt->tWC_min - (tset_mem + twait))) thold_mem = sdrt->tWC_min - (tset_mem + twait); - tims->thold_mem =DIV_ROUND_UP (thold_mem, hclkp); -if (tims->thold_mem ==0 ) - tims->thold_mem =1 ; -else if (tims->thold_mem >FMC2_PMEM_PATT_TIMING_MASK ) - tims->thold_mem =FMC2_PMEM_PATT_TIMING_MASK ; + timing =DIV_ROUND_UP (thold_mem, hclkp); + tims->thold_mem =clamp_val (timing,1 ,FMC2_PMEM_PATT_TIMING_MASK );/* * tSETUP_ATT > tCS - tWAIT
@@ -1523,11 +1503,8 @@ static void stm32_fmc2_calc_timings(struif (twait > thiz && (sdrt->tDS_min > twait - thiz) && (tset_att < sdrt->tDS_min - (twait - thiz))) tset_att = sdrt->tDS_min - (twait - thiz); - tims->tset_att =DIV_ROUND_UP (tset_att, hclkp); -if (tims->tset_att ==0 ) - tims->tset_att =1 ; -else if (tims->tset_att >FMC2_PMEM_PATT_TIMING_MASK ) - tims->tset_att =FMC2_PMEM_PATT_TIMING_MASK ; + timing =DIV_ROUND_UP (tset_att, hclkp); + tims->tset_att =clamp_val (timing,1 ,FMC2_PMEM_PATT_TIMING_MASK );/* * tHOLD_ATT > tALH
@@ -1542,17 +1519,11 @@ static void stm32_fmc2_calc_timings(stru* tHOLD_ATT > tRC - (tSETUP_ATT + tWAIT) * tHOLD_ATT > tWC - (tSETUP_ATT + tWAIT) */ - thold_att = hclkp; -if (thold_att < sdrt->tALH_min) - thold_att = sdrt->tALH_min; -if (thold_att < sdrt->tCH_min) - thold_att = sdrt->tCH_min; -if (thold_att < sdrt->tCLH_min) - thold_att = sdrt->tCLH_min; -if (thold_att < sdrt->tCOH_min) - thold_att = sdrt->tCOH_min; -if (thold_att < sdrt->tDH_min) - thold_att = sdrt->tDH_min; + thold_att = max_t(unsigned long, hclkp, sdrt->tALH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCLH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tCOH_min); + thold_att = max_t(unsigned long, thold_att, sdrt->tDH_min);if ((sdrt->tWB_max +FMC2_TIO +FMC2_TSYNC > tset_mem) && (thold_att < sdrt->tWB_max +FMC2_TIO +FMC2_TSYNC - tset_mem)) thold_att = sdrt->tWB_max +FMC2_TIO +FMC2_TSYNC - tset_mem;
@@ -1571,11 +1542,8 @@ static void stm32_fmc2_calc_timings(struif ((sdrt->tWC_min > tset_att + twait) && (thold_att < sdrt->tWC_min - (tset_att + twait))) thold_att = sdrt->tWC_min - (tset_att + twait); - tims->thold_att =DIV_ROUND_UP (thold_att, hclkp); -if (tims->thold_att ==0 ) - tims->thold_att =1 ; -else if (tims->thold_att >FMC2_PMEM_PATT_TIMING_MASK ) - tims->thold_att =FMC2_PMEM_PATT_TIMING_MASK ; + timing =DIV_ROUND_UP (thold_att, hclkp); + tims->thold_att =clamp_val (timing,1 ,FMC2_PMEM_PATT_TIMING_MASK ); } static int stm32_fmc2_setup_interface(struct nand_chip *chip, int chipnr,
Greg Kroah-Hartman
maintainerPATCH 302/313 ext4: fix warning inside ext4_convert_unwritten_extents_endio
In reply to Greg Kroah-HartmanFrom: Rakesh Pandit <[email protected]>
commit e3d550c2c4f2f3dba469bc3c4b83d9332b4e99e1 upstream.
Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing first argument. This was introduced in commit ff95ec22cd7f ("ext4:
add warning to ext4_convert_unwritten_extents_endio") and splitting extents inside endio would trigger it.
--- fs/ext4/extents.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ext4/extents.c +2 -2
@@ -3813,8 +3813,8 @@ static int ext4_convert_unwritten_extent* illegal. */ if (ee_block != map->m_lblk || ee_len > map->m_len) { -#ifdef EXT4_DEBUG -ext4_warning ("Inode (%ld) finished: extent logical block %llu," +#ifdef CONFIG_EXT4_DEBUG +ext4_warning (inode->i_sb,"Inode (%ld) finished: extent logical block %llu," " len %u; IO logical block %llu, len %u" , inode->i_ino, (unsigned long long )ee_block, ee_len, (unsigned long long )map->m_lblk, map->m_len);
Greg Kroah-Hartman
maintainerPATCH 303/313 ext4: fix punch hole for inline_data file systems
In reply to Greg Kroah-HartmanFrom: Theodore Ts'o <[email protected]>
commit c1e8220bd316d8ae8e524df39534b8a412a45d5e upstream.
If a program attempts to punch a hole on an inline data file, we need to convert it to a normal file first.
This was detected using ext4/032 using the adv configuration. Simple reproducer:
mke2fs -Fq -t ext4 -O inline_data /dev/vdc
mount /vdc
echo "" > /vdc/testfilexfs_io -c 'truncate 33554432' /vdc/testfilexfs_io -c 'fpunch 0 1048576' /vdc/testfile
umount /vdc
e2fsck -fy /dev/vdc
--- fs/ext4/inode.c | 9 +++++++++ 1 file changed, 9 insertions(+)
fs/ext4/inode.c +9 -0
@@ -4288,6 +4288,15 @@ int ext4_punch_hole(struct inode *inode,trace_ext4_punch_hole (inode, offset, length,0 ); +ext4_clear_inode_state (inode,EXT4_STATE_MAY_INLINE_DATA ); +if (ext4_has_inline_data (inode)) { +down_write (&EXT4_I (inode)->i_mmap_sem); + ret =ext4_convert_inline_data (inode); +up_write (&EXT4_I (inode)->i_mmap_sem); +if (ret) +return ret; + } +/* * Write out all dirty pages to avoid race conditions * Then release them.
Greg Kroah-Hartman
maintainerPATCH 304/313 quota: fix wrong condition in is_quota_modification()
In reply to Greg Kroah-HartmanFrom: Chao Yu <[email protected]>
commit 6565c182094f69e4ffdece337d395eb7ec760efc upstream.
Quoted from
commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize")
" At LSF we decided that if we truncate up from isize we shouldn't trim
fallocated blocks that were fallocated with KEEP_SIZE and are past the
new i_size. This patch fixes ext4 to do this. "
And generic/092 of fstest have covered this case for long time, however is_quota_modification() didn't adjust based on that rule, so that in below condition, we will lose to quota block change:
- fallocate blocks beyond EOF
- remount
- truncate(file_path, file_size)
Fix it.
--- include/linux/quotaops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/quotaops.h +1 -1
@@ -22,7 +22,7 @@ static inline struct quota_info *sb_dqop/* i_mutex must being held */ static inline bool is_quota_modification (struct inode *inode,struct iattr *ia) { -return (ia->ia_valid &ATTR_SIZE && ia->ia_size != inode->i_size) || +return (ia->ia_valid &ATTR_SIZE ) || (ia->ia_valid &ATTR_UID && !uid_eq (ia->ia_uid, inode->i_uid)) || (ia->ia_valid &ATTR_GID && !gid_eq (ia->ia_gid, inode->i_gid)); }
Greg Kroah-Hartman
maintainerPATCH 305/313 hwrng: core - dont wait on add_early_randomness()
In reply to Greg Kroah-HartmanFrom: Laurent Vivier <[email protected]>
commit 78887832e76541f77169a24ac238fccb51059b63 upstream.
add_early_randomness() is called by hwrng_register() when the hardware is added. If this hardware and its module are present at boot, and if there is no data available the boot hangs until data are available and can't be interrupted.
For instance, in the case of virtio-rng, in some cases the host can be not able to provide enough entropy for all the guests.
We can have two easy ways to reproduce the problem but they rely on misconfiguration of the hypervisor or the egd daemon:
- if virtio-rng device is configured to connect to the egd daemon of the host but when the virtio-rng driver asks for data the daemon is not connected,
- if virtio-rng device is configured to connect to the egd daemon of the host but the egd daemon doesn't provide data.
The guest kernel will hang at boot until the virtio-rng driver provides enough data.
To avoid that, call rng_get_data() in non-blocking mode (wait=0) from add_early_randomness().
--- drivers/char/hw_random/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hw_random/core.c +1 -1
@@ -67,7 +67,7 @@ static void add_early_randomness(structsize_t size =min_t (size_t,16 ,rng_buffer_size ());mutex_lock (&reading_mutex); - bytes_read =rng_get_data (rng, rng_buffer, size,1 ); + bytes_read =rng_get_data (rng, rng_buffer, size,0 );mutex_unlock (&reading_mutex);if (bytes_read >0 )add_device_randomness (rng_buffer, bytes_read);
Greg Kroah-Hartman
maintainerPATCH 306/313 i2c: riic: Clear NACK in tend isr
In reply to Greg Kroah-HartmanFrom: Chris Brandt <[email protected]>
commit a71e2ac1f32097fbb2beab098687a7a95c84543e upstream.
The NACKF flag should be cleared in INTRIICNAKI interrupt processing as description in HW manual.
This issue shows up quickly when PREEMPT_RT is applied and a device is probed that is not plugged in (like a touchscreen controller). The result is endless interrupts that halt system boot.
--- drivers/i2c/busses/i2c-riic.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-riic.c +1 -0
@@ -202,6 +202,7 @@ static irqreturn_t riic_tend_isr(int irqif (readb (riic->base +RIIC_ICSR2 ) &ICSR2_NACKF ) {/* We got a NACKIE */ readb (riic->base +RIIC_ICDRR );/* dummy read */ +riic_clear_set_bit (riic,ICSR2_NACKF ,0 ,RIIC_ICSR2 ); riic->err = -ENXIO ; }else if (riic->bytes_left) {return IRQ_NONE ;
Greg Kroah-Hartman
maintainerPATCH 307/313 CIFS: fix max ea value size
In reply to Greg Kroah-HartmanFrom: Murphy Zhou <[email protected]>
commit 63d37fb4ce5ae7bf1e58f906d1bf25f036fe79b2 upstream.
It should not be larger then the slab max buf size. If user specifies a larger size, it passes this check and goes straightly to SMB2_set_info_init performing an insecure memcpy.
--- fs/cifs/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/xattr.c +1 -1
@@ -31,7 +31,7 @@#include "cifs_fs_sb.h" #include "cifs_unicode.h" -#define MAX_EA_VALUE_SIZE 65535 +#define MAX_EA_VALUE_SIZE CIFSMaxBufSize#define CIFS_XATTR_CIFS_ACL "system.cifs_acl"#define CIFS_XATTR_ATTRIB "cifs.dosattrib"/* full name: user.cifs.dosattrib */ #define CIFS_XATTR_CREATETIME "cifs.creationtime"/* user.cifs.creationtime */
Greg Kroah-Hartman
maintainerPATCH 308/313 CIFS: Fix oplock handling for SMB 2.1+ protocols
In reply to Greg Kroah-HartmanFrom: Pavel Shilovsky <[email protected]>
commit a016e2794fc3a245a91946038dd8f34d65e53cc3 upstream.
There may be situations when a server negotiates SMB 2.1 protocol version or higher but responds to a CREATE request with an oplock rather than a lease.
Currently the client doesn't handle such a case correctly:
when another CREATE comes in the server sends an oplock break to the initial CREATE and the client doesn't send an ack back due to a wrong caching level being set (READ instead of RWH). Missing an oplock break ack makes the server wait until the break times out which dramatically increases the latency of the second CREATE.
Fix this by properly detecting oplocks when using SMB 2.1 protocol version and higher.
--- fs/cifs/smb2ops.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/cifs/smb2ops.c +5 -0
@@ -3254,6 +3254,11 @@ smb21_set_oplock_level(struct cifsInodeIif (oplock ==SMB2_OPLOCK_LEVEL_NOCHANGE )return ; +/* Check if the server granted an oplock rather than a lease */ +if (oplock &SMB2_OPLOCK_LEVEL_EXCLUSIVE ) +return smb2_set_oplock_level (cinode, oplock, epoch, + purge_cache); +if (oplock &SMB2_LEASE_READ_CACHING_HE ) { new_oplock |=CIFS_CACHE_READ_FLG ;strcat (message,"R" );
Greg Kroah-Hartman
maintainerPATCH 309/313 drm/amd/display: Restore backlight brightness after system resume
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
commit bb264220d9316f6bd7c1fd84b8da398c93912931 upstream.
Laptops with AMD APU doesn't restore display backlight brightness after system resume.
This issue started when DC was introduced.
Let's use BL_CORE_SUSPENDRESUME so the backlight core calls update_status callback after system resume to restore the backlight level.
Tested on Dell Inspiron 3180 (Stoney Ridge) and Dell Latitude 5495 (Raven Ridge).
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -0
@@ -1958,6 +1958,7 @@ static int amdgpu_dm_backlight_get_brigh }static const struct backlight_ops amdgpu_dm_backlight_ops = { + .options =BL_CORE_SUSPENDRESUME , .get_brightness = amdgpu_dm_backlight_get_brightness, .update_status = amdgpu_dm_backlight_update_status, };
Greg Kroah-Hartman
maintainerPATCH 310/313 md/raid0: avoid RAID0 data corruption due to layout confusion.
In reply to Greg Kroah-HartmanFrom: NeilBrown <[email protected]>
[ Upstream commit c84a1372df929033cb1a0441fb57bd3932f39ac9 ]
If the drives in a RAID0 are not all the same size, the array is divided into zones.
The first zone covers all drives, to the size of the smallest. The second zone covers all drives larger than the smallest, up to the size of the second smallest - etc.
A change in Linux 3.14 unintentionally changed the layout for the second and subsequent zones. All the correct data is still stored, but each chunk may be assigned to a different device than in pre-3.14 kernels. This can lead to data corruption.
It is not possible to determine what layout to use - it depends which kernel the data was written by.
So we add a module parameter to allow the old (0) or new (1) layout to be specified, and refused to assemble an affected array if that parameter is not set.
--- drivers/md/raid0.c | 33 ++++++++++++++++++++++++++++++++- drivers/md/raid0.h | 14 ++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-)
drivers/md/raid0.c +32 -1
@@ -19,6 +19,9 @@#include "raid0.h" #include "raid5.h" +static int default_layout =0 ; +module_param (default_layout, int,0644 ); +#define UNSUPPORTED_MDDEV_FLAGS \ ((1L << MD_HAS_JOURNAL) | \ (1L << MD_JOURNAL_CLEAN) | \
@@ -139,6 +142,19 @@ static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf) }pr_debug ("md/raid0:%s: FINAL %d zones\n" ,mdname (mddev), conf->nr_strip_zones); + +if (conf->nr_strip_zones ==1 ) { + conf->layout =RAID0_ORIG_LAYOUT ; + }else if (default_layout ==RAID0_ORIG_LAYOUT || + default_layout ==RAID0_ALT_MULTIZONE_LAYOUT ) { + conf->layout = default_layout; + }else { +pr_err ("md/raid0:%s: cannot assemble multi-zone RAID0 with default_layout setting\n" , +mdname (mddev)); +pr_err ("md/raid0: please set raid.default_layout to 1 or 2\n" ); + err = -ENOTSUPP ; + goto abort; + }/* * now since we have the hard sector sizes, we can make sure * chunk size is a multiple of that sector size
@@ -547,10 +563,12 @@ static void raid0_handle_discard(struct mddev *mddev, struct bio *bio)static bool raid0_make_request (struct mddev *mddev,struct bio *bio) { +struct r0conf *conf = mddev->private;struct strip_zone *zone;struct md_rdev *tmp_dev;sector_t bio_sector;sector_t sector; +sector_t orig_sector;unsigned chunk_sects;unsigned sectors;
@@ -584,8 +602,21 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio) bio = split; } + orig_sector = sector; zone =find_zone (mddev->private, §or); - tmp_dev =map_sector (mddev, zone, sector, §or); +switch (conf->layout) { +case RAID0_ORIG_LAYOUT : + tmp_dev =map_sector (mddev, zone, orig_sector, §or); +break ; +case RAID0_ALT_MULTIZONE_LAYOUT : + tmp_dev =map_sector (mddev, zone, sector, §or); +break ; +default : +WARN ("md/raid0:%s: Invalid layout\n" ,mdname (mddev)); +bio_io_error (bio); +return true; + } +bio_set_dev (bio, tmp_dev->bdev); bio->bi_iter.bi_sector = sector + zone->dev_start + tmp_dev->data_offset;
drivers/md/raid0.h +14 -0
@@ -8,11 +8,25 @@ struct strip_zone { int nb_dev; /* # of devices attached to the zone */ }; +/* Linux 3.14 (20d0189b101) made an unintended change to +* the RAID0 layout for multi-zone arrays (where devices aren't all +* the same size. +* RAID0_ORIG_LAYOUT restores the original layout +* RAID0_ALT_MULTIZONE_LAYOUT uses the altered layout +* The layouts are identical when there is only one zone (all +* devices the same size). +*/ + +enum r0layout { +RAID0_ORIG_LAYOUT =1 , +RAID0_ALT_MULTIZONE_LAYOUT =2 , +};struct r0conf {struct strip_zone *strip_zone;struct md_rdev **devlist;/* lists of rdevs, pointed to * by strip_zone->dev */ int nr_strip_zones; +enum r0layout layout; };#endif
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 311/313 mt76: mt7615: always release sem in mt7615_load_patch
In reply to Greg Kroah-HartmanFrom: Lorenzo Bianconi <[email protected]>
[ Upstream commit 2fc446487c364bf8bbd5f8f5f27e52d914fa1d72 ]
Release patch semaphore even if request_firmware fails in mt7615_load_patch
--- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +3 -3
@@ -289,9 +289,9 @@ static int mt7615_driver_own(struct mt7615_dev *dev)static int mt7615_load_patch (struct mt7615_dev *dev) { -const struct firmware *fw; -const struct mt7615_patch_hdr *hdr;const char *firmware =MT7615_ROM_PATCH ; +const struct mt7615_patch_hdr *hdr; +const struct firmware *fw =NULL ;int len, ret, sem; sem =mt7615_mcu_patch_sem_ctrl (dev,1 );
@@ -307,7 +307,7 @@ static int mt7615_load_patch(struct mt7615_dev *dev) ret =request_firmware (&fw, firmware, dev->mt76.dev);if (ret) -return ret; + goto out;if (!fw || !fw->data || fw->size <sizeof (*hdr)) {dev_err (dev->mt76.dev,"Invalid firmware\n" );
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 312/313 mt76: mt7615: fix mt7615 firmware path definitions
In reply to Greg Kroah-HartmanFrom: Lorenzo Bianconi <[email protected]>
[ Upstream commit 9d4d0d06bbf9f7e576b0ebbb2f77672d0fc7f503 ]
mt7615 patch/n9/cr4 firmwares are available in mediatek folder in linux-firmware repository. Because of this mt7615 won't work on regular distributions like Ubuntu. Fix path definitions. Moreover remove useless firmware name pointers and use definitions directly
--- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 11 ++++------- drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h | 6 +++--- 2 files changed, 7 insertions(+), 10 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +4 -7
@@ -289,7 +289,6 @@ static int mt7615_driver_own(struct mt7615_dev *dev)static int mt7615_load_patch (struct mt7615_dev *dev) { -const char *firmware =MT7615_ROM_PATCH ;const struct mt7615_patch_hdr *hdr;const struct firmware *fw =NULL ;int len, ret, sem;
@@ -305,7 +304,7 @@ static int mt7615_load_patch(struct mt7615_dev *dev)return -EAGAIN ; } - ret =request_firmware (&fw, firmware, dev->mt76.dev); + ret =request_firmware (&fw,MT7615_ROM_PATCH , dev->mt76.dev);if (ret) goto out;
@@ -371,14 +370,12 @@ static u32 gen_dl_mode(u8 feature_set, bool is_cr4)static int mt7615_load_ram (struct mt7615_dev *dev) { -const struct firmware *fw;const struct mt7615_fw_trailer *hdr; -const char *n9_firmware =MT7615_FIRMWARE_N9 ; -const char *cr4_firmware =MT7615_FIRMWARE_CR4 ;u32 n9_ilm_addr, offset;int i, ret; +const struct firmware *fw; - ret =request_firmware (&fw, n9_firmware, dev->mt76.dev); + ret =request_firmware (&fw,MT7615_FIRMWARE_N9 , dev->mt76.dev);if (ret)return ret;
@@ -426,7 +423,7 @@ static int mt7615_load_ram(struct mt7615_dev *dev)release_firmware (fw); - ret =request_firmware (&fw, cr4_firmware, dev->mt76.dev); + ret =request_firmware (&fw,MT7615_FIRMWARE_CR4 , dev->mt76.dev);if (ret)return ret;
drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h +3 -3
@@ -25,9 +25,9 @@#define MT7615_RX_RING_SIZE 1024#define MT7615_RX_MCU_RING_SIZE 512 -#define MT7615_FIRMWARE_CR4 "mt7615_cr4.bin" -#define MT7615_FIRMWARE_N9 "mt7615_n9.bin" -#define MT7615_ROM_PATCH "mt7615_rom_patch.bin" +#define MT7615_FIRMWARE_CR4 "mediatek/mt7615_cr4.bin" +#define MT7615_FIRMWARE_N9 "mediatek/mt7615_n9.bin" +#define MT7615_ROM_PATCH "mediatek/mt7615_rom_patch.bin"#define MT7615_EEPROM_SIZE 1024#define MT7615_TOKEN_SIZE 4096
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 313/313 platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed
In reply to Greg Kroah-HartmanFrom: Pi-Hsun Shih <[email protected]>
[ Upstream commit 71cddb7097e2b0feb855d7fd7d59afd12cbee4bb ]
Since the rpmsg_endpoint is created before probe is called, it's possible that a host event is received during cros_ec_register, and there would be some pending work in the host_event_work workqueue while cros_ec_register is called.
If cros_ec_register fails, when the leftover work in host_event_work run, the ec_dev from the drvdata of the rpdev could be already set to NULL, causing kernel crash when trying to run cros_ec_get_next_event.
Fix this by creating the rpmsg_endpoint by ourself, and when cros_ec_register fails (or on remove), destroy the endpoint first (to make sure there's no more new calls to cros_ec_rpmsg_callback), and then cancel all works in the host_event_work workqueue.
--- drivers/platform/chrome/cros_ec_rpmsg.c | 32 +++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-)
drivers/platform/chrome/cros_ec_rpmsg.c +28 -4
@@ -41,6 +41,7 @@ struct cros_ec_rpmsg {struct rpmsg_device *rpdev;struct completion xfer_ack;struct work_struct host_event_work; +struct rpmsg_endpoint *ept; };/**
@@ -72,7 +73,6 @@ static int cros_ec_pkt_xfer_rpmsg(struct cros_ec_device *ec_dev, struct cros_ec_command *ec_msg) {struct cros_ec_rpmsg *ec_rpmsg = ec_dev->priv; -struct rpmsg_device *rpdev = ec_rpmsg->rpdev;struct ec_host_response *response;unsigned long timeout;int len;
@@ -85,7 +85,7 @@ static int cros_ec_pkt_xfer_rpmsg(struct cros_ec_device *ec_dev,dev_dbg (ec_dev->dev,"prepared, len=%d\n" , len);reinit_completion (&ec_rpmsg->xfer_ack); - ret =rpmsg_send (rpdev->ept, ec_dev->dout, len); + ret =rpmsg_send (ec_rpmsg->ept, ec_dev->dout, len);if (ret) {dev_err (ec_dev->dev,"rpmsg send failed\n" );return ret;
@@ -196,11 +196,24 @@ static int cros_ec_rpmsg_callback(struct rpmsg_device *rpdev, void *data,return 0 ; } +static struct rpmsg_endpoint * +cros_ec_rpmsg_create_ept (struct rpmsg_device *rpdev) +{ +struct rpmsg_channel_info chinfo = {}; + +strscpy (chinfo.name, rpdev->id.name,RPMSG_NAME_SIZE ); + chinfo.src = rpdev->src; + chinfo.dst =RPMSG_ADDR_ANY ; + +return rpmsg_create_ept (rpdev, cros_ec_rpmsg_callback,NULL , chinfo); +} +static int cros_ec_rpmsg_probe (struct rpmsg_device *rpdev) {struct device *dev = &rpdev->dev;struct cros_ec_rpmsg *ec_rpmsg;struct cros_ec_device *ec_dev; +int ret; ec_dev =devm_kzalloc (dev,sizeof (*ec_dev),GFP_KERNEL );if (!ec_dev)
@@ -225,7 +238,18 @@ static int cros_ec_rpmsg_probe(struct rpmsg_device *rpdev)INIT_WORK (&ec_rpmsg->host_event_work, cros_ec_rpmsg_host_event_function); -return cros_ec_register (ec_dev); + ec_rpmsg->ept =cros_ec_rpmsg_create_ept (rpdev); +if (!ec_rpmsg->ept) +return -ENOMEM ; + + ret =cros_ec_register (ec_dev); +if (ret <0 ) { +rpmsg_destroy_ept (ec_rpmsg->ept); +cancel_work_sync (&ec_rpmsg->host_event_work); +return ret; + } + +return 0 ; }static void cros_ec_rpmsg_remove (struct rpmsg_device *rpdev)
@@ -233,6 +257,7 @@ static void cros_ec_rpmsg_remove(struct rpmsg_device *rpdev)struct cros_ec_device *ec_dev =dev_get_drvdata (&rpdev->dev);struct cros_ec_rpmsg *ec_rpmsg = ec_dev->priv; +rpmsg_destroy_ept (ec_rpmsg->ept);cancel_work_sync (&ec_rpmsg->host_event_work); }
@@ -249,7 +274,6 @@ static struct rpmsg_driver cros_ec_driver_rpmsg = { }, .probe = cros_ec_rpmsg_probe, .remove = cros_ec_rpmsg_remove, - .callback = cros_ec_rpmsg_callback, };module_rpmsg_driver (cros_ec_driver_rpmsg);
Signature · 1 line
2.20.1
stable-rc/linux-5.2.y boot: 136 boots: 1 failed, 126 passed with 9 offline (v5.2.18-314-g2c8369f13ff8)
stable-rc/linux-5.2.y boot: 136 boots: 1 failed, 126 passed with 9 offline (v5.2.18-314-g2c8369f13ff8)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/
Tree: stable-rc
Branch: linux-5.2.y
Git Describe: v5.2.18-314-g2c8369f13ff8
Git Commit: 2c8369f13ff8c1375690964c79ffdc0e41ab4f97
Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 80 unique boards, 27 SoC families, 16 builds out of 209
Boot Failure Detected:
arm64:
defconfig:
gcc-8:
rk3399-firefly: 1 failed lab
Offline Platforms:
arm:
qcom_defconfig:
gcc-8
qcom-apq8064-cm-qs600: 1 offline lab
qcom-apq8064-ifc6410: 1 offline lab
davinci_all_defconfig:
gcc-8
dm365evm,legacy: 1 offline lab
sunxi_defconfig:
gcc-8
sun5i-r8-chip: 1 offline lab
sun7i-a20-bananapi: 1 offline lab
multi_v7_defconfig:
gcc-8
qcom-apq8064-cm-qs600: 1 offline lab
qcom-apq8064-ifc6410: 1 offline lab
sun5i-r8-chip: 1 offline labarm64:
defconfig:
gcc-8
apq8016-sbc: 1 offline lab---
For more info write to <[email protected]>
Quoted 11 lines · kernelci.org bot
stable-rc/linux-5.2.y boot: 136 boots: 1 failed, 126 passed with 9 offline (v5.2.18-314-g2c8369f13ff8)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/Tree: stable-rc
Branch: linux-5.2.y
Git Describe: v5.2.18-314-g2c8369f13ff8
Git Commit:2c8369f13ff8c1375690964c79ffdc0e41ab4f97
Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 80 unique boards, 27 SoC families, 16 builds out of 209
TL;DR; all is well.
Quoted 6 lines
Boot Failure Detected:
arm64:
defconfig:
gcc-8:
rk3399-firefly: 1 failed lab
There's a known issue on this board I've been trying to debug with the mediatek maintainers, and we're not sure yet if it's a kernel issue or a hardware issue on my board, but for now, nothing to worry about for stable.
Kevin
Greg Kroah-Hartman
maintainerQuoted 23 lines · Kevin Hilman
Quoted 11 lines · kernelci.org bot
stable-rc/linux-5.2.y boot: 136 boots: 1 failed, 126 passed with 9 offline (v5.2.18-314-g2c8369f13ff8)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.2.y/kernel/v5.2.18-314-g2c8369f13ff8/Tree: stable-rc
Branch: linux-5.2.y
Git Describe: v5.2.18-314-g2c8369f13ff8
Git Commit:2c8369f13ff8c1375690964c79ffdc0e41ab4f97
Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 80 unique boards, 27 SoC families, 16 builds out of 209TL;DR; all is well.
Quoted 6 lines
Boot Failure Detected:
arm64:
defconfig:
gcc-8:
rk3399-firefly: 1 failed lab
Quoted 4 lines
There's a known issue on this board I've been trying to debug with the mediatek maintainers, and we're not sure yet if it's a kernel issue or a hardware issue on my board, but for now, nothing to worry about for stable.
Thanks for the explaination and summary!
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.2.19 release. There are 313 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat 05 Oct 2019 03:37:47 PM UTC. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.2.19-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.2.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.2.19 release. There are 313 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat 05 Oct 2019 03:37:47 PM UTC. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.2.19-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.2.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Test results for stable-v5.2:
12 builds: 12 pass, 0 fail
22 boots: 22 pass, 0 fail
38 tests: 38 pass, 0 failLinux version: 5.2.19-rc1-g2c8369f13ff8
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04Cheers
Jon
Signature · 1 line
nvpublic
Quoted 7 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.2.19 release. There are 313 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat 05 Oct 2019 03:37:47 PM UTC. Anything received after that time might be too late.
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 5.2.19-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-5.2.y
git commit: 2c8369f13ff8c1375690964c79ffdc0e41ab4f97
git describe: v5.2.18-314-g2c8369f13ff8
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-5.2-oe/build/v5.2.18-314-g2c8369f13ff8
No regressions (compared to build v5.2.18)
No fixes (compared to build v5.2.18)
Ran 24453 total tests in the following environments and test suites.
Environments
--------------
- dragonboard-410c
- hi6220-hikey
- i386
- juno-r2
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15
- x86
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libgpiod
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-timers-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* ltp-dio-tests
* ltp-io-tests
* ltp-syscalls-tests
* network-basic-tests
* ltp-open-posix-tests
* kvm-unit-tests
* ssuite
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Guenter Roeck
maintainerQuoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.2.19 release. There are 313 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat 05 Oct 2019 03:37:47 PM UTC. Anything received after that time might be too late.
Build results:
total: 159 pass: 159 fail: 0 Qemu test results: total: 390 pass: 390 fail: 0
Guenter